Loop Issue

[Queener]

$Coords = PixelSearch(1009, -875, 1108, -762, 0x968A4B)
$Coords2 = PixelSearch(269, -774, 907, -468, 0xC30000)
$Coords3 = PixelSearch(132, -907, 196, -900, 0x470137)
 
while 1
    WinActivate("mspaint", "")
    sleep(500)
    if IsArray($Coords) = true Then
    GoHere()
    sleep(500)
    elseif IsArray($Coords2) = true Then
    GoHere2()
ElseIf IsArray($Coords3) = true Then
    GoHere3()
EndIf
WEnd
 
Func GoHere()
    while 1
    if IsArray($Coords) = True Then
MouseMove($Coords[0],$Coords[1],1)
MouseDown("Left")
sleep(5000)
MouseUp("Left")
WEnd
EndFunc

 

The code works, but for some reason, it keep looping the GoHere() None stop eventhough the pixel is being replaced. Which ever function is being called first will infinite loop. What I want is if that function call for a pixel and if it no longer exist or seeing in mspaint; that it move to the next Function.

 

 

[jaberwacky]

You are missing an EndIf. Try this and see if it works then:

$Coords = PixelSearch(1009, -875, 1108, -762, 0x968A4B)
$Coords2 = PixelSearch(269, -774, 907, -468, 0xC30000)
$Coords3 = PixelSearch(132, -907, 196, -900, 0x470137)

while 1
  WinActivate("mspaint", "")
  
  sleep(500)
  
  if IsArray($Coords) = true Then
    GoHere()
    sleep(500)
  elseif IsArray($Coords2) = true Then
    GoHere2()
  ElseIf IsArray($Coords3) = true Then
    GoHere3()
  EndIf
WEnd

Func GoHere()
  while 1
    if IsArray($Coords) = True Then
      MouseMove($Coords[0],$Coords[1],1)
      MouseDown("Left")
      sleep(5000)
      MouseUp("Left")
    EndIf
  WEnd
EndFunc

Also, there is no break out of the while loop in GoHere().  Use an ExitLoop, strategically placed, might do the trick.

Edited August 6, 2013 by jaberwocky6669

[Queener]

correct me if I'm wrong but if I add the exitloop as:

Func GoHere()
  while 1
    if IsArray($Coords) = True Then
      MouseMove($Coords[0],$Coords[1],1)
      MouseDown("Left")
      sleep(5000)
      MouseUp("Left")
else
exitloop
    EndIf
  WEnd
EndFunc

doesn't that exit the entire loop? I believe I tried that also and it stops what its doing until I close the program and reopen.

Edited August 6, 2013 by asianqueen

[hiho]

Why do you have a loop in GoHere() and what's the poin of the double isarray check? PixelSearch always returns an array?

[BrewManNH]

Your problem is that your PixelSearch is outside of the loop, it's only checked once before you enter the While loop. So the results are always going to be the same no matter what is happening on the screen.

Also, you're checking if the variables are arrays even after you've checked that they're arrays. Your While loop checks $coords, then you check it again inside the GoHere function, and you're stuck inside the While loop in that function with no exit. Whatever it is you're trying to do, you're doing it all wrong.

[Queener]

Nvm, Found a tutorial and use it to impliment into 3 color array. Works great! I tried both individual method which cause overstack so I continue onto array instead;

HotKeySet("{ESC}", "Quit")

    WinActivate("Just a test.bmp - Paint", "")
    WinSetState("Just a test.bmp - Paint", "", @SW_MAXIMIZE)
    Dim $pos[2]
    Global $counter=0
    Global $on=0


start()
Func Start()

Local $color[3]= [0xED1C24, 0x22B14C, 0xB97A57]

$on = 1
While $on = 1
    For $i = 0 to 1
    $pos = PixelSearch(0,0, 530, 330, $color[$i], 20, 1)
    if not @error Then
        MouseMove($pos[0],$pos[1],0)
        sleep(20)
        mousedown("left")
    EndIf
    Next
    if @error Then
        $counter = $counter+1
    EndIf
    if $counter>5 Then
        $on=0
        Mouseup("Left")
        MsgBox(1, "Color", "Colored")
    EndIf
WEnd