Help formatting simple "if" logic

[sackjarrow]

Hi,

 
If $aLine[2] = "" or
   $aLine[2] = "Ingen" or
   $aLine[2] = "//www.powertech.no/cgi-bin/mailform" or
   $aLine[2] = "Send" or
   $aLine[2] = "none" or 
   $aLine[2] = "off" Then _ArrayDelete($aBody, $i)

 The above code gives me error ""If" statements must have a "Then" keyword.". Whereas if I type it on a single line..:
 

If $aLine[2] = "" or $aLine[2] = "Ingen" or $aLine[2] = "//www.powertech.no/cgi-bin/mailform" or $aLine[2] = "Send" or $aLine[2] = "none" or $aLine[2] = "off" Then _ArrayDelete($aBody, $i)

 
..it works perfectly fine. This is just an aesthetic issue, but it's much easier to work with the formatting in case 1 since I'll be adding a lot of "or's".

What's the best way to go about this?

[hiho]

if @HOUR > 0 Or _
    @HOUR < 24 Then
    MsgBox(0, "", "This works!")
EndIf

[somdcomputerguy]

The Switch conditional statement would probably be better to use here, the underline character (as posted above) would work fine too. Refer to the Help file for details
 

[sackjarrow]

Thanks, that underscore solved a lot of problems!
 
About Switch I'm not so sure since I think I would have to state " _ArrayDelete($aBody, $i)" for every case which would be kinda tiresome. e.g:
 

Switch $aLine[2]
    Case """"
        _ArrayDelete($aBody, $i)
    Case "Ingen"
        _ArrayDelete($aBody, $i)
    Case "Send"
        _ArrayDelete($aBody, $i)
;etc. etc.
EndSwitch

..or am I just using Switch wrong?

[BrewManNH]

Switch $aLine[2]
    Case """", "Ingen", "Send"
        _ArrayDelete($aBody, $i)
;etc. etc.
EndSwitch

You can put multiple tests on a Case statement for Switch, separated by commas. As long as they all are going to do the same thing if matched, you can do it all on one line.

[sackjarrow]

Cool. But since I am going for an organized structure I'd prefer having everything on separated lines. So I might aswell go for "if" with underscores:

If $aLine[2] = "" or _
   $aLine[2] = "Ingen" or _
   $aLine[2] = "//www.powertech.no/cgi-bin/mailform" or _
   $aLine[2] = "Send" or _
   $aLine[2] = "none" or _
   $aLine[2] = "off" Then _ArrayDelete($aBody, $i)

I'm just trying to evaluate why somdcomputerguy said it would be better to use "switch".

[kylomas]

I'm just trying to evaluate why somdcomputerguy said it would be better to use "switch".

 

BrewmanNH just showed you.

[BrewManNH]

Switch is usually faster than If statements. You can put everything on one line without a lot of Ors.

EDIT: You can also use the continuation character in the case statement of a switch.

Switch $aLine[2]
    Case """", _
            "Ingen", _
            "Send"
        _ArrayDelete($aBody, $i)
        ;etc. etc.
EndSwitch

Edited August 22, 2013 by BrewManNH

[somdcomputerguy]

I know that Switch is a bit faster than multiple If's, but I meant 'better' in the 'aesthetic', 'easier to read code' case. In my mind, I was seeing something similar to BrewmanNH's post (#5).

[sackjarrow]

Ah yes you are correct, now I see. By using switch in this case I save typing "$aLine[2] =" for every condition. And when using continuation characters I can get everything on separated lines as well for nice clean structure.Thanks! 

Sack

[somdcomputerguy]