Bubblesort

[Thanzex]

Hi all! Sorry for my bad english.

A few minutes ago i started coding the famous bubblesort algorithm.

This is the code with a shitty GUI made just for input the values faster.

expandcollapse popup

#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
#include <Array.au3>
#Region ### START Koda GUI section ### Form=
$Form2 = GUICreate("Form2", 405, 61, 302, 218)
$insert = GUICtrlCreateInput("Insert", 16, 16, 121, 21)
$inserted = GUICtrlCreateButton("inserted", 160, 16, 75, 25,$BS_DEFPUSHBUTTON)
$ok = GUICtrlCreateButton("ok", 256, 16, 75, 25)
GUISetState(@SW_SHOW)
#EndRegion ### END Koda GUI section ###
$First=true
While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit

        Case $inserted
            if $First Then
                Global $Array[1]=[GUICtrlRead($insert)]
                GUICtrlSetData($insert,"")
                $First=False
            Else
                _ArrayAdd($Array,GUICtrlRead($insert))
                GUICtrlSetData($insert,"")
            EndIf

        Case $ok
            Ordina()

    EndSwitch
WEnd

Func Ordina()
    $max=UBound($Array)
    While $max>0
    For $i=0 To $max-2
        If $Array[$i]>$Array[$i+1] Then
            _ArraySwap($Array[$i],$Array[$i+1])
        EndIf
        Next
        $max=$max-1
    WEnd
    _ArrayDisplay($Array)
Exit
EndFunc 

It all worked great until i noticed this error:

i don't know how to explain it well in english, but the numbers are ordered in a strange way, this is a photo of the result:

The script consider only the first 3 digits in this case, because the shortest number is made of three digits so it looks like:

123

124

125

127

It's not considering the real value of the number.

Any ideas? 

[Melba23]

Thanzex,

Welcome to the AutoIt forum.

As you can see the sort algorithm is treating the values as strings and sorting them on the ASCII values of the characters. Use Number to force the comparison to use their numeric value:

If Number($Array[$i]) > Number($Array[$i + 1]) Then

Please ask if you have any further questions.

M23

[ajag]

...or replace the line

_ArrayAdd($Array,GUICtrlRead($insert))

with

_ArrayAdd($Array,Int(GUICtrlRead($insert)))

 

A-Jay

[DatMCEyeBall]

...or replace the line

_ArrayAdd($Array,GUICtrlRead($insert))

with

_ArrayAdd($Array,Int(GUICtrlRead($insert)))

A-Jay

_ArrayAdd($Array, Number(GUICtrlRead($insert)))

WIll allow for negative numbers.