"If" statement has no matching "EndIf" statement.:

[mcintoow]

First time post so please let me know if the format is incorrect or I'm posting in the wronf forum.

I'm having issue with this script. I'm hoping someone can help me out.

The below script works as expected.

 

expandcollapse popup

if FileExists ("H:\documents\wordq\*.wdq") then
   MsgBox (4096, ".WDQ", "Exist")
   Else
   ShellExecute ("notepad.exe")
endif
  
#Include <File.au3>
#Include <Array.au3>
#include <GUIConstantsEx.au3>
#include <GUIComboBox.au3>
#include <Process.au3>
$dst = "h:\documents\wordq\" ;specify folder
$a_FileList = _FileListToArray2()
_ArraySort($a_FileList, 1, 1, $a_FileList[0][0], 1)
ShellExecute($a_FileList[1][0])
Func _FileListToArray2($s_Mask='*')
$h_Search = FileFindFirstFile($dst & '\' & $s_Mask)
$s_FileName = FileFindNextFile($h_Search)
If Not @error Then
   Dim $a_File[100][2]
   dim $sExt
   While Not @error
  
   $sExt = stringright($s_Filename, 4)
    if ($sext = ".wdq") then
    MsgBox(4096, "Extension", $sExt)
   
  
       if StringInStr($s_FileName,'.',0,-1) Then
           $s_FullName = $dst & '\' & $s_FileName
       
       
           $a_File[0][0] += 1
           If $a_File[0][0] >= UBound($a_File) Then
               ReDim $a_File[$a_File[0][0] * 2][2]
           EndIf
           $a_File[$a_File[0][0]][0] = FileGetLongName($s_FullName)
           $a_File[$a_File[0][0]][1] = FileGetTime($s_FullName,0,1)
  EndIf
  EndIf 
       $s_FileName = FileFindNextFile($h_Search)
   WEnd
   ReDim $a_File[$a_File[0][0] + 1][2]
   Return $a_File
 
EndIf
EndFunc

But what I really want to do is check if H:documentswordq*.wdq exists and if it does I want to open the newest *.wdq file. If it doesn't open notepad.exe.

When I rearrange the if fileexists command like below I receive this error... "C:\Program Files (x86)\AutoIt3\Include\File.au3 (47) : ==> "If" statement has no matching "EndIf" statement.:"

expandcollapse popup

if FileExists ("H:\documents\wordq\*.wdq") then
   MsgBox (4096, ".WDQ", "Exist")
 
  
#Include <File.au3>
#Include <Array.au3>
#include <GUIConstantsEx.au3>
#include <GUIComboBox.au3>
#include <Process.au3>
$dst = "h:\documents\wordq\" ;specify folder
$a_FileList = _FileListToArray2()
_ArraySort($a_FileList, 1, 1, $a_FileList[0][0], 1)
ShellExecute($a_FileList[1][0])
Func _FileListToArray2($s_Mask='*')
$h_Search = FileFindFirstFile($dst & '\' & $s_Mask)
$s_FileName = FileFindNextFile($h_Search)
If Not @error Then
   Dim $a_File[100][2]
   dim $sExt
   While Not @error
  
   $sExt = stringright($s_Filename, 4)
    if ($sext = ".wdq") then
    MsgBox(4096, "Extension", $sExt)
   
  
       if StringInStr($s_FileName,'.',0,-1) Then
           $s_FullName = $dst & '\' & $s_FileName
       
       
           $a_File[0][0] += 1
           If $a_File[0][0] >= UBound($a_File) Then
               ReDim $a_File[$a_File[0][0] * 2][2]
           EndIf
           $a_File[$a_File[0][0]][0] = FileGetLongName($s_FullName)
           $a_File[$a_File[0][0]][1] = FileGetTime($s_FullName,0,1)
  EndIf
  EndIf 
       $s_FileName = FileFindNextFile($h_Search)
   WEnd
   ReDim $a_File[$a_File[0][0] + 1][2]
   Return $a_File
 
EndIf
EndFunc
  Else
   ShellExecute ("notepad.exe")
endif

Thanks to anyone who can offer some advice.

Edited December 18, 2013 by Melba23
Added code tags

[Melba23]

mcintoow,

Welcome to the AutoIt forum.

But please pay attention to where you post - the "Developer Chat" section where you started this thread is not for general support questions. I have moved the thread for you, but would ask you to be more careful in future.

And when you post code please use Code tags - see here how to do it. Then you get a scrolling box and syntax colouring as you can see above now I have added the tags.

M23

[JLogan3o13]

Look at your last few lines of code. You have an EndFunc, then an Else with no If statement.

[markyrocks]

Your if statements are kinda big just use it like this. If <equation> then

<command>

Endif

Short and sweet

You have ifs and Endif all over the place

Edited December 18, 2013 by markyrocks

[MilesAhead]

Your if statements are kinda big just use it like this. If <equation> then

<command>

Endif

Short and sweet

You have ifs and Endif all over the place

 

+1  it's a good idea to use Tidy as you go along.  The indentation makes it obvious when the block starts and ends are unbalanced.

[Exit]

It is not explicitly written in the help file, but function definitions may not be inside of

Do ... until

IF ... endif

for ... next

switch ... Endswitch

Select ... Endselect

while .. wend

with ... Endwith 

constructs.

Edited December 19, 2013 by Exit

[BrewManNH]

Very good point Exit.

[markyrocks]

ok so i got home looked the op code over.... i'd guess it needs a lil work. i think you should rethink how your using arrays. most arrays we'll say dim $array once its in a loop it looks like this $x = 1 .... $array[$x] once something added to that slot in the array then $x += 1 to move array to next slot. Before that happens tho if its possible to exceed the original array size then you make statement like If $x >= ubound($array) then redim $array[$x + 2] or whatever you see fit for this portion. I made some notes in your code and changed a lil bit. I didn't mess with much because I'm not exactly 100% sure what your trying to accomplish but check it out. Ask more questions study the help file

expandcollapse popup

#Include <File.au3>
#Include <Array.au3>
#include <GUIConstantsEx.au3>
#include <GUIComboBox.au3>
#include <Process.au3>


if FileExists ("H:\documents\wordq\*.wdq") then
   MsgBox (4096, ".WDQ", "Exist")
   Else
   ShellExecute ("notepad.exe")
endif





$dst = "h:\documents\wordq\" 
$a_FileList = _FileListToArray2()    ;this is very confusing using a prexisting function name plus a 2......
_ArraySort($a_FileList, 1, 1, $a_FileList[0][0], 1)     
ShellExecute($a_FileList[1][0])
Func _FileListToArray2($s_Mask='*')      ;this is called with no parameter  never seen a variable defined like this in a function param
$h_Search = FileFindFirstFile($dst & '\' & $s_Mask)
$s_FileName = FileFindNextFile($h_Search)
   Dim $a_File[100][2]
   dim $sExt
   While Not @error
  
   $sExt = stringright($s_Filename, 4)
    if ($sext = ".wdq") then
    MsgBox(4096, "Extension", $sExt)
   EndIf
  
       if StringInStr($s_FileName,'.',0,-1) Then
           $s_FullName = $dst & '\' & $s_FileName
       EndIf
       
           $a_File[0][0] += 1    ;all this does is add 1 to a_file[0][0]  does not make it a_file[1][0] or a_file[0][1]
           If $a_File[0][0] >= UBound($a_File) Then    ;this is kindof an odd statement here as well
               ReDim $a_File[$a_File[0][0] * 2][2]    ;this is a mess
           EndIf
           $a_File[$a_File[0][0]][0] = FileGetLongName($s_FullName)   ;this is overyly complicated for no reason
           $a_File[$a_File[0][0]][1] = FileGetTime($s_FullName,0,1)    ;same with this

       $s_FileName = FileFindNextFile($h_Search)
   WEnd
   ReDim $a_File[$a_File[0][0] + 1][2]   ;how many times you gona redim this?
   Return $a_File    ;wheres it returning to?
 
EndFunc

Edited December 19, 2013 by markyrocks

[jchd]

It is not explicitly written in the help file, but function definitions may not be inside of

Do ... until

IF ... endif

for ... next

switch ... Endswitch

Select ... Endselect

while .. wend

with ... Endwith 

constructs.

True for all but With ... EndWith which are not true block construct last time I checked. They behave like individual instructions except of course that EndWith must have been preceeded by some With.

EDIT: the reality is always more subtle.

Edited December 19, 2013 by jchd

[Exit]

True for all but With ... EndWith which are not block construct last time I checked. They behave like individual instructions except of course that EndWith must have been preceeded by some With.

Real sorry to disagree. Just try this little snippets.

#include <IE.au3>
$oIE = _IECreate()
With $oIE
    ConsoleWrite("Browser name is " & .name & @LF)
    ConsoleWrite("Browser locationname is " & .locationname & @LF)
EndWith
_IEQuit($oIE)

#include <IE.au3>
$oIE = _IECreate()
With $oIE
    ConsoleWrite("Browser name is " & .name & @LF)
    Func _MyFunc()
    EndFunc   ;==>_MyFunc
    ConsoleWrite("Browser locationname is " & .locationname & @LF)
EndWith
_IEQuit($oIE)

[jchd]

I stand corrected. It used to work that way but changed in the meantime. Note that only Au3Check barks at your second example, which otherwise behaves just like the first when run.