Is there a faster way?

[Guest]

Following script does exactly what I want to do.
There is no need to explain .. Only use it or read it and you will understand.

(I'm better with Autoit language than with the English language...)

expandcollapse popup

#include <Array.au3>

$ScriptFile = "script.au3" ; < ===========      Insert here any script path ..




$Final = Tool1($ScriptFile)
ConsoleWrite($Final&@CRLF)

Func Tool1($ScriptFile)
    Local $Output = "" , $a

    $mScript = FileRead($ScriptFile)
    $aScript = StringSplit($mScript,@CRLF,1)

    Do
        $a = $a+1
        If LineIsActive($aScript[$a]) Then
            _ArrayInsert($aScript,$a+1,'ConsoleWrite("[Tool1]   "&"'&$aScript[$a]&'"&@CRLF)')
            $aScript[0] = $aScript[0]+1
            $a = $a+1
            _ArrayDisplay($aScript,"Still processing...") ; this line is only to show you how long it takes.
        EndIf
    Until $a >= $aScript[0]

    _ArrayDisplay($aScript,"Stage 1 Completed")

    For $a = 1 To $aScript[0]
        $Output = $Output&$aScript[$a]
        If $a < $aScript[0] Then $Output = $Output&@CRLF
    Next

    Return $Output
EndFunc


; Test 1
;$Line = "xxxx;xx"
;If LineIsActive($Line) Then
;   ConsoleWrite("Active"&@CRLF)
;Else
;   ConsoleWrite("Not Active"&@CRLF)
;EndIf


Func LineIsActive($Line)
    Local $Output = False
    If Not StringIsSpace($Line) Then
        Local $var = StringSplit($Line,"",1)
        For $a = 1 To $var[0]
            If Not StringIsSpace($var[$a]) Then
                If $var[$a] <> ";" Then
                    $Output = True
                EndIf
                ExitLoop
            EndIf
        Next
    EndIf
    Return $Output
EndFunc

the problem is that the script do the job very very slow...

what can i do to make is faster?

thanks for helpers!

Edited December 25, 2013 by Guest

[BrewManNH]

_ArrayInsert is a very time consuming task if you're adding a lot of lines to the array, perhaps you should look at the thread I posted in Example Scripts for a faster arrayadd function. It really only works with strings, but seeing as how that's what you're doing it might work better for you.

[Guest]

_ArrayInsert is a very time consuming task if you're adding a lot of lines to the array, perhaps you should look at the thread I posted in Example Scripts for a faster arrayadd function. It really only works with strings, but seeing as how that's what you're doing it might work better for you.

 

Thank you.

But I thought about a better way ..

There is no need to use _ArrayInsert or _ArrayAdd

this is the new code:

expandcollapse popup

;#include <Array.au3>

$ScriptFile = "Script.au3" ; < ===========      Insert here any script path ..




$Final = Tool1($ScriptFile)
ConsoleWrite($Final&@CRLF)

Func Tool1($ScriptFile)
    Local $Output = "" ; , $a

    $mScript = FileRead($ScriptFile)
    $aScript = StringSplit($mScript,@CRLF,1)
    ;Do
    For $a = 1 To $aScript[0]
        ;$a = $a+1
        $Output = $Output&$aScript[$a]&@CRLF
        If LineIsActive($aScript[$a]) Then
            ;_ArrayInsert($aScript,$a+1,'ConsoleWrite("[Tool1]    "&"'&$aScript[$a]&'"&@CRLF)')
            $Output = $Output&'ConsoleWrite("[Tool1]    "&"'&$aScript[$a]&'"&@CRLF)'
            ;$aScript[0] = $aScript[0]+1
            ;$a = $a+1
            ;_ArrayDisplay($aScript,"Still processing...") ; this line is only to show you how long it takes.
            If $a < $aScript[0] Then $Output = $Output&@CRLF
        EndIf
    Next
    ;Until $a >= $aScript[0]

    ;_ArrayDisplay($aScript,"Stage 1 Completed")

    ;For $a = 1 To $aScript[0]
    ;    $Output = $Output&$aScript[$a]
    ;    If $a < $aScript[0] Then $Output = $Output&@CRLF
    ;Next

    Return $Output
EndFunc


; Test 1
;$Line = "xxxx;xx"
;If LineIsActive($Line) Then
;    ConsoleWrite("Active"&@CRLF)
;Else
;    ConsoleWrite("Not Active"&@CRLF)
;EndIf


Func LineIsActive($Line)
    Local $Output = False
    If Not StringIsSpace($Line) Then
        Local $var = StringSplit($Line,"",1)
        For $a = 1 To $var[0]
            If Not StringIsSpace($var[$a]) Then
                If $var[$a] <> ";" Then
                    $Output = True
                EndIf
                ExitLoop
            EndIf
        Next
    EndIf
    Return $Output
EndFunc

this is much faster ..

Edited December 25, 2013 by Guest

[Gianni]

(I'm better with Autoit language than with the English language...)

 

... you say?....  

what is the purpose of that script? 

[Guest]

... you say?....  

what is the purpose of that script? 

 

Try to get this result:

 

By a complex technique ...

Anyway, I decided there was no reason to do this because I found another solution.