binarymid unbelievable low speed

[Inververs]

Try to read binary file by byte, and found that binarymid function is impossibly slow. Function is so slow that quickly create byte structure and extract data from.
 

$file = @WindowsDir & '\notepad.exe'
$data = FileRead($file)
$blen = BinaryLen($data)
$timer = TimerInit()
For $i = 1 To $blen
$byte = BinaryMid($data,$i,1)
Next
ConsoleWrite(TimerDiff($timer) & @LF)
;~ >Exit code: 0 Time: 126.831

$timer = TimerInit()
$t = DllStructCreate('BYTE[' & $blen & ']')
DllStructSetData($t,1,$data)
For $i = 1 To $blen
$byte = DllStructGetData($t,1 ,$i)
Next
ConsoleWrite(TimerDiff($timer) & @LF)
;~ >Exit code: 0 Time: 1.832

Why is this happening, and can improve the function?

Edited February 15, 2014 by Inververs

[JohnOne]

Open the file in binary mode before reading and using binarymid, might help.

EDIT:

$file = @WindowsDir & '\notepad.exe'
$open = FileOpen($file, 16)
$data = FileRead($open)
$blen = BinaryLen($data)
$timer = TimerInit()
For $i = 1 To $blen
    $byte = BinaryMid($data, $i, 1)
Next
ConsoleWrite(TimerDiff($timer) & @LF)
;~ >Exit code: 0 Time: 126.831

$timer = TimerInit()
$t = DllStructCreate('BYTE[' & $blen & ']')
DllStructSetData($t, 1, $data)
For $i = 1 To $blen
    $byte = DllStructGetData($t, 1, $i)
Next
ConsoleWrite(TimerDiff($timer) & @LF)

Edited February 15, 2014 by JohnOne

[Inververs]

and? binarymid still  26 times slower...

[jchd]

And your problem is?

[Inververs]

may be it is a bug, and developers do not know

[JohnOne]

and? binarymid still  26 times slower...

Your code...

55487.0253369946

303.60150751771

 

Altered code...

3352.9342803968

332.132003964863

[Gianni]

try this modifications (use FileRead from file instead of BinaryMid)

$file = @WindowsDir & '\notepad.exe'
$data = FileRead($file)
$myfile = FileOpen($file, 16) ; open file in binary mode
FileSetPos($myfile, 0, 2) ; position "cursor" to last byte in file
$blen = FileGetPos($myfile) ; read actual "cursor" position (last byte in this case)
; $blen = BinaryLen($data)

$timer = TimerInit()
FileSetPos($myfile, 0, 0) ; position "cursor" to first byte in file
For $i = 1 To $blen
    ; $byte = BinaryMid($data,$i,1)
    $byte = FileRead($myfile, 1) ; read 1 byte and autoincrement position
Next
ConsoleWrite(TimerDiff($timer) & @LF)


$timer = TimerInit()
$t = DllStructCreate('BYTE[' & $blen & ']')
DllStructSetData($t, 1, $data)
For $i = 1 To $blen
    $byte = DllStructGetData($t, 1, $i)
Next
ConsoleWrite(TimerDiff($timer) & @LF)

Edited February 15, 2014 by PincoPanco

[Inververs]

Thanks, PincoPanco, code really fast. But I did not need help, this topic was moved here moderators, unnecessarily I originally created itin the section Developer Chat. I just want that AutoIt got better. And maybe developers could improve the function binarymid.

[Gianni]

opss....   sorry.

Edited February 15, 2014 by PincoPanco

[Melba23]

Inververs,

If you wanted the thread to remain in Dev Chat then you should have make that clear in the OP. Just posting it as you did makes it look like a request for help in speeding up the code - which is exactly what everyone else who has seen it since it was move also thought.

If you want to bring a problem to the attention of the developers, open a Trac ticket.

M23

[Inververs]

Thank you. Next time I'll put it more correctly