variable not declared?

[13lack13lade]

Hey guys,

not sure what im doing wrong but im getting a variable $type = _ExcelReadCell($oExcel, ^ error

expandcollapse popup

#include <Excel.au3>
#include <ff.au3>

_FFConnect()
    ; open a page
    $oExcel = _ExcelBookOpen("Q:\Documents\Load Support\Tom\Projects\Current\longlats.xlsx")

    $type = _ExcelReadCell($oExcel, $i, 1)
    $city = _ExcelReadCell($oExcel, $i, 2)
    $supp = _ExcelReadCell($oExcel, $i, 3)
    $long = _ExcelReadCell($oExcel, $i, 4)
    $lati = _ExcelReadCell($oExcel, $i, 5)
    
    sleep(5000)
For $i = 1 To 4887 ;Loop
_FFOpenURL("https://www.calypso.net.au/apps/cpl/72.5/fcl/cpl.do#HdcPropertyEditPlace:" & $type & "/" & $city & "/" & $supp)
;script
sleep(5000)
send("^f")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("location")
sleep(1000)
highlightclick()
sleep(1000)
send("^f")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("edit")
sleep(1000)
highlightclick()
sleep(3000)
MouseClick ( "left" [, 928, 674 [, clicks = 1 [, speed = 10]]] )
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send($lati);latitude
MouseClick ( "left" [, 1127, 675 [, clicks = 1 [, speed = 10]]] )
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send($long);longitude
send("^f")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("{BS}")
send("save")
highlightclick()
next

[water]

What's the value of $i when you call _ExcelReadCell?

[13lack13lade]

i just want it to read rows 1-4887 on a loop..

For $i = 1 To 4887 ;Loop

Edited February 18, 2014 by 13lack13lade

[water]

What is the value of $i when executing this line?

$type = _ExcelReadCell($oExcel, $i, 1)

[13lack13lade]

will start at 1 then loop through to 4887 thats why i have the for $i = 1 to 4887 or is that not right:?

EDIT: never mind i see what you mean, gotta include it in the loop! lol cheers water!

Edited February 18, 2014 by 13lack13lade

[water]

Fine

If reading 5000 rows is too slow I suggest to have a look at my rewrite of the Excel UDF. Is about 20 to 50 times faster when reading an array of cells.

[BrewManNH]

This line is written completely wrong.

MouseClick ( "left" [, 928, 674 [, clicks = 1 [, speed = 10]]] )

It needs to be written like this.

MouseClick ( "left" , 928, 674 , 1 , 10)

[13lack13lade]

 

This line is written completely wrong.

MouseClick ( "left" [, 928, 674 [, clicks = 1 [, speed = 10]]] )

It needs to be written like this.

MouseClick ( "left" , 928, 674 , 1 , 10)

just figure that out too lol.. feel like an idiot for making rookie mistakes:/ lol  thanks guys