ProcessClose() usage

[nitekram]

I am having trouble getting ProcessClose() to report anything but 0 (ZERO), and the @error = 0 (Zero0 too. It might just be my logic - being wrong again.

Here is my code that never outputs either msgbox:

If $PID Then
     If ProcessClose($PID)Then
    MsgBox($cONTOP,'','The process has ended.')
     Else
    MsgBox($cONTOP, 'ERROR', 'ERROR = ' & $iError _
     & @CRLF & '1 = OpenProcess failed' _
     & @CRLF & '2 = AdjustTokenPrivileges Failed' _
     & @CRLF & '3 = TerminateProcess Failed' _
     & @CRLF & '4 = Cannot verify if process exists')
    MsgBox($cONTOP,'ERROR ' & ProcessClose($PID), @error)
     EndIf
EndIf

The helpfile does not have the @error message as part of the example. I have come across this before, and I have had issues with using the @error macro before - as you have to grab the value, before you use another command. So maybe it has nothing to do with ProcessClose, but instead my not understanding how to use @error correctly.

Thanks for anyone's help.

[nitekram]

TTT

[guinness]

I don't see what your issue is. $PID should be non-zero for the first If statement to be executed and then if ProcessClose() returns 0 the first message box is show and @error is reset, so the second message box will display 0. This isn't a bug, just misunderstanding in logic.

[guinness]

#include <MsgBoxConstants.au3>

Local $PID = Run("notepad.exe")
If $PID Then
    If ProcessClose($PID) Then
        MsgBox($MB_SYSTEMMODAL, '', 'The process has ended.')
    Else
        Local $iError = @error
        MsgBox($MB_SYSTEMMODAL, 'ERROR', 'ERROR = ' & $iError _
                 & @CRLF & '1 = OpenProcess failed' _
                 & @CRLF & '2 = AdjustTokenPrivileges Failed' _
                 & @CRLF & '3 = TerminateProcess Failed' _
                 & @CRLF & '4 = Cannot verify if process exists')
        Local $iReturn = ProcessClose($PID)
        MsgBox($MB_SYSTEMMODAL, 'ERROR ' & $iReturn, @error)
    EndIf
EndIf

[nitekram]

I knew it was me...thanks again.

[guinness]

So you understand @error gets reset at every function call?!

[nitekram]

I understand that it changes...I have to grab that value, before the next function call. And in your example you show that the second call to ProcessCall() would be the same error value as the first one. And I did think that about the @error macro...and now I have it an example.

Next up - SetError()

I do thank you again for your help.

[guinness]

Next up - SetError()

This is pretty necessary for good coding.

[nitekram]

Normally I just return either a 1 or 0, depending on if the function I created - is there an advantage to using the SetError()?

[czardas]

1 or 0 will be a valid return value in many situations. Another advantage is consistancy in coding.

Edited February 22, 2014 by czardas