usera Posted March 14, 2014 Share Posted March 14, 2014 Greeting, anyone can help me what is wrong? I can not create this shortcut. $Sourcea="C:\Windows\System32\" $Sourceb="control.exe" $source1=$sourcea & $sourceb $Descripta="" & "Action Center" &" ShortCut.lnk" $Target=@DesktopDir $Target1=$target & $Descripta FileCreateShortcut($Source1, $Target1 & "," & "C:\Windows\System32\" & "," & "/name Microsoft.actioncenter") thanks Link to comment Share on other sites More sharing options...
BrewManNH Posted March 14, 2014 Share Posted March 14, 2014 Your problem is that you're putting quotes around the commas and concatenating the whole string so it's seen as 2 long strings. $Source1 is the first parameter you're passing to the function and "$Target1 & "," & "C:\Windows\System32\" & "," & "/name Microsoft.actioncenter")" is the second parameter you're passing. If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
Moderators JLogan3o13 Posted March 14, 2014 Moderators Share Posted March 14, 2014 (edited) Take a look at this to see where you've formatted your call badly: $source = @SystemDir & "\control.exe" $Target=@DesktopDir & "\MyShortcut.lnk" FileCreateShortcut($source, $Target, @SystemDir, "/name Microsoft.actioncenter") If @error Then MsgBox(0, "", @error) Edit: Too slow Edited March 14, 2014 by JLogan3o13 "Profanity is the last vestige of the feeble mind. For the man who cannot express himself forcibly through intellect must do so through shock and awe" - Spencer W. Kimball How to get your question answered on this forum! Link to comment Share on other sites More sharing options...
usera Posted March 14, 2014 Author Share Posted March 14, 2014 Your problem is that you're putting quotes around the commas and concatenating the whole string so it's seen as 2 long strings. $Source1 is the first parameter you're passing to the function and "$Target1 & "," & "C:\Windows\System32\" & "," & "/name Microsoft.actioncenter")" is the second parameter you're passing. Sorry, ???? can you just post the correct code here? how "$Target1 & "," & "C:\Windows\System32\" & "," & "/name Microsoft.actioncenter")" works? I mean ")" thanks Link to comment Share on other sites More sharing options...
BrewManNH Posted March 14, 2014 Share Posted March 14, 2014 Look UP one post for the solution, I would have told you to figure it out on your own as you'd have learned more by it. If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
usera Posted March 14, 2014 Author Share Posted March 14, 2014 Look UP one post for the solution, I would have told you to figure it out on your own as you'd have learned more by it. pardon?! Link to comment Share on other sites More sharing options...
Moderators JLogan3o13 Posted March 14, 2014 Moderators Share Posted March 14, 2014 What can I say, we're all in a generous mood sometimes "Profanity is the last vestige of the feeble mind. For the man who cannot express himself forcibly through intellect must do so through shock and awe" - Spencer W. Kimball How to get your question answered on this forum! Link to comment Share on other sites More sharing options...
Moderators JLogan3o13 Posted March 14, 2014 Moderators Share Posted March 14, 2014 (edited) usera. Post Number 3 has your answer. Compare it to what you wrote to see what you did wrong. Edited March 14, 2014 by JLogan3o13 "Profanity is the last vestige of the feeble mind. For the man who cannot express himself forcibly through intellect must do so through shock and awe" - Spencer W. Kimball How to get your question answered on this forum! Link to comment Share on other sites More sharing options...
usera Posted March 14, 2014 Author Share Posted March 14, 2014 Take a look at this to see where you've formatted your call badly: $source = @SystemDir & "\control.exe" $Target=@DesktopDir & "\MyShortcut.lnk" FileCreateShortcut($source, $Target, @SystemDir, "/name Microsoft.actioncenter") If @error Then MsgBox(0, "", @error) Edit: Too slow thanks, I did add If @error Then MsgBox(0, "", @error) in the end of my code. no error Link to comment Share on other sites More sharing options...
Moderators Solution JLogan3o13 Posted March 14, 2014 Moderators Solution Share Posted March 14, 2014 Look at the FileCreateShortcut line. Compare to what you wrote. usera 1 "Profanity is the last vestige of the feeble mind. For the man who cannot express himself forcibly through intellect must do so through shock and awe" - Spencer W. Kimball How to get your question answered on this forum! Link to comment Share on other sites More sharing options...
usera Posted March 14, 2014 Author Share Posted March 14, 2014 usera. Post Numer 3 has your answer. Compare it to what you wrote to see what you did wrong. Thanks, got it Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now