Problem with [Do] loop

[yousefsamy]

Here is my code, i don't know why isn't it working :

Do
    $search = PixelSearch(0,0,1023,767,0x0018C6)
    If $search = @error  Then Sleep(100)
Until $search = Not @error
MouseMove($search[0],$search[1],20)

[JLogan3o13]

Explain "isn't working".Is it throwing an error, is it not moving the mouse, is the script ending prematurely, what?

[yousefsamy]

here is my Code , But i don't know why isn't it working :

Do
    $search = PixelSearch(0,0,1023,767,0x0018C6)
    If $search = @error  Then Sleep(100)
Until $search = Not @error
MouseMove($search[0],$search[1],20)

[mLipok]

1.

sugestion:

Until Not ($search = @error)

2.

question:

how you think in the following line

Until $search = Not @error

@error is returned from which function ?

[Melba23]

yousefsamy,

Just one thread at a time please - merged.

M23

[mLipok]

 

Here is my code, i don't know why isn't it working :

Do
    $search = PixelSearch(0,0,1023,767,0x0018C6)
    If $search = @error  Then Sleep(100)
Until $search = Not @error
MouseMove($search[0],$search[1],20)

after reading HelpFile I can guess: line 3 and 4 never happend

EDIT

line 3 never happend

and

line 4 always is true so the resutl is Exitloop

Edited July 16, 2014 by mLipok

[yousefsamy]

Melba23

 

sorry for that i have a bad connection

[yousefsamy]

JLogan3o13

mouse didn't move 

[yousefsamy]

mLipok

but the loop ends itself when don't find the pixel ?

should do loop running until find the pixel ?

[Shane0000]

Dim $aSearch[0]
Do
    $aSearch = PixelSearch(0,0,1023,767,0x0018C6)
    If Not IsArray($search) Then Sleep(100)
Until IsArray($aSearch)
MouseMove($aSearch[0],$aSearch[1],20)

If PixelSearch succeeds it returns an Array so you can try the above

If an error occurs $error is set to 1 so you could also do:

Dim $aSearch[0]
Do
    $aSearch = PixelSearch(0,0,1023,767,0x0018C6)
    If @error Then Sleep(100)
Until Not @Error
MouseMove($aSearch[0],$aSearch[1],20)

if 'Not @error' doesnt work try 'Until @error < 1'

[Melba23]

yousefsamy,

No problem - it happens to us all.

But - and I am getting really tired of asking you this same question over and over again - have you even looked at the Help file example for the function you are trying to use?

I think not, because the examples for _PixelSearch show exactly how to check for @error - and your code is nothing like it. What makes you think the return value should be the same as the @error macro? Go and look at the Help file example and try again.

M23

[jdelaney]

 

If an error occurs $error is set to 1 so you could also do:

Dim $aSearch[0]
Do
    $aSearch = PixelSearch(0,0,1023,767,0x0018C6)
    If @error Then Sleep(100)
Until Not @Error
MouseMove($aSearch[0],$aSearch[1],20)

if 'Not @error' doesnt work try 'Until @error < 1'

 

The sleep call will set @error = 0, so you will exit the loop unintentionally...do something like this:

Local $aSearch
Do
    $aSearch = PixelSearch(0,0,1023,767,0x0018C6)
    If @error Then Sleep(100)
Until IsArray($aSearch)
MouseMove($aSearch[0],$aSearch[1],20)

[jdelaney]

Like your first option, but with a correction.  You can't declare an array with 0 subscripts, syntactically.

[Melba23]

jdelaney,

 

You can't declare an array with 0 subscripts, syntactically

Do you mean that you cannot do this?

Dim $aSearch[0]

It is perfectly valid syntax - AutoIt has been able to use empty arrays since last summer, I remember rewriting the Array UDF to cope with them.

M23

[Shane0000]

Well , I shouldnt have made an empty array if I was doing an IsArray check also  soo ... :/ I didnt run any of the code, just shootin from the hip

[jdelaney]

The empty array doesn't matter, since it's checked at the end of the loop, and the function will set it to a non array if it fails.

Cool.  I'm still on the old version, where the array needs 1 subscript or more.

Edited July 16, 2014 by jdelaney

[yousefsamy]

where is the problem ,, i read the help file , but i do that with imagesearch() func ,, it works:

Local $aSearch

Do
    $aSearch = PixelSearch(0,0,1023,767,0x0018C6)
    If $aSearch = 1 Then Sleep(100)
Until $aSearch <> 1
MouseMove($aSearch[0],$aSearch[1],20)

[jdelaney]

PixelSearch will never return 1...it will return 0, if it doesn't find your pixel...stick with my example:

Local $aSearch
Do
    $aSearch = PixelSearch(0,0,1023,767,0x0018C6)
    If @error Then Sleep(100)
Until IsArray($aSearch)
MouseMove($aSearch[0],$aSearch[1],20)

Or, you can do this:

Local $aSearch, $something
Do
    $aSearch = PixelSearch(0,0,1023,767,0x0018C6)
    $something = @error
    If $something Then Sleep(100)
Until Not $something
MouseMove($aSearch[0],$aSearch[1],20)

Edited July 16, 2014 by jdelaney

[Shane0000]

Return Values:
Success: a two-element array of pixel's coordinates. (Array[0] = x, Array[1] = y). 

Failure: sets the @error flag to 1 if the color is not found.

A failed PixelSearch will not set your variable($aSearch) to 1 it sets @error

@error = 1 on a failed PixelSearch

 

The only instance that $aSearch will be assigned a value is if your pixel is found.

Edited July 16, 2014 by Shane0000

[yousefsamy]

jdelaney

why did you write this line ?

Local $aSearch, $something

and why if i type @error without put it in a variable didn't work ?

Edited July 17, 2014 by yousefsamy