Do loop ending itself and the GUI

[t1ck3ts]

I have a function in my GUI that runs on start

Func MDBList()
    Local $MDBFiles = _FileListToArray(@ScriptDir, "*.mdb", $FLTA_FILES)
    Local $i = 1
Do
    Sleep(1000)
    GUICtrlSetData($Log," - " & $MDBFiles[$i] & @CRLF,1)
    $i = $i + 1
Until $i = $MDBFiles[0 + 1]
EndFunc

While 1
    Switch GUIGetMsg()
        Case $GUI_EVENT_CLOSE
            ExitLoop
    EndSwitch
WEnd

but when it ends, it also ends the GUI, which is not what i want

From reading Melba23's post in the Wiki (http://www.autoitscript.com/wiki/Interrupting_a_running_function), I think im using a GUI in MessageLoop mode but im not 100% sure how to go about it as it uses buttons being pressed and i have my code run at start up.

Any way around this?

EDIT:

It seems to be _FileListToArray is the culprit, a simple Do loop works perfectly.

After throwing in some error checking, i get this

: ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:
GUICtrlSetData($Log," - " & $MDBFiles[$i] & @CRLF,1)
GUICtrlSetData($Log," - " & ^ ERROR

From what i can tell, its because i did

Until $i = $MDBFiles[0 + 1]

But i dont know how i would make it display all *.mdb files, [0] is the ammount of files it found $i = 1 is to read the first file in the list.

EDIT #2:

Why is it when ever i ask a question on the forums, it makes me realise where my mistake was /facepalm

 

Func MDBList()
    Local $MDBFiles = _FileListToArray(@ScriptDir, "*.mdb", $FLTA_FILES)
    Local $i = 0
Do
    Sleep(1000)
    $i = $i + 1
    GUICtrlSetData($Log," - " & $MDBFiles[$i] & @CRLF,1)
Until $i = $MDBFiles[0]
EndFunc

Is the working code

Edited July 17, 2014 by t1ck3ts

[Melba23]

t1ck3ts,

You are using MessageLoop mode - or I should say you are using GUIGetMsg which normally means that you are.

You have a major flaw in the code which will probably crash the script - that would close your GUI:

Until $i = $MDBFiles[0 + 1]

Do you really want to wait until $I is the same as the first returned filename - because it will never happen and you will try to read a non-existent array element and crash.

The line should read:

Until $i = $MDBFiles[0]

But why use a Do loop anyway:

For $I = 1 To $MBBFiles[0]
    Sleep(1000)
    GUICtrlSetData($Log," - " & $MDBFiles[$i] & @CRLF,1)
Next

No messy counts then. But I would recommend a check that you actually have an array before trying to access it.

M23

[t1ck3ts]

hahaha, thanks Melba23

It always happens to me when i post something on the forums, take a look at my post, and then realise, "God damn it! you're an idiot!"

Everything you said, is exactly what i changed And after taking ANOTHER look at your wiki post, i actually used a a For loop as you
have just said So much more simpler too!

For $I = 1 To $MBBFiles[0]
Sleep(1000)
GUICtrlSetData($Log," - " & $MDBFiles[$i] & @CRLF,1)
Next

I dont have an array for $MBBFiles but i do for $MDBFiles

Heheh, thanks again!

Edited July 17, 2014 by t1ck3ts