Function to compare arrays

[dromenox]

What's wrong on my function to compare two arrays?

Func _ArrayIsEqual($array1, $array2)

   If Not IsArray($array1) Then Return False
   If Not IsArray($array2) Then Return False

   $iSizeA = UBound($array1)
   $iSizeB = UBound($array2)

   If $iSizeA = $iSizeB Then
      For $i = 0 To $iSizeA - 1 Step 1
         If $array1[$i] <> $array2[$i] Then Return False
      Next
   Else
      Return False
   EndIf
   Return True

EndFunc

Sometimes this error happens: 


Array variable has incorrect number of subscripts or subscript dimension range exceeded .:

I do not know if the error is in the function or where I am using this function, but I did a check on the function not to have problems.

Edited September 30, 2014 by dromenox

[MikahS]

Remember that the value returned by UBound() is one greater than the index of an array's last element.

[dromenox]

Remember that the value returned by UBound() is one greater than the index of an array's last element.

 For $i = 0 To $iSizeA - 1 Step 1

Edited September 30, 2014 by dromenox

[MikahS]

 

 

My apologies, but this line will fail if they are not the same and throw that error

If $array1[$i] <> $array2[$i] Then Return False

[dromenox]

 

My apologies, but this line will fail if they are not the same and throw that error

If $array1[$i] <> $array2[$i] Then Return False

If they are not the same: 

If $iSizeA = $iSizeB Then

[MikahS]

 

If they are not the same: 

If $iSizeA = $iSizeB Then

Then you have not provided enough information for us, please give the full error, as the error message will give the line number.

Edited September 30, 2014 by MikahS

[Melba23]

dromenox,

An obvious missing check is that the 2 arrays are both 1D - if you try to read an element of a 2D array with 1D syntax you get the "incorrect number of subscripts " error. So first off I would add a couple of further lines to check the number of dimensions and the size of an eventual second one:

If UBound($array1, 0) <> UBound($array2, 0) Then Return False ; Not both 1D/2D
If UBound($array1, 2) <> UBound($array2, 2) Then Return False ; Not the same size in 2nd dimention (1D arrays return 0)

Then when you check the contents you will need to have separate checks for 1D and 2D arrays - you need different syntax for each as I explained above.

M23