FileInstall in an If Then statement?

[tk1]

Hello,

This might be more of a best practice question than a functional one.

If I put two FileInstall statements inside an If Then, will both files still be included at compile time?

For example:

Global $sBitness = $sBase_x32
Global $sInstaller64 = "Installer-v5.12-x64.msi"
Global $sInstaller32 = "Installer-v5.12-x86.msi"

;Set bitness of OS and get external file necessary for the install file, to be included when the script is compiled.
If Not @OSArch = "X86" Then
    $sBitness = $sBase_x64
    FileInstall("C:\Installer\" & $sInstaller64, @TempDir & "\" & $sInstaller64, 1)
Else
    FileInstall("C:\Installer\" & $sInstaller32, @TempDir & "\" & $sInstaller32, 1)
EndIf

Thanks in advance,

tk1

[BrewManNH]

Yes

[tk1]

Thank you for the quick reply, BrewManNH!

[Exit]

If I put two FileInstall statements inside an If Then, will both files still be included at compile time?

 

No

Fileinstall() will fail with message Invalid FileInstall() function during compile.

Helpfile says:

The source path of the file to compile. This must be a literal string; it cannot be a variable or the result of a function call.

Here a working code

FileInstall("C:\Installer\Installer-v5.12-x64.msi", @TempDir & "\Installer-v5.12-x64.msi", 1)
FileInstall("C:\Installer\Installer-v5.12-x86.msi", @TempDir & "\Installer-v5.12-x86.msi", 1)
ShellExecute(@TempDir & "\Installer-v5.12-" & @OSArch & ".msi")

Edited November 7, 2014 by Exit

[BrewManNH]

Exit is correct, I missed the fact you're using a variable in the FileInstall function. But if properly written, both files will be installed.

I really need to proofread what's posted better.

[tk1]

Yes, and it seemed to work in my testing, but not in practice.  As stated many places here, the source cannot have a variable so I changed it to be explicit and now that works.   DOH!  

Edited November 11, 2014 by tk1