global variable or function?

[pcjunki]

I'm redesigning one of my gui's , it has allot of buttons

I took a hard look, and saw that I have duplicate code that sets fonts and what not

I'd like to create a global variable, or would it be a function?

I'm trying to set properties for the cursor, font, and resizing of the gui button

btw, this is my first time using global variables, but I have an idea of what they are

$Form1 = GUICreate("PC TOOLS V2", 1001, 724, 147, 131, BitOR($GUI_SS_DEFAULT_GUI, $WS_MAXIMIZEBOX, $WS_SIZEBOX, $WS_THICKFRAME, $WS_TABSTOP, $WS_HSCROLL, $WS_VSCROLL))
$Tab1 = GUICtrlCreateTab(8, 8, 1257, 985)


Global $cursor = "GUICtrlSetCursor(-1, 0)"
Global $font = "GGUICtrlSetFont(-1, 14, 400, 0, "MS Sans Serif")"
Global $resize = "GUICtrlSetResizing ( -1, 1)"



$TabSheet1 = GUICtrlCreateTabItem("WOL")

$Button1 = GUICtrlCreateButton("1stFloor", 24, 56, 179, 153)
$cursor
$font
$resize






GUICtrlCreateTabItem("")
GUISetState(@SW_SHOW)


While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit

    EndSwitch
WEnd

[guinness]

All that code can be in a function and the variables declared as Local. I would also recommend using ExitLoop and then GUIDelete() at the end to tidy resources (even though AutoIt does this for you automagically!)

[MikahS]

I'm feeling generous

#include <GUIConstants.au3>
 
Global $Form1, $Tab1, $Button1

GUI()

While 1
    $msg = GUIGetMsg()
    Switch $msg
       Case $GUI_EVENT_CLOSE
          Exit
       Case $Button1
          ; do something here
    EndSwitch
WEnd

Func GUI()
    $Form1 = GUICreate("PC TOOLS V2", 1001, 724, 147, 131, BitOR($GUI_SS_DEFAULT_GUI, $WS_MAXIMIZEBOX, $WS_SIZEBOX, $WS_THICKFRAME, $WS_TABSTOP, $WS_HSCROLL, $WS_VSCROLL))
    $Tab1 = GUICtrlCreateTab(8, 8, 1257, 985)
    Local $TabSheet1 = GUICtrlCreateTabItem("WOL")
    $Button1 = GUICtrlCreateButton("1stFloor", 24, 56, 179, 153)
    Local $cursor = GUICtrlSetCursor(-1, 0)
    Local $font = GUICtrlSetFont($Button1, 14, 400, 0, "MS Sans Serif")
    Local $resize = GUICtrlSetResizing($Button1, 1)
EndFunc
 

Something like this?

EDIT:

The difference between local and global..

Local: means that it will only be in the scope of the script, if declared outside of a function, or if declared in a function can only be used in that function.

Global: Once declared can be used anywhere that is linked to that particular script that it has been declared by. If declared again in another script or function, the original will be overwritten.

Edited January 14, 2015 by MikahS

[pcjunki]

is this the start down the right path?

;~ global variable settings for gui buttons

Func buttonsettings()
Global $cursor = "GUICtrlSetCursor(-1, 0)"
Global $font = "GGUICtrlSetFont(-1, 14, 400, 0, 'MS Sans Serif')"
Global $resize = "GUICtrlSetResizing ( -1, 1)"
EndFunc

[kylomas]

pcjunki,

I suppose you could do something like...

expandcollapse popup

; *** Start added by AutoIt3Wrapper ***
#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
; *** End added by AutoIt3Wrapper ***

#AutoIt3Wrapper_Add_Constants=n



$Form1 = GUICreate("PC TOOLS V2", 1001, 724, 147, 131, BitOR($GUI_SS_DEFAULT_GUI, $WS_MAXIMIZEBOX, $WS_SIZEBOX, $WS_THICKFRAME, $WS_TABSTOP, $WS_HSCROLL, $WS_VSCROLL))
$Tab1 = GUICtrlCreateTab(8, 8, 1257, 985)


Global $cursor = "GUICtrlSetCursor(-1, 0)"
Global $font = "GUICtrlSetFont(-1, 14, 400, 0, ""MS Sans Serif"")"
Global $resize = "GUICtrlSetResizing ( -1, 1)"



$TabSheet1 = GUICtrlCreateTabItem("WOL")

$Button1 = GUICtrlCreateButton("1stFloor", 24, 56, 179, 153)
execute($cursor)
execute($font)
execute($resize)






GUICtrlCreateTabItem("")
GUISetState(@SW_SHOW)


While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit

    EndSwitch
WEnd

but it is not saving alot and is far less readable.

kylomas

[pcjunki]

kylomas

that's exactly what I was looking for!

didn't know about the "Execute"

now if I want to change font size or what ever, I can just do it in one place

[kylomas]

Beware, your syntax better be dead nuts...you have a typo in the OP...

[pcjunki]

just found it, double g's

[JohnOne]

I code like this sometimes, when I'm bored.

Global $hGui = _Gui()
Global $ahButtons = _Buttons()

GUISetState()

While 3
    _MsgHandler(GUIGetMsg())
WEnd

Func _MsgHandler($msg)
    Switch $msg
        Case -3
            Exit
        Case $ahButtons[0]
            MsgBox(0, 0, "B1")
        Case $ahButtons[1]
            MsgBox(0, 0, "B2")
    EndSwitch
EndFunc

Func _Gui()
    Return GUICreate("GUI", 200, 200)
EndFunc   ;==>_Gui

Func _Buttons()
    Local $aB[2] = [GUICtrlCreateButton("B1", 10, 10), GUICtrlCreateButton("B2", 40, 10)]
    Return $aB
EndFunc   ;==>_Buttons

Edited January 15, 2015 by JohnOne

[BrewManNH]

Your definitions are incorrect in regards to AutoIt.

 

 

 

The difference between local and global..

Local: means that it will only be in the scope of the script, if declared outside of a function, or if declared in a function can only be used in that function.

Global: Once declared can be used anywhere that is linked to that particular script that it has been declared by. If declared again in another script or function, the original will be overwritten.

Local when declared in a function, and not using the Static keyword: the variable can only be seen by the script as long as it is running inside that function. After that function ends or is "Return"ed from, that variable no longer exists and can't be accessed.

Local  when declared outside of a function, and Global: Can be seen everywhere in the script, inside functions and out. It exists as long as the script runs. Variable names are not shared between running scripts.

[Guest]

Local when declared in a function, and not using the Static keyword: the variable can only be seen by the script as long as it is running inside that function. After that function ends or is "Return"ed from, that variable no longer exists and can't be accessed.

 

 

You can still change,Access, read, a local variable in a function from another function this way:

Example()

Func Example()
    Local $var = 1
    ConsoleWrite($var&@CRLF) ; This will print $var as 1 (The variable has not changed)
    ChangeVar($var)
    ConsoleWrite($var&@CRLF) ; This will print $var as 2 (The variable was changed in ChangeVar())
EndFunc


Func ChangeVar(ByRef $lVar)
    $lVar = 2
EndFunc

I guess that this knowledge will be useful for you.

Unfortunately I learned this only recently

Edited January 15, 2015 by Guest

[MikahS]

Your definitions are incorrect in regards to AutoIt.

 

 

Local when declared in a function, and not using the Static keyword: the variable can only be seen by the script as long as it is running inside that function. After that function ends or is "Return"ed from, that variable no longer exists and can't be accessed.

Local  when declared outside of a function, and Global: Can be seen everywhere in the script, inside functions and out. It exists as long as the script runs. Variable names are not shared between running scripts.

 

You can still change,Access, read, a local variable in a function from another function this way:

Example()

Func Example()
    Local $var = 1
    ConsoleWrite($var&@CRLF) ; This will print $var as 1 (The variable has not changed)
    ChangeVar($var)
    ConsoleWrite($var&@CRLF) ; This will print $var as 2 (The variable was changed in ChangeVar())
EndFunc


Func ChangeVar(ByRef $lVar)
    $lVar = 2
EndFunc

I guess that this knowledge will be useful for you.

Unfortunately I learned this only recently

 

Thank you both for correcting this for me, seems I needed it.

[Melba23]

MikahS,

The Variables - using Global, Local and ByRef tutorial in the Wiki might be worth a look.

M23

[MikahS]

The Variables - using Global, Local and ByRef tutorial in the Wiki might be worth a look.

 

Just FYI that is a deleted page.

EDIT: This is the page you mean

Thank you by the way, M23.

Edited January 15, 2015 by MikahS

[Melba23]

MikahS,

Oops! I have amended the link in my autoposting utility. :blush:

M23

[MikahS]

MikahS,

Oops! I have amended the link in my autoposting utility. :blush:

M23

 

Glad to help, and thanks for yours.

[guinness]

That whole Local in "Global" scope is a bug in my humble opinion, as functions should not be able to see it, due to it be local only to that scope. Then again I don't know why Var isn't used, because we tend not to declare Global variables inside functions (bad practice), thus it would force people to declare Global variables outside of functions, which is the only reason I can see for having Local and Global, to differentiate between when a variable in a function is actually Global and not the default Local.

Edited January 15, 2015 by guinness

[Guest]

Usually people create Global varibales to access them from other functions.

What I suggested in #11 is a way to achieve the goal without creating global variable.

So you're saving memory by reducing global variables and still achieve the goal.

Of course, this is not always correct to use this method. But I think that in many cases this is the correct way

[guinness]

What I suggested in #11 is a way to achieve the goal without creating global variable.

Yes, what you suggested is one approach, though I can think of a couple of more ways as well. Edited January 15, 2015 by guinness

[czardas]

That whole Local in "Global" scope is a bug in my humble opinion, as functions should not be able to see it, due to it be local only to that scope.

 

Surely this is similar to a hierarchical system with limited access to locals which are not elevated to global status. The design is by choice and doesn't seem to qualify as a bug in that sense. Saying 'local to the global scope' only makes sense if these variables share the same scope as all other variables declared globally regardless of syntax. ...My thoughts.

Edited January 15, 2015 by czardas