Cpu at 50%

[Jac]

Here is the code im running on my pc

 

I juste want to check if the program yyy.exe is running 

 

If not im killing program xxx.exe

 

It's alway running at 50% on my vm

 

Is it normal ? 

 

 

#Region ;**** Directives created by AutoIt3Wrapper_GUI ****

#AutoIt3Wrapper_Icon=..Program Files (x86)AutoIt3Iconsau3script_v10.ico

#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****

#cs ----------------------------------------------------------------------------

 

 AutoIt Version: 3.3.12.0

 Author:         myName

 

 Script Function:

Template AutoIt script.

 

#ce ----------------------------------------------------------------------------

 

; Script Start - Add your code below here

 

 

While 1

If Not ProcessExists("xxx.exe") Then

ProcessClose("yyy.exe")

MsgBox(0,"info","xxx Not Running.  Closing yyy")

Exit

Else

If Not ProcessExists("yyy.exe") Then Run("C:Program Files (x86)xxxxxx.exe","C:Program Files (x86)xxx")

EndIf

WEnd

Else

MsgBox($MB_ICONERROR, "", "Launch xxx")

 

EndIf

 

 

Thanks !

 

[JLogan3o13]

Add a short sleep, like 100ms, to keep your While loop from being so CPU intensive.

Edited February 11, 2015 by JLogan3o13

[caramen]

your code is breacking my head ... rly... i dont get the conditional position...

The Wend position is strange ..

it s like there is two way to get the else stat i rly dont get it ... lol

 

you even can do a while of 1 or 2 seconde ... sleep (1000) or (2000) as you usualy need to save memory and CPU on a VM

Edited February 11, 2015 by caramen

[kylomas]

Jac,

See my sig for how to post code.

Your code as posted generates the following when run through Au3Check...

>"C:Program Files (x86)AutoIt3SciTEtidytidy.exe" "C:UsersADMIN010Documentsbb.au3"
Tidy AutoIt3 v14.801.1932.0   Copyright © Jos van der Zande  August 01,2014
"C:UsersADMIN010Documentsbb.au3"(28) : ### Tidy Error: "else" is likely missing it's opening statement. next line creates a negative tablevel.
"C:UsersADMIN010Documentsbb.au3"(31) : ### Tidy Error: "endif" is likely missing it's opening statement. next line creates a negative tablevel.
!> there were  2 error(s) encountered. look in your source for:### Tidy Error:
+> Tidy AutoIt3 finished. Original copied to:"C:UsersADMIN010DocumentsBackUpbb_old3.au3"
>Exit code: 2    Time: 1.53

 

The code also seems illogical.  If XXX is running and YYY is not you will run instances of XXX continuously.  You also need a Sleep somewhere to idle the processor.

If you can define what you are trying to do maybe we can help.

kylomas

[SadBunny]

What your code does:

:begin

IF xxx.exe is not running,

THEN blindly close yyy.exe (which may or may not be running) and exit

ELSE (note: xxx.exe is running!): if yyy.exe is not running, then start xxx.exe

goto :begin

(and then here some unreachable code which is never executed)

In other words, as long as xxx.exe is running and yyy.exe is not running, start another instance of xxx.exe.

In yet other words: if yyy.exe is not running, you are starting addidional instances of xxx.exe as fast as your computer can handle. That must be why your CPU is boiling over. Check your task manager to confirm.

Still, it's hard to guess what you're actually aiming to accomplish with this script, and also it has unreachable code under the WEnd. Did you mean it to be active continuously or just to run it once? Please explain a bit more about the situation you're facing.

[kylomas]

 @SadBunny - nice paraphrase of my post (right above yours)...

Edited February 12, 2015 by kylomas

[SadBunny]

 @SadBunny - nice paraphrase of my post (right above yours)...

 

Ah, right... Missed the fact that you wrote a bunch of stuff under that quote 

[kylomas]

No worries, just poking fun.   I enjoy reading your concise explanations

[SadBunny]

No worries, just poking fun.   I enjoy reading your concise explanations

 

At work they call me Sad -vvv Bunny.