String Replace with input box?

[mlewis412]

Hello,

I was wondering if I can get some assistance with this script.  I put the $input1 in the StringReplace to give a better understanding on what I am trying to accomplish. Long story short, I am trying to have input box 1 be free text and any space that is input will be replaced with a  "-" (minus). 

Thanks you all!

#include <MsgBoxConstants.au3>

; Replace a blank space (' ') with a - (minus) character.
Local $sString = StringReplace("$input1", " ", "-")
Local $iReplacements = @extended
$parentgui=GUICreate("Convert", 600, 620)
$input1= GUICtrlCreateInput ("",10,10,200,200)
$input2= GUICtrlCreateInput ("",300,10,200,200)
$convert= GUICtrlCreatebutton ("Convert",220,100,50,50)
GUISetState(@SW_SHOW)



While 1
    $iMsg = GUIGetMsg()



      GUISetState(@SW_SHOW)


              Select
              Case $iMsg = $convert
            ControlSetText ("Convert","","[CLASS:Edit; INSTANCE:2]", $sString)
            ;($MB_SYSTEMMODAL, "", $iReplacements & " replacements were made and the new string is:" & @CRLF & @CRLF & $sString)

 Endselect
WEND

[SadBunny]

You're almost there.

What you need to change is that the $sString needs to be filled with the text in $input1 when you click the button, not at the start of your script. Also, "$input1" does not give you the contents of the input control stored in $input1, you need ControlGetText for that.

This is your code with these changes. They're minimal, but I guess this is what you're looking for.

Also, please tidy your code by pressing ctrl+t (if you're using SciTE 4 autoit3), it helps to make the code readable and can detect some errors before running.

#include <MsgBoxConstants.au3>

; Replace a blank space (' ') with a - (minus) character.
Local $iReplacements = @extended
$parentgui = GUICreate("Convert", 600, 620)
$input1 = GUICtrlCreateInput("", 10, 10, 200, 200)
$input2 = GUICtrlCreateInput("", 300, 10, 200, 200)
$convert = GUICtrlCreateButton("Convert", 220, 100, 50, 50)
GUISetState(@SW_SHOW)

While 1
    $iMsg = GUIGetMsg()

    GUISetState(@SW_SHOW)

    Select
        Case $iMsg = $convert
            Local $sString = StringReplace(ControlGetText("","", $input1), " ", "-")
            ControlSetText("Convert", "", "[CLASS:Edit; INSTANCE:2]", $sString)
            ;($MB_SYSTEMMODAL, "", $iReplacements & " replacements were made and the new string is:" & @CRLF & @CRLF & $sString)
    EndSelect
WEnd

[sdfaheemuddin]

instead of using ControlGetText use GuiCtrlRead ($input1)

and instead of ControlSetText use GuiCtrlSetData

[TheSaint]

You are doing a declaration of something in this line

Local $sString = StringReplace("$input1", " ", "-")

that isn't created until this line

$input1= GUICtrlCreateInput ("",10,10,200,200)

It doesn't work like that, you need to create that variable value first.

It needs to be in the correct order like the following

Local $sString
$input1 = GUICtrlCreateInput("", 10, 10, 200, 200)
$sString = StringReplace($input1, " ", "-")

It appears to me, that you are probably just needing to use - GUICtrlRead on your Input, and doing your replacement on the value returned.

Local $sString
$input1 = GUICtrlCreateInput("", 10, 10, 200, 200)

$sString = GUICtrlRead($input1)
$sString = StringReplace($sString, " ", "-")

You could use those last two lines in your button code.

Case $iMsg = $convert
     $sString = GUICtrlRead($input1)
     $sString = StringReplace($sString, " ", "-")
     ControlSetText("Convert", "", "[CLASS:Edit; INSTANCE:2]", $sString)

I've not tested it of course, but that is the idea roughly, in simple terms.

Edited March 3, 2015 by TheSaint

[mlewis412]

Thank you all for the input I really appreciate it so much! You're the best evaaaa!