Script Help

[sadlerd]

Running Win 7 I'm trying to create a very basic script that will Run on a "standard" non elevated account and running into issues with the script. 

Basically, mapping the Install Drive with Admin account, copyingthe  "reg and bat files" into an MIS Folder, RunAsSet with Local Admin Info

then removing the folder after and restarting the PC.  What am I doing wrong with the Win 7 ? 

 

DriveMapAdd( "X:", "\\adp2\ad_installs" , 0, "username", "password")
DirCreate("C:\mis")
FileCopy("X:\vnc.reg", "C:\mis\")
FileCopy("X:\vncreg.bat", "C:\mis\")
FileCopy("X:\instvnc.bat", "C:\mis\")
FileCopy("X:\security.bat", "C:\mis\")
FileCopy("X:\vnc-4_1_1-x86_win32.exe", "C:\mis\")
FileCopy("X:\reg.exe", "C:\mis\")
FileCopy("X:\firewall2013.bat", "C:\mis\")
RunAsSet("Administrator", @Computername, "password")
RunWait("C:\mis\security.bat")
RunWait("C:\mis\instvnc.bat")
RunWait("C:\mis\vncreg.bat")
RunWait("C:\mis\reg.exe")
RunWait("C:\mis\firewall2103.bat")
DriveMapDel("X:")
SplashTextOn("Title", "Your computer will restart In 20 Seconds Please Save and close all Applications .", -1, -1, -1, -1, 4, "", 16)
Sleep(20000)
SplashOff()
RunAsSet()
Shutdown(6)

[Shane0000]

I dont think RunAsSet exists anymore, I think its jus RunAs() now. Do you know where your script fails?

[sadlerd]

It does actually fail at the Line 10 .. which is the RunAsSet  

and I need this to be able to run without prompting any UAC stuff.  This is desigend to "install our VNC" client, and some of the PCS need this info updated, and we can't "remote" them unless the end user can run the .exe to add all the permissions inside the bat files. 

Edited June 22, 2015 by sadlerd

[Shane0000]

https://www.autoitscript.com/autoit3/docs/functions/RunAs.htm

Looks like the paramaters are the same with the exception of RunAsSet() [RunAS() has to be supplied arguments]

[sadlerd]

made the change but it gives a  Line 10 Error: Incorrect number of parameters in function call.  Now sure what that means. 

 

DriveMapAdd( "X:", "\\adp2\ad_installs" , 0, "username", "password")
DirCreate("C:\mis")
FileCopy("X:\vnc.reg", "C:\mis\")
FileCopy("X:\vncreg.bat", "C:\mis\")
FileCopy("X:\instvnc.bat", "C:\mis\")
FileCopy("X:\security.bat", "C:\mis\")
FileCopy("X:\vnc-4_1_1-x86_win32.exe", "C:\mis\")
FileCopy("X:\reg.exe", "C:\mis\")
FileCopy("X:\firewall2013.bat", "C:\mis\")
RunAs("Administrator", @Computername, "password")
RunWait("C:\mis\security.bat")
RunWait("C:\mis\instvnc.bat")
RunWait("C:\mis\vncreg.bat")
RunWait("C:\mis\reg.exe")
RunWait("C:\mis\firewall2103.bat")
DriveMapDel("X:")
SplashTextOn("Title", "Your computer will restart In 20 Seconds Please Save and close all Applications .", -1, -1, -1, -1, 4, "", 16)
Sleep(20000)
SplashOff()
RunAsSet()
Shutdown(6)

[JLogan3o13]

It means you aren't calling the parameters correctly. Look at RunAs in the help file, and the associated parameters. Hint: you're missing two

[water]

Dog ate your help file?
You need at least 5 parameters:

RunAs ( "username", "domain", "password", logon_flag, "program" [, "workingdir" [, show_flag [, opt_flag]]] )

 

[Shane0000]

If you dont have a help file the link I supplied shows the help file page for RunAs()

[sadlerd]

Thank You for all the help so far, sorry for all the new questions, i'm very new to AutoIT, and I'm trying to re-write scripts that someone did years ago for Win7. 

 

I was able to get it to run, it creates the Mapped drives, copies over the files. . 

but I think the runas RunAs command to kick the bat files off didn't go as expected.. It didn't install the software.  

Is there another command i'm missing? 

Runas("Administrator", @Computername, "password", 0, "C:\mis\security.bat")
RunAs("Administrator", @Computername, "password", 0, "C:\mis\security.bat")
RunAs("Administrator", @Computername, "password", 0, "C:\mis\instvnc.bat")
RunAs("Administrator", @Computername, "password", 0, "C:\mis\vncreg.bat")
RunAs("Administrator", @Computername, "password", 0, "C:\mis\reg.exe")
RunAs("Administrator", @Computername, "password", 0, "C:\mis\firewall2103.bat"

[water]

Maybe you need to set the working directory for the bat files? Try:

Runas("Administrator", @Computername, "password", 0, "C:\mis\security.bat", "C:\mis\")

[JLogan3o13]

Also, while this is probably not the answer you're looking for today, in the end you are going to be better off moving all of your batch files to either functions within your AutoIt script or external scripts/UDFs that you can call from your main script. Avoiding the mixture of scripting languages whenever possible will save you a ton of headaches down the road.

[iamtheky]

I'm going to guess security is not at the forefront if you are plaintexting an admin username/password (and in autoit land, compiled in an exe also counts as plaintext): 

You have network connectivity to the box, and you cant navigate to any default shares and drop the bats and give yourself rights?

[jchd]

Something else: be sure to use at least the release version of AutoIt, if not the beta.