FileWrite problem...

[langlearnkorean]

I made a simple leitner box type flash card system years ago and I recoded it today but I have a problem. When ever I write a string to a new text document it sometimes does not write with a new line. When I realized I had that problem I added a new line character before the string which fixed that problem. Then a new problem was it sometimes did two lines so then one was left empty. After that I went back to without the new line character. I am not sure if I am describing this very well so I will just show it like this..

BEFORE

level 1.txt

blah    apple
dino    car
pizza    place
taste    animal

level 2.txt

pear    help
zebra   cardinal

AFTER

level 1.txt << if you get the answer right first line is removed from level 1 and moved to the end of level 2

dino    car
pizza    place
taste    animal

level 2.txt << CORRECT << first line of level 1 is moved to the end of level 2 if you get it right.. 

pear    help
zebra   cardinal
blah    apple

level 2.txt << MY PROBLEM << sometimes it does it the correct way but sometimes it does this.

pear    help
zebra   cardinalblah    apple

I really have no idea how to fix this problem. I have tried FileWrite, FileWriteLine, FileOpen without 1, _FileWriteToLine with string length etc.

 

expandcollapse popup

; I removed most of the stuff that has nothing to do with the problem

Local $FileOpen = FileOpen($Destination)
Local $wordLine = FileReadLine($FileOpen,1)
Local $array = StringSplit($wordLine,"  ")
Local $kor = $array[1]
Local $eng = $array[2]
if($level<5) Then
 _FileWriteToLine($Destination,1,"",1)
EndIf
FileClose($FileOpen)

Local $string = $kor&"  "&$eng


;change to new directory file after removing line from the lower level file

If ($level=1) Then
 $Destination="level 2.txt"
 $FileOpen = FileOpen($Destination,1)
 FileWrite($Destination, $string)
ElseIf ($level=2) Then
 $Destination="level 3.txt"
 $FileOpen = FileOpen($Destination,1)
 FileWrite($Destination, $string)
ElseIf ($level=3) Then
 $Destination="level 4.txt"
 $FileOpen = FileOpen($Destination,1)
 FileWrite($Destination, $string)
ElseIf ($level=4) Then
 $Destination="level 5.txt"
 $FileOpen = FileOpen($Destination,1)
 FileWrite($Destination, $string)
EndIf


FileClose($FileOpen)

 

Edited August 6, 2015 by langlearnkorean

[JohnOne]

A runnable example would help your cause.

[BrewManNH]

If you use append a @CRLF to the string before you write it, then it will write that to the file.

[kaisies]

Insert the @CRLF at the end of your string, like 

FileWrite($Destination, $string & @CRLF)

If unsure if you already have a @CRLF (@CR @LF) in string, you could remove all but one...

Obviously this is spaghetti code.

$sString = "1" & @CRLF & "2" & @LF & "3" & @CR & "4"

msgbox(0,'',$sString)

$sString = _RemoveALL_CR_LF_CRLF_ExceptOne($sString)

msgbox(0,'',$sString)



Func _RemoveALL_CR_LF_CRLF_ExceptOne($sTmp)
    If Not IsString($sTmp) Then Return Msgbox(0,'',"Hey man, you didn't input a string!")

    Do
        $sTmp = StringReplace($sTmp,@CRLF,"")
    Until StringInStr($sTmp,@CRLF) = 0

    Do
        $sTmp = StringReplace($sTmp,@CR,"")
    Until StringInStr($sTmp,@CR) = 0

    Do
        $sTmp = StringReplace($sTmp,@LF,"")
    Until StringInStr($sTmp,@LF) = 0

    Return $sTmp & @CRLF
EndFunc

 

And as brewman said, Appending a @CRLF is good code, prepending is typically bad.

 

If you use append a @CRLF to the string before you write it, then it will write that to the file.

 

Edited August 6, 2015 by kaisies

[guinness]

@kaisies, why not use?

Local $sData = StringRegExpReplace($sSomeData, '\R', '') ; \R matches \r\n, \r or \n

 

[kaisies]

@kaisies, why not use?

Local $sData = StringRegExpReplace($sSomeData, '\R', '') ; \R matches \r\n, \r or \n

 

Because I know nothing about regexp yet

[guinness]

Now you have somewhere to begin.