Radio button variable not getting correct value

[dts256]

Hi,

For some reason the attached code doesn't work properly. The variable for the radiobutton seems to be being set to the number of code lines above it in the first instance, so nothing happens if I select the first radio button. However, it works if the second radio button is selected.

How do I correct this please ?

I'm new to Autoit, only started with it a cople of days ago, so go easy

 

Test1.au3

[JLogan3o13]

@dts256 welcome to the forum. The reason you're having problems is you assigned the same variable name to both radio buttons. Assign them different names (e.g. $radio1 and $radio2) and see what that buys you

Edit: I see what you're trying to do, loop through the radio buttons. Give me a second to throw an example up that shows that.

 

Edited February 1, 2016 by JLogan3o13

[dts256]

Wow, thank you for such a quick response.

I'll try it, just now and let you know how I get on.

 

[BrewManNH]

#include <GUIConstantsEx.au3> ;Constants for GUI Events

; Hides tray icon
;#NoTrayIcon

; create the GUI.
$win = GUICreate("Choose Program")

;Show the GUI
GUISetState(@SW_SHOW)

; Create the radio buttons
GUICtrlCreateGroup("Programs", 8, 50, 140, 200)
$radio1 = GUICtrlCreateRadio("Notepad", 20, 100)
$radio2 = GUICtrlCreateRadio("Calculator", 20, 120)

;Create the OK button
$okButton = GUICtrlCreateButton("OK", 300, 360)

; Continuous Loop to check for GUI Events
While 1
    $msg = GUIGetMsg()
    Select
        Case $msg = $GUI_EVENT_CLOSE
            Exit
        Case $msg = $okButton
            Select
                Case GUICtrlRead($radio1) = $GUI_CHECKED
                    RunWait("Notepad.exe")
                Case GUICtrlRead($radio2) = $GUI_CHECKED
                    RunWait("Calc.exe")
            EndSelect
    EndSelect
WEnd

Your 2 radio buttons are being assigned to the same variable, so you're overwriting the control ID from the first radio control when you created the second.

 

[JLogan3o13]

BrewManNH beat me to the example. Is that more in line with what you're trying to do, or do you expect to have a number of radio buttons and want to loop through them to see which is checked?

[dts256]

@BrewManNH

Thank you for your quick reply.

I've just tried that, the gui just closes after clcking ok, whichever radio button I select.

 

[BrewManNH]

Just now, dts256 said:

I've just tried that, the gui just closes after clcking ok, whichever radio button I select.

No it doesn't.

Not the script that I posted at least.

[dts256]

There's something weird going on with my Scitec. Whenver I copy and paste any code into a new window, none of the formatting shows up and also the "Go" button is greyed out.

So I made the changes that I could see in your script to mine and the gui just closes after I've selected a button and pressed ok. I know that's a far cry from what I actually said, so apologies for that and I guess I must have missed one or more of your changes.

What I'd actually like to have is just a single variable to check, rather than multiple ones, as in the attached code, from http://www.gamerzplanet.net/threads/autoit-some-easy-tuts.236602/ which works when youve added the button back in.

FromWeb.au3

[dts256]

Just figured out why no formatting etc showed up. I accidentally saved the file as .au instead of .au3

@BrewManNH

Your modifications to my code work like a charm, thank you for that and sorry for the misunderstanding earlier.

@JLogan3o13

Thank you for your help so far.

 

If it's possible, I'd still like to be able to do thisusing just one variable though, like in the code I attached earlier.

[BrewManNH]

That script will never work as intended, it has the same mistake your original script does, it's reusing the $radio variable, so the only control it will EVER be able to read is the last one created.

 

[dts256]

Actually, you're right. Didn't realise it before you said, but the age group is always the same one, 41-50, I think it was, whatever button is selected, and I hadn't noticed that before.

So, now at least I understand why my original code doesn't work. I've learnt something, so I'm happy.

Thnak you both for your help.