Noob Alert - Unable to Parse

[mr_synapse]

I am trying to edit a script that I found, and I am not having any luck getting it to compile/run. Here is the script:

#include <FileConstants.au3>
#include <MsgBoxConstants.au3>
$file_src = FileOpenDialog ( “Choose a CSV file with host objects”, @ScriptDir, “Comma delimeted files (*.csv)” )
$source = FileOpen($file_src)
$dest = FileOpen(@ScriptDir & “\cli-commands.txt”, $FO_OVERWRITE )

; file format <service name>,<service protocol>,<service port(s)>
While 1

$line = FileReadLine($source)
If @error Then ExitLoop

$split_line = StringSplit($line, “,”)

$hName = $split_line[1]
$hAddr = $split_line[2]
$hDesc = $split_line[3]

FileWriteLine($dest, ‘set service ‘ & ‘”‘ & $hName & ‘” protocol “‘ & $hAddr & ‘” port ‘ & $hDesc)

WEnd

FileClose($file_src)
FileClose($dest)

 

I get an error at line 3 (FileOpenDialog line). I have tried what little I can find online, but I don't know where to proceed from here.

The script should take values from a .csv file and creat text lines with those values in a particular format. The script looks okay to me... help! Thank you!!!

 

[Jos]

You have used the wrong characters for your string quotations, both the double and single quotes.

#include <FileConstants.au3>
#include <MsgBoxConstants.au3>
$file_src = FileOpenDialog("Choose a CSV file with host objects", @ScriptDir, "Comma delimeted files (*.csv)" )
$source = FileOpen($file_src)
$dest = FileOpen(@ScriptDir &"\cli-commands.txt", $FO_OVERWRITE )

; file format <service name>,<service protocol>,<service port(s)>
While 1

$line = FileReadLine($source)
If @error Then ExitLoop

$split_line = StringSplit($line,",")

$hName = $split_line[1]
$hAddr = $split_line[2]
$hDesc = $split_line[3]

FileWriteLine($dest, 'set service ' & '"' & $hName & '" protocol"' & $hAddr & '" port ' & $hDesc)

WEnd

FileClose($file_src)
FileClose($dest)

Jos

[alien4u]

@Jos answare is the correct one, mine was wrong, my eyes just fail me.

Kind Regards
Alien.

Edited April 8, 2016 by alien4u
Wrong Answare...

[AutoBert]

@Alien4u: the original line is correct, yours must throw error. Read in helpfile about missing 2. param $delimiter. The fields are comma separated so it's correct.

[alien4u]

1 hour ago, AutoBert said:

@Alien4u: the original line is correct, yours must throw error. Read in helpfile about missing 2. param $delimiter. The fields are comma separated so it's correct.

You are right read my previous post, you probably was writing this when I was editing my post.

[mr_synapse]

@Jos - I must apologize, but I don't know exactly what you mean. Is there somewhere where I can go to read about how to do this correctly? Thank you very much, I appreciate your time/help. 

[Jos]

Just use my posted code which is corrected.

One example: 

Your code: FileOpenDialog ( “Choose 
My code:    FileOpenDialog( "Choose
 

Jos

 

[MagnumXL]

This often happens if code is copied and pasted from Word or a similar program. It automatically changes double and single quotes to those damned opening and closing quotes that are not the same character at all. Whoever that that was a good idea was.. well... wrong.