GUI becomes unresponsive - large script

[LisHawj]

I have a large script I wrote up that for the most part works well, but the main GUI is unresponsive until the script finishes running all the functions called by START.  Below is a sample of the general layout of my script.  What can I do to make the main GUI responsive so I can exit, or close it when functions within the script encounter a problem or errors out?  I am still learning so my logic and scripting is most likely inefficient.  Thanks for your time.

expandcollapse popup

; Script Start - Add your code below here
#include <File.au3>
#include <ProgressConstants.au3>
#include <MsgBoxConstants.au3>
#include <TabConstants.au3>
#include <Clipboard.au3>
#include <Constants.au3>
#include <IE.au3>

;Terminates the script
HotKeySet("{ESC}", "Stop")

; Pause the script by pressing {PAUSE} key on keyboard.  Press key again to resume script.
HotKeySet("{Pause}", "Toggle_Pause")

Global $Paused

; Pause routine
Func Toggle_Pause()
    $Paused = Not $Paused
    While $Paused
        Sleep(100)
        ToolTip('Build script status: "Paused"', 25, 93)
    WEnd
    ToolTip("")
EndFunc   ;==>Toggle_Pause

While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case $hButton3
            $sClicked = MsgBox(65, "Testing101", "Testing")
            If $sClicked = 1 Then
                WinSetState("Testing101", "", @SW_MINIMIZE)
                Call("Start")
            ElseIf $sClicked = 2 Then
                Call("Stop")
            EndIf
    EndSwitch
WEnd

Func Start()
    ;Script runs in the following tasks sequentially.
    Call("Read_Reports")
    Call("Change_Zones")
    Call("Run_SCCMReports")
    Call("Run_PointsecReports")
    Call("Run_McAfeeReports")
    Call("Get_VPNStatus")
    Call("Get_BlueCoatstatus")
    Call("Get_ParityStatus")
    Call("Get_DSPstatus")
    Call("Get_CMSstatus")
    Call("Get_EndReports")
    Call("Run_Console1")
    Call("End_Scripts")
EndFunc   ;==>Start

;A bunch of functions called by the START fucntion


;End bunch of functions.

ror?

 

[Melba23]

LisHawj,

Firstly, do not use Call - it is only necessary when the function name is a literal string.

To keep the GUI responsive, you could do something like this:

Func Start()
    ;Script runs in the following tasks sequentially.
    
    ; Get the function to return a suitable value and error/extended code (Use SetError to do this)
    $iRet = Read_Reports()
    
    ; Now check return and see how it went
    If @error Then
        ; Do whatever is necessary
    EndIf
    
    ; Now check the main GUI and see if any controls were clicked
    Switch GUIGetMsg()
        Case $GUI_EVENT_CLOSE
            Exit
        Case $c_Another_Button
            ; Do something else
            ; etc etc
    EndSwitch
    
    ; Now move on to the next function and repeat
    $iRet = Change_Zones()

Or you could read the Interrupting a running function tutorial in the Wiki and use one of the techniques explained there.

M23

 

[LisHawj]

@Melba32 - Thank you for the helpful comment and the link to Interrupting a running function.  I have one more question though and did a search on this but  could not find a clear answer or an answer I could easily understand.  What is the difference between the following two sample codes?  Any advantage of one over the other and in which coding situation would one be more likely used over the other?

 

Start ()

Func Start()
    Call("Happy_Holiday")
    Call("Winter_Holiday")
    Call("Summer_Holiday")
Endfunc


; vs. using the code below?  

Start ()

Func Start()
    Happy_Holiday()
    Winter_Holiday()
    Summer_Holiday()
Endfunc

 

[BrewManNH]

16 hours ago, LisHawj said:

What is the difference between the following two sample codes? 

Functionally they're the same, the second one takes much less typing. The first one, while perfectly valid, is a waste of typing because you gain nothing by using Call over not using it, in this example.

Edited May 18, 2016 by BrewManNH