Embedded If-EndIf statement

[Briandr]

Hi,

The inner If-EndIf code shown below is failing to write to the log. Can someone please help? I been searching for the right way to check for the registry key. I don't necessarily care about the value of the registry key. Just need a way to check if it exists. Come on over 29 views and no one?

If @OSArch = "X64" and @OSVersion = "WIN_7" Then
        $CheckForSSKey = RegRead("HKLM\Software\DellKACE\MySSVersion", "MySSVersion")
        If @Error -1 Then ;Key does exist
        _FileWriteLog($Log, "MySS up to date, no action needed.")
        Exit
        ElseIf @Error > 1 Then ;Key does not exist
        _FileWriteLog($Log, "MySS out of date.")
        RunWait(@ComSpec & " /c " & 'net stop pcasvc', "", @SW_HIDE)
        FileChangeDir("%systemroot%\syswow64")
        FileDelete("%systemroot%\syswow64\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\syswow64\My.scr", 1)
        FileChangeDir("%systemroot%\sysnative")
        FileDelete("%systemroot%\sysnative\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\sysnative\My.scr", 1)
        RegWrite("HKLM" & "\Software\DellKACE", "MySSVersion", "REG_SZ", "2")
        RunWait(@ComSpec & " /c " & 'net start pcasvc', "", @SW_HIDE)
        _FileWriteLog($Log, "MySS is now up to date.")
        EndIf
EndIf

Thanks.

Edited May 24, 2016 by Briandr

[mLipok]

Like this:

If @OSArch = "X64" And @OSVersion = "WIN_7" Then
    $CheckForSSKey = RegRead("HKLM\Software\DellKACE\MySSVersion", "")
    If @error Then ;Key not found
        _FileWriteLog($Log, "MySSKey missing; MySS out of date.")
        RunWait(@ComSpec & " /c " & 'net stop pcasvc', "", @SW_HIDE)
        FileChangeDir("%systemroot%\syswow64")
        FileDelete("%systemroot%\syswow64\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\syswow64\My.scr", 1)
        FileChangeDir("%systemroot%\sysnative")
        FileDelete("%systemroot%\sysnative\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\sysnative\My.scr", 1)
        RegWrite("HKLM" & "\Software\DellKACE", "MySSVersion", "REG_SZ", "2")
        RunWait(@ComSpec & " /c " & 'net start pcasvc', "", @SW_HIDE)
        _FileWriteLog($Log, "MySS is now up to date.")
    Else
        _FileWriteLog($Log, "MySS up to date, no action needed.")
        Exit
    EndIf
EndIf

 

?

[Briandr]

Thanks for offering assistance. Code still does not appear quite right. Results of the logging below:

2016-05-24 20:52:59 : My-SS-update2_test 4 module called
2016-05-24 20:52:59 : MySSKey missing; MentorSS out of date.
2016-05-24 20:52:59 : MySS is now up to date.

The only line that should have been written to the log should have been

MySS up to date, no action needed. 

That should have been written as the registry key is present. The other two lines should not have been written to the log file.

 

[mLipok]

hmmm....

If @OSArch = "X64" And @OSVersion = "WIN_7" Then
    $CheckForSSKey = RegRead("HKLM\Software\DellKACE\MySSVersion", "")
    If @error Then ;Key not found
        _FileWriteLog($Log, "MySSKey missing; MySS out of date.")
        RunWait(@ComSpec & " /c " & 'net stop pcasvc', "", @SW_HIDE)
        FileChangeDir("%systemroot%\syswow64")
        FileDelete("%systemroot%\syswow64\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\syswow64\My.scr", 1)
        FileChangeDir("%systemroot%\sysnative")
        FileDelete("%systemroot%\sysnative\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\sysnative\My.scr", 1)
        RegWrite("HKLM" & "\Software\DellKACE", "MySSVersion", "REG_SZ", "2")
        RunWait(@ComSpec & " /c " & 'net start pcasvc', "", @SW_HIDE)
        _FileWriteLog($Log, "MySS is now up to date.")
        ; if you want it once then use EXIT like in the second case you are using it
        Exit
    Else
        _FileWriteLog($Log, "MySS up to date, no action needed.")
        Exit
    EndIf
EndIf