User defined file path won't work with spaces

[autofaurus]

I am using an input box to allow myself or another to enter the name of the excel file they would like to use for the program in order to create a workbook object. My issue is that I can't get it to work with spaces. I have found multiple solutions for if the file path is written out, but i have the name of the file assigned to a variable. Below are the relevant lines:

Global $filename = InputBox("Reference Filename", "What is the name of the file where your references are stored?")
Global $excel = _Excel_Open()
Global $oWorkbook = @MyDocumentsDir & "\" & $filename & ".xlsx"
Global $workbook = _Excel_BookOpen($excel, $oWorkbook)

Running this gives me error code 2 if $filename has a space in it. This would mean that the file path doesn't exist, but it definitely does.

Also, please let me know if there is a better way to create a workbook object when the filename can be different each time.

I am very new to AutoIt and not a very experienced programmer in general so any help is appreciated. Thank you.

[water]

Will check over the weekend

[Subz]

Works fine for me, try running the following in Scite to make sure the file path is being set correctly:

#include <Excel.au3>
Global $hSelect = InputBox("Reference Filename", "What is the name of the file where your references are stored?")
Global $oExcel = _Excel_Open()
Global $sWorkbook = @ScriptDir & "\" & $hSelect & ".xlsx"
ConsoleWrite($sWorkbook & @CRLF)
Global $oWorkbook = _Excel_BookOpen($oExcel, $sWorkbook)
ConsoleWrite(@error & @CRLF)

 

Edited June 23, 2017 by Subz

[water]

Did you check that there a no leading or trailing spaces in the user input?

[cbruce]

The problem could easily be what water described ...

I don't have Excel, so can't test how _Excel_BookOpen($oExcel, $sWorkbook) evaluates the $sWorkbook string ...

But normally, a full file name with spaces needs to be wrapped in quotes to be evaluated as a valid filename.

So you would need:

Global $oWorkbook = '"' & @MyDocumentsDir & "\" & $filename & ".xlsx" & '"'

[water]

The Excel UDF uses FileExists to check the file and returns @error = 2 if the file could not be found.
So you could do this check in your script as well to make sure the file exists.