IE random crash

[tonycst]

while 1

        If WinActive($AssemblerGUI) > 0 And _IsPressed("0D", $hDLL) = 1 Then ;If GUI is active and ENTER is pressed, execute assemply count tabbibg.
            Assign("CountEntered", 0) ;reset the countentered
            $TabsToPress = GUICtrlRead($TabCount) ;read the number from the assembler GUI
            WinActivate($AssemblyWindow) ;activate assembly internet window
            $IE = _IEAttach($AssemblyWindow) ;attach selected window to IE process
            $PageLoadDone = _IELoadWait($IE) ;pause the script and returns 1 if done
            $IEObject = _IEGetObjByName($IE, "txtSearch") ;get object name to focus on
            _IEAction($IEObject, "focus") ;focus on the scan an item input
            For $i = 1 To $TabsToPress ;how many times to repeat the process below
                Send("{TAB}") ;switch to ALL of the next item in assembly
                Send("{SPACE}") ;press ALL of that item
            Next
            $HideCompleted = _IEGetObjByName($IE, "chkCompleted") ;check box with hide competed
            _IEAction($HideCompleted, "click") ;click hide completed
            GUICtrlSetData($TabCount, "")
            Assign("LimitWindowExisted", "No")
        EndIf

  If $CountEntered = 0 Then
            $IEAttach = _IEAttach($AssemblyWindow) ;attach IE
            $ID = _IEGetObjById($IEAttach, "lblItemData") ;get ID for the total lines of instruments in the list
            $Value = _IEPropertyGet($ID, "innertext") ;read the ID and get the number
            If $Value > 0 Then
                GUICtrlSetData($TabCount, $Value) ;assign number of lines into the assembler GUI so user wont have to.
                GUICtrlSetState($TabCount, $GUI_FOCUS);select all in case user manually enters the number by accident
                Assign("CountEntered", 1)
            EndIf
        EndIf

wend

 

This code crashes for random reasons while window never closes.
IE window does navigate here and there, but it never closes, yet at some random point, it seems to crash.

I do attach to the same window twice because i need to get lblItemData as well as to execute couontdown in the 1st If statement.

I am 100% sure it crashes somewhere in the second If statement   If $CountEntered = 0 Then but not sure why.

Once page is loaded again, it sometimes crashes sometimes does not.

Error is related either to _IEGetObjById (because there is an issue with the attached window or something) or _IEPropertyGet.

I will post the error once i see it, i someties see it right away sometimes it takes many many attempts doing exact same thing

 

Edited January 30, 2018 by tonycst

[DynamicRookie]

The problem in your script is that you putted too long "If" statements in a While loop.

 

Avoid doing combined "If" statements and instead use "And" to make so.

Try adding a sleep Statement At the end of the script, to avoid it of crashing when loading, remember it does nearly 100 loops per second.

[mLipok]

@tonycst try to read this:

* How to post code on the forum *

and then edit your post.

Please read also:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x *

Question:

Which AutoIt Version you are using ?
Which exactly error code you get - or what you mean "crash" ?

 

[tonycst]

47 minutes ago, DynamicRookie said:

The problem in your script is that you putted too long "If" statements in a While loop.

 

Avoid doing combined "If" statements and instead use "And" to make so.

Try adding a sleep Statement At the end of the script, to avoid it of crashing when loading, remember it does nearly 100 loops per second.

I will look into AND, thanks.

Adding sleep is a NO NO. GUI does not seem to respond to me pressing buttons if there is a sleep in the loop.

yes there is a GUI in that loop, i just removed most of the code and just left the two that had IE in it.

[tonycst]

 AutoIt Version: 3.3.14.1 if that helps.

I know how to post the code, thank you, i was in a hurry.

Question: How does AND help (before i tried using it) ?

Its just another condition that has to be meat.  (not exctly sure why i need AND here, i only check for 1 variable state, not two and it only one condition concerns me anyway)

thanks for reply.

[tonycst]

Here is a simple way to replicate the problem i have using IE code.

;AutoIt Version: 3.3.14.1
#include <IE.au3>
$IEAttach = _IEAttach("MSN.com")
While 1
    $ID = _IEGetObjById($IEAttach, "sb_form_go")
    $Value = _IEPropertyGet($ID, "innertext") ;read the ID and get the number
    ConsoleWrite ($Value & @CRLF)
WEnd

When that window is CLOSED, or something in it changes (not sure exactly what and i am not talking about that particular page MSN.com, i was just using it as an example)
i get error in console saying

--> IE.au3 T3.0-2 Error from function _IEPropertyGet, $_IESTATUS_InvalidObjectType
0
"C:\Program Files (x86)\AutoIt3\Include\IE.au3" (1899) : ==> The requested action with this object has failed.:
If IsObj($oObject.document.getElementById($sID)) Then
If IsObj($oObject^ ERROR

That crashes the script.

If window is CHANGED (like went to another website) it DOES NOT crash but gives errors about which i dont really care but here they are.

0
--> IE.au3 T3.0-2 Warning from function _IEGetObjById, $_IESTATUS_NoMatch (sb_form_go)
--> IE.au3 T3.0-2 Error from function _IEPropertyGet, $_IESTATUS_InvalidDataType

Anyway to prevent the script from crash if window is closed ?

Adding If WinExists ($WinName) = 1 does not help, because window can disapear at the milisecond after it gets attached and right before _IEGetObjById() gets to read the attached window.

So how do i deal with that ?

 

Thanks !

I hope i posted this correctly this time

Edited January 30, 2018 by tonycst

[jdelaney]

_IEErrorHandlerRegister

This will prevent the com exceptions.

#include <IE.au3>
_IEErrorHandlerRegister()
$oIE = _IECreate("google.com")
_IEQuit($oIE)
$oIE.document.getelementbyid('123')
ConsoleWrite("I'm still running!" & @CRLF)

output:

I'm still running!

[tonycst]

30 minutes ago, jdelaney said:

_IEErrorHandlerRegister

This will prevent the com exceptions.

#include <IE.au3>
_IEErrorHandlerRegister()
$oIE = _IECreate("google.com")
_IEQuit($oIE)
$oIE.document.getelementbyid('123')
ConsoleWrite("I'm still running!" & @CRLF)

output:

I'm still running!

YOU ARE THE MAN !

Am sure someone told me to do that before, but not in a straight forward way like you did.
Some people often reply with  "did you read post rules" and "did you read UDF post" etc and then give the answer, but for some reasons my brain is wired to ignore those and continue waiting for an answer from someone else.

Thanks allot.