Problem with run command

[satanico64]

hi guys,

What is the difference between run and shellexecute ?

I have a program which call another exe file.
And it works since many years with run command.

$path = "d:\barre.exe"
$path &= " Lanceur" ; A parameter for the exe.
Run($path, @TempDir, @SW_MAXIMIZE) ;
If @error Then
            consolewrite("erreur de lancement de " & $path & " erreur:" & @error & " @TempDir: " & @TempDir & @CRLF)
            shellExecute("d:\barre.exe" , "Lanceur")
                If @error Then
                    consolewrite("erreur de lanceemnt de ShellExecute" & $path & " erreur:" & @error & @CRLF)
                EndIf
endif

Today, for only one user, (on near 150 / 200) the program called doesn't start at all.

The run command is on error, so i tried with shellexecute and it works well.

My main program is launch by many users, it select and find the binary for the second program, copy it on the user computer, and run it locally (d:\barre.exe).

It works well since a very long time. Barre.exe is a toolbar, so with a gui.

I really don't explain this problem.

the folder where is the program is accessible for the user, with full rights, and @tempdir is ok too.

Any ideas ?

Thanks,

Nicolas

[Earthshine]

 

[satanico64]

ok thanks, and why do you think run doesn't work ?

[Earthshine]

run should return a PID, what is the return code?

[satanico64]

return @error = 1

[Earthshine]

maybe on some boxes they need the run to be executed like this

Run(@ComSpec & " /c " & 'commandName', "", @SW_HIDE)    ; don't forget " " before "/c"

Also, maybe a permissions issue? did you try #RequireAdmin directive?

Edited February 5, 2018 by Earthshine

[satanico64]

none permission are required. (users doesn't have admin rights).

My only user who has the problem has ended his working day, i'll try other things tomorrow

Even if it works, with /c, it won't explain why it happens.

[Earthshine]

I'm not the developer and cannot debug it. Just fine a workaround is all you can do.

[satanico64]

i don't thing, debug is done.

run command does'nt work with good parameters which works on shell execute.

So i ask the community on the possible cause of that.

Workaround is even done. I need to understand now.

[Earthshine]

PM the developers I guess.

Edited February 5, 2018 by Earthshine

[satanico64]

i still got patience to wait a little

 

[Earthshine]

 I just tested a run of notepad on a fake tempdir, and it does what yours does. so, maybe on that particular machine the temp folder is not what you think it is?

[satanico64]

i have displayed it in the code in case of error, it is ok and tested on the user computer

It's not the problem.

[Earthshine]

yes, I see, but it still fails on ONE computer, right? on THAT computer, the TEMP may not be what you expecting. in your call to ShellExecute you don't specify a WORKING DIR

trying to get a reason for the failure and testing like your code to verify results.

Edited February 5, 2018 by Earthshine

[Earthshine]

I bet that users TEMP and TMP environment variable are not correct or invalid.

[satanico64]

nope, i checked the log, look at the temp folder in the console, tested it.  This on the user computer. Physically. The temp folder is ok.

Tomorrow, i'll try others thing, as run without parameter. Run without tempdir.

[Earthshine]

ok. i just made my TEMP and TMP variable junk and get the same results you do running just notepad in the code. When the workingingdir is left blank, it works. that's all I've got right now. Is his TEMP dir full?!? hmmmm, maybe he needs a Chkdsk /f

running without tempdir works in all my tests so far. his disk might me messed up dude.

Edited February 5, 2018 by Earthshine

[satanico64]

So the answer to my problem after severals tests:

My exe file is stored locally in Global $DossierBarreSTC = EnvGet("USERPROFILE") & "\Mes Documents\programme\"

I had not precised this in my firsts post but finally it's the root cause.

 

On this computer, it's ok with  EnvGet("USERPROFILE") & "\Documents\programme\" but not using 'Mes Documents'.

In windows explorer, cmd etc 'Mes document's is well known. And even if i test fileexist in the code before the 'run', the file exists with both paths.

 

About 300 users, only one in this case.

Code ok

$DossierBarreSTC = EnvGet("USERPROFILE") & "\Documents\programme\"
            $path = $DossierBarreSTC & "binaires\barre stc.exe" 
            $path &= " Lanceur" ; parameter
            $pid = Run($path, @TempDir, @SW_MAXIMIZE)

Code Not ok:

$DossierBarreSTC = EnvGet("USERPROFILE") & "\Mes Documents\programme\"
            $path = $DossierBarreSTC & "binaires\barre stc.exe" 
            $path &= " Lanceur" ; parameter
            $pid = Run($path, @TempDir, @SW_MAXIMIZE)

So, the problem is solved. i have not totally understood why for this user but i bypassed it.

Thanks all.

[BrewManNH]

You could just use the macro @MyDocumentsDir to get the location of the current user's my documents folder location regardless of what it's named or where it's located.

For example on my work laptop I have moved the location of the Documents folder to my OneDrive folder so it gets backed up automatically, and you won't find it under my user profile in the usual place.

[satanico64]

yes, obviously, i didn't knew that macro at the time of the script

thanks for the tip