Unable to loop

[Cyborg5000]

Iam trying to loop a batch to create other batch...

that means from batch 1 (listed with commands) iam trying to read 1st line and create another batch 2.

However once the batch 2 is executed, batch 2 will get deleted, also from batch1 first line entry will get removed...

but not working:---

expandcollapse popup

FileClose($mainfile)
     ; =============================== End of Read given data and Create Transfer Batch 


  Call ("_checkfile") 

EndFunc   ;==>Submit 

  

  


 Func _checkfile()
 $file=FileOpen("C:\Windows\pyth\transf.bat",0) 

While 1
   $result=FileReadLine($file)
   Call ("_bat")
   If @error = -1 Then ExitLoop; end of file 

FileClose($file); do something with $result ...
 WEnd 

EndFunc 

  

Func _bat()
         Global $newbatch = ("C:\Windows\pyth\bat\trans.bat")
 $readfile = FileOpen("C:\Windows\pyth\transf.bat",0)
         $line2 = FileReadLine($readfile,1) 

        FileOpen($newbatch, 0)
         FileWrite($newbatch, $line2 & @CRLF)
         While 1
             $readfile1 = FileOpen("C:\Windows\pyth\transf.bat",0)
   $result1=FileReadLine($readfile1) 

  _FileWriteToLine($result1, 1, "", True)
       ShellExecuteWait("trans.bat", "", "C:\Windows\pyth\bat\", "")
     FileDelete ($newbatch)
     If @error = -1 Then ExitLoop; end of file 

FileClose($readfile)
 FileClose($newbatch) 

WEnd 

EndFunc

 

  

Edited May 7, 2018 by Melba23
Added code tags

[wisem2540]

Is there a reason you need BAT files?  You could probably do all the commands in autoit directly.

[BrewManNH]

This section is written wrong.

; This
While 1
        $result = FileReadLine($file)
        _bat()
        If @error = -1 Then ExitLoop ; end of file

        FileClose($file) ; do something with $result ...
WEnd
; should be written like this
    While 1
        $result = FileReadLine($file)
        If @error = -1 Then ExitLoop ; this was in the wrong place
        _bat()

        FileClose($file) ; do something with $result ...
    WEnd

The first parameter of _FileWriteToLine is supposed to be the file path and name, what is in the first line of C:\Windows\pyth\transf.bat? Also, the following 2 lines are wrong.

FileOpen($newbatch, 0)
    FileWrite($newbatch, $line2 & @CRLF)

The FileOpen opens the file in read mode, the second one writes to the file. The FileOpen isn't even needed because it returns a handle which you don't use anywhere. Then, you try to close $newbatch, but can't the way it's written, because you're using the file path and name, and not the handle returned from the FileOpen, so it's doing nothing, and you deleted the file 4 lines prior, so I'm not sure what exactly you THINK you're doing, but whatever it is isn't in the code you posted.

 

Explain what it is you're trying to do with the FileReads and Writes, what's in the batch files you think you're reading from, etc.

[Cyborg5000]

The batch1 is created for python + sdk commandline to execute, based on GUI, the user will fill diff sections and the script creates the python command-line (batch1 file) at the backend.

now instead of making the script run a single batch1 (parallel) (filled with command by command) iam trying to make another batch, by reading the 1st line of the batch1, create asking autoit to create a new batch 2

once batch 2 is executed, i need to have it deleted and also the line 1 command from the batch1 and make it loop till batch1 has no command left......and then exit

[Cyborg5000]

Loop isnt working....it leaves a blank line instead of getting below lines pushed to line 1....

 

Global $newbatch = ("C:\Windows\pyth\bat\trans.bat")
    While 1
        Global $readfile = FileOpen("C:\Windows\pyth\transf.bat", 0)
        FileOpen($newbatch, 0)
        Global $line1 = FileReadLine($readfile, 1)
        If @error = -1 Then ExitLoop ; end of file, nothing to read left, now exit....
        MsgBox(0, "Reading main batch", $line1, "", "")
        FileWrite($newbatch, $line1 & @CRLF)

        _FileWriteToLine("C:\Windows\pyth\transf.bat", 1, "", True)
        FileClose($readfile)
        Sleep(1000)
        MsgBox(0, "Executing single batch", FileReadLine($newbatch, 1), "", "")
        ShellExecute("trans.bat", "", "C:\Windows\pyth\bat\", "")
        Sleep(1000)
FileClose($newbatch)
        FileDelete($newbatch)
        WEnd

[Bilgus]

I think this is approximately what you are trying for?

#include <FileConstants.au3>
#include <File.au3>

Global $sSrcBat = "C:\Windows\pyth\bat\transf.bat"
Global $sDestBat = "C:\Windows\pyth\bat\trans.bat"

Global $sLineText
Global Const $iLine = 1

ConsoleWrite($sSrcBat & " , Exists: " & FileExists($sSrcBat) & @CRLF)

While FileExists($sSrcBat)
    $sLineText = FileReadLine($sSrcBat, $iLine)
    If @error <> 0 Then
        ConsoleWrite("EOF" & @CRLF)
        ExitLoop ; end of file, nothing to read left, now exit....
    Endif

    MsgBox(0, "Reading main batch", $sLineText)

    ;Put First line of src into dest
    FileWrite($sDestBat, $sLineText & @CRLF)

    ;Remove the First line from src
    _FileWriteToLine($sSrcBat, $iLine, "", True)

    Sleep(1000)

    MsgBox(0, "Executing single batch", FileReadLine($sDestBat, 1), "", "")
    ShellExecute($sDestBat, "", "", "")
    Sleep(1000)

    FileDelete($sDestBat)
WEnd

 

[Cyborg5000]

it still leaves out a blank line on the tranf.bat....after

_FileWriteToLine($sSrcBat, $iLine, "", True)

[Bilgus]

Are you expecting it to delete $sSrcBat when it is empty?

I verified it eats all lines in the $sSrcBat it leaves an empty file read 0 bytes

 

[Bilgus]

If you want $sSrcFile to be deleted then after wend you need something like this...

;;;WEND
If FileGetSize($sSrcBat) = 0 Then FileDelete($sSrcBat)

Check that size is 0 first just in case it got here through an error...