Jump to content

ArrayAdd ArrayPush ArrayInsert performance - (Moved)


Recommended Posts

Hello!

Im new to autoit.

I have .csv file with 8 coloumns and over 7-9k rows with tab delimeter. I split this file into 2D array using

 _FileReadToArray($file, $retArray, '', @TAB).

In second column of .csv file i have digit based string, this strings is not unique:
for example: 

  • 57814510303
  • 57814510303
  • 57814510303
  • 57954184645
  • 57986498899
  • 57986498899

I want to get unique values in separate array, now im getting result using following code:
 

Local $retArray
_FileReadToArray($file, $retArray, '', @TAB)
Local $idArray[UBound($retArray) - 1]
For $i = 1 To UBound($retArray) - 1
   _ArrayPush($idArray, $retArray[$i][1])
Next
$uniqueIdArray = _ArrayUnique($idArray, "", "", "", 0, "")

The script part with 

For $i = 1 To UBound($retArray) - 1
    _ArrayPush($korobIdArray, $retArray[$i][1])
Next

takes over 52 seconds for 7500 entries.
May be i should use another function instead _ArrayAdd to make it faster?

Sorry for my bad english, and thank you for your replies :)

Link to comment
Share on other sites

Link to comment
Share on other sites

3 minutes ago, LarsJ said:

Replace your _ArrayPush loop with this:

For $i = 1 To UBound($retArray) - 1
  $korobIdArray[$i] = $retArray[$i][1]
Next

 

Wow, thanks, now it takes miliseconds... its very obvious, why did not I think of it myself.
Thank you, i really appreciate your help

Link to comment
Share on other sites

  • Moderators

Moved to the appropriate forum.

Moderation Team

Public_Domain.png.2d871819fcb9957cf44f4514551a2935.png Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind

Open spoiler to see my UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...