ArrayAdd ArrayPush ArrayInsert performance - (Moved)

[slvtn666 0]

Hello!

Im new to autoit.

I have .csv file with 8 coloumns and over 7-9k rows with tab delimeter. I split this file into 2D array using

 _FileReadToArray($file, $retArray, '', @TAB).

In second column of .csv file i have digit based string, this strings is not unique:
for example: 

• 57814510303
• 57814510303
• 57814510303
• 57954184645
• 57986498899
• 57986498899

I want to get unique values in separate array, now im getting result using following code:
 

Local $retArray
_FileReadToArray($file, $retArray, '', @TAB)
Local $idArray[UBound($retArray) - 1]
For $i = 1 To UBound($retArray) - 1
   _ArrayPush($idArray, $retArray[$i][1])
Next
$uniqueIdArray = _ArrayUnique($idArray, "", "", "", 0, "")

The script part with 

For $i = 1 To UBound($retArray) - 1
    _ArrayPush($korobIdArray, $retArray[$i][1])
Next

takes over 52 seconds for 7500 entries.
May be i should use another function instead _ArrayAdd to make it faster?

Sorry for my bad english, and thank you for your replies

[LarsJ 592]

Replace your _ArrayPush loop with this:

For $i = 1 To UBound($retArray) - 1
  $korobIdArray[$i] = $retArray[$i][1]
Next

 

[slvtn666 0]

3 minutes ago, LarsJ said:

Replace your _ArrayPush loop with this:

For $i = 1 To UBound($retArray) - 1
  $korobIdArray[$i] = $retArray[$i][1]
Next

 

Wow, thanks, now it takes miliseconds... its very obvious, why did not I think of it myself.
Thank you, i really appreciate your help

[Vincor 4]

And now, just for the fun of it, a solution using Regular Expressions:

#include <StringConstants.au3>
#include <Array.au3>
Local $korobIdArray = StringRegExp(FileRead("file.tsv"),"(?m)^[^\t]\t(.*)$",$STR_REGEXPARRAYGLOBALMATCH)
Local $uniqueIdArray = _ArrayUnique($korobIdArray, 0, 0, 0, 0)

[Melba23 2,735]

Moved to the appropriate forum.

Moderation Team