Jump to content

Why can't I compare a variable less than 100 with another variable bigger 100?


Recommended Posts

I have this code 

It gets variable input from GUI to run a loop and write to a text file then copy it to the clipboard

But the thing is code runs normally with $px and $py <100 or both > 100 or with $px <10 and $py>100 but It's wrong with 10<$px <100 and $py >100

Can anyone tell me why?

Func clone()

Local $px = GUICtrlRead($input1)
Local $py = GUICtrlRead($input2)
Local $temp = "C:\temp.csv"
FileDelete($temp)
    While $px <= $py
        Local $name = "P"&$px
        FileWrite($temp, " & $name & ""& @CRLF)
        $px+= 1
    WEnd
$a=FileRead($temp)
ClipPut($a)
MsgBox($MB_ICONINFORMATION,"","Copied to Clipboard")

EndFunc

 

Edited by ThePoro
Link to comment
Share on other sites

4 minutes ago, ThePoro said:

It's wrong with$ px <100 and $py >100

Explain what you mean by it's wrong, what's wrong? What are you expecting to happen if the variables are those values, and what you're seeing happen?

If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Link to comment
Share on other sites

Values read from a control are strings. Convert to numbers using Int() or Number() to compare to numeric values.

This wonderful site allows debugging and testing regular expressions (many flavors available). An absolute must have in your bookmarks.
Another excellent RegExp tutorial. Don't forget downloading your copy of up-to-date pcretest.exe and pcregrep.exe here
RegExp tutorial: enough to get started
PCRE v8.33 regexp documentation latest available release and currently implemented in AutoIt beta.

SQLitespeed is another feature-rich premier SQLite manager (includes import/export). Well worth a try.
SQLite Expert (freeware Personal Edition or payware Pro version) is a very useful SQLite database manager.
An excellent eBook covering almost every aspect of SQLite3: a must-read for anyone doing serious work.
SQL tutorial (covers "generic" SQL, but most of it applies to SQLite as well)
A work-in-progress SQLite3 tutorial. Don't miss other LxyzTHW pages!
SQLite official website with full documentation (may be newer than the SQLite library that comes standard with AutoIt)

Link to comment
Share on other sites

Hello ThePoro, wellcome to AutoIt Forum.

Your problem is about comparing wrong data types. GUICtrlCreateInput elements may includes characters, numbers etc. So "GUICtrlRead" function returns you result as a string even if you put just numbers into it. You have to convert result of "GUICtrlRead" function to integer if you expect compare it as integer. Otherwise if you check "50" is less than "100" you get false as result. Because that means compare 50 and 100 as string and OS handle these strings by their characters. According to ASCII List "50" is bigger than "100";

Converting string to integer;

Local $px = Int(GUICtrlRead($input1))
Local $py = Int(GUICtrlRead($input2))

Here is a full example;

#include <MsgBoxConstants.au3>
#include <GUIConstantsEx.au3>

$gui = GUICreate("gui for testing", 300, 90, -1, -1)
$input1 = GUICtrlCreateInput("50", 0, 0, 300, 30)
$input2 = GUICtrlCreateInput("150", 0, 30, 300, 30)
$button1 = GUICtrlCreateButton("clone", 0, 60, 300, 30)
GUISetState(@SW_SHOW)

While 1
    Switch GUIGetMsg()
        Case $GUI_EVENT_CLOSE
            ExitLoop
        Case $button1
            clone()
    EndSwitch
WEnd

Func clone()
Local $px = Int(GUICtrlRead($input1))
Local $py = Int(GUICtrlRead($input2))
Local $temp = @DesktopDir & "\temp.csv"
FileDelete($temp)
    While $px <= $py
        Local $name = "P"&$px
        FileWrite($temp, "" & $name & ""& @CRLF)
        $px+= 1
    WEnd
$a=FileRead($temp)
ClipPut($a)
MsgBox($MB_ICONINFORMATION,"","Copied to Clipboard")
EndFunc

 

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

×
×
  • Create New...