Jump to content

How to speed up autoit program


Recommended Posts

Hello friends

This app is slow
How to increase its speed?

 

#include <Array.au3>
#include <StringConstants.au3>
#include <File.au3>
#include <String.au3>
Global $aWord[][2]  = [[1"google"],[2,"hello"]]



 
Global $sFileName = @ScriptDir & "\1.txt" ; 2MB Text File
Local $sFileRead = FileRead($sFileName)
Local $res = StringRegExp($sFileRead"(*UCP)\b[\pL\d]{2,}"3)
_ArrayDisplay($res)
 
for $sWord in $res
    $iIndex = _ArraySearch($aWord, $sWord000012)
    ;MsgBox(0,0,$iIndex)
    if $iIndex == -1 Then
        Local $aFill = [[0,$sWord]]
        _ArrayAdd($aWord,$aFill)
       
    Else
        $aWord[$iIndex][0] +=1
    EndIf
 
Next
_ArrayDisplay($aWord)

cpu.png

taskmgr.png

1.txt

Edited by Jangal
1.txt added
Link to post
Share on other sites
  • Developers

Why are you posting all these images? AutoIt3 is single threaded so will only run on one core of the CPU so will max use 25%.
Post your script code (not image) in a CODEBLOCK (<>) so we can have a proper look/test with that to see what can be done to make that faster. 

Jos

SciTE4AutoIt3 Full installer Download page   - Beta files       Read before posting     How to post scriptsource   Forum etiquette  Forum Rules 
 
Live for the present,
Dream of the future,
Learn from the past.
  :)

Link to post
Share on other sites
#include <Array.au3>
#include <StringConstants.au3>
#include <File.au3>
#include <String.au3>
Global $aWord[][2]  = [[1, "google"],[2,"hello"]]



 
Global $sFileName = @ScriptDir & "\1.txt" ; 2MB Text File
Local $sFileRead = FileRead($sFileName)
Local $res = StringRegExp($sFileRead, "(*UCP)\b[\pL\d]{2,}", 3)
_ArrayDisplay($res)
 
for $sWord in $res
    $iIndex = _ArraySearch($aWord, $sWord, 0, 0, 0, 0, 1, 2)
    ;MsgBox(0,0,$iIndex)
    if $iIndex == -1 Then
        Local $aFill = [[0,$sWord]]
        _ArrayAdd($aWord,$aFill)
       ; 
    Else
        $aWord[$iIndex][0] +=1
    EndIf
 
Next
_ArrayDisplay($aWord)

This script is fast on short strings
But in the attached file it takes hours

Link to post
Share on other sites
  • Developers

Care to also explain what it is you want to accomplish with the script and what it is for, so we understand?

SciTE4AutoIt3 Full installer Download page   - Beta files       Read before posting     How to post scriptsource   Forum etiquette  Forum Rules 
 
Live for the present,
Dream of the future,
Learn from the past.
  :)

Link to post
Share on other sites

So you're looking to make a script that creates a list of words and the number of times they appear in the document, right?

Right now, if a word appears 5 times in your document, you search for that word 5 times. Also, you begin your search at the beginning of the array each time, you only need to search after the current index word.

Possibly check out the implementation of _ArrayUnique in Array.au3 to get an idea of how to get started. (Note that this doesn't keep track of how many times each word appears)

Edited by seadoggie01

All my code provided is Public Domain... but it may not work. ;) Use it, change it, break it, whatever you want.

Spoiler

My Humble Contributions:
Personal Function Documentation - A personal HelpFile for your functions
Acro.au3 UDF - Automating Acrobat Pro
ToDo Finder - Find #ToDo: lines in your scripts
UI-SimpleWrappers UDF - Use UI Automation more Simply-er
KeePass UDF - Automate KeePass, a password manager

Link to post
Share on other sites

I'd say scripting dictionary.  It is the perfect situation to use it.  Here to start you up :

#include <Constants.au3>
#include <Array.au3>

Opt ("MustDeclareVars", 1)

Local $t = TimerInit()
Local $oDict = ObjCreate("Scripting.Dictionary")
Local $aWord = FileReadToArray("1.txt")
Local $iCount = @extended, $p

For $i = 0 To $iCount - 1
  If Not StringRegExp ($aWord[$i], "(*UCP)\b[\pL\d]{2,}") Then ContinueLoop
  $p = $aWord[$i]
  If $oDict.Exists($p) Then
    $oDict.Item($p) = $oDict.Item($p) + 1
  Else
    $oDict.Add($p, 1)
  EndIf
Next

ConsoleWrite($iCount & "/" & $oDict.Count & @CRLF)

Local $aCount[$oDict.Count][2]
$p = 0
For $vKeys In $oDict
  $aCount[$p][0] = $vKeys
  $aCount[$p][1] = $oDict.item($vKeys)
  $p += 1
Next

MsgBox($MB_SYSTEMMODAL, "", $p & "/" & TimerDiff($t))

Taking me 4.5 secs overall with your 1.txt file.

Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By TheAlienDoctor
      Hi, I was looking into creating a script that would detect if a file exists, then move it (and in some cases rename it, depending on the file) as well as write to a log file.
      The issue is, there is a lot of files that need to be moved, sometimes some files will exist and others won't depending on the use-case. However if a file does exist, it will always be going into the same directory with the same name.
      Currently I have an array nested inside of the array, with each array inside that array having both the old and new directory, and then a For loop to actually run through and do the file transferring. The issue I am having is how to call the Array inside of the array, because how do I specify  which the old directory is and which the new is?
      Global $FileTransfer[2000] = [Global $Dir1[2] = ["original dir 1", "new dir 1"], Global $Dir2[2] = ["original dir 2", "new dir 2"]] For $FileTransfer = [0] To [1] Step +1 If FileExists({original dir}) Then FileMove({original dir}, new dir, 1) FileOpen("log.latest.txt", 1) FileWrite("log.latest.txt", "{original dir} found, moved it to new dir." & @CRLF) FileClose("log.latest.txt") Else FileOpen("log_latest.txt", 1) FileWrite("log_latest.txt", "{original dir} not found, ignoreing it." & @CRLF) FileClose("log_latest.txt") EndIf Next I have put what I want the old and new directory to be for each array in {}, so hopefully its easier to tell which part is working and whats not.

      I am still reasonably new to AutoIT, any help is appreciated. Thankyou
    • By arunkw
      I have a spreadsheet - daily routine which has two columns: activity and time as shown here
      | Activity             | Time     | |----------------------|----------| | Sleep               |  6:00 am | | Toilet              |  6:15 am | | Get ready for gym  |  6:30 am | | Exercise            |  7:50 am | | ... more things      |  9:00 pm | | ... still more       | 10:45 pm | | Sleep               |  6:00 am |   I wanted to find out, say in C1 which activity is current for me using now() I.e., if it’s 6:45am on my watch, it should show me Exercise  in C1 Thanks to Adam D. PE, this formula works like magic to get the result =VLOOKUP(MOD(NOW(),1),{B2:B,A2:A},2,1)   Now, I want to reproduce same result in autoit, how to do that? To have easy solution say, I copy-paste spreadsheet data in array directly in code, right? Use for loop and run the above vlookup function and show the answer using tooltip. How to achieve this? please help.  
    • By goku200
      I have an Autoit script that lists files from a folder into an array list. Is there a way to separate the filenames by an underscore and include the id, version, name and date into separate columns in Excel.
      Example of filename:
      12345_v1.0_TEST Name [12345]_01.01.2022.html
      12345 would be in one column
      v1.0 would be in another column
      TEST Name [12345] would be in another column
      01.01.2022 would be in another column
      .html would be in another column
      Note: filenames always change each day.
      Here is my code that lists the files into column C and then writes the column Headers into Column D, E, F, G. Just need some help with separating them into columns by the _ delimiter
       
    • By mLipok
      Usually when I collect data from DataBase I need to give EndUser a possibility to select rows which should be taken in the processing loop.
      I was searching on the forum and I'm not able to find any UDF or even example of how to select data from array.
      I have my own solutions but I think they are not worth posting on the forum as it is very old code and I am looking for a better solution.

      Could anybody point me to some examples/solutions ?

      Thank you in advance.
      @mLipok
    • By EmilyLove
      I have a string containing the full path of an executable and an array of executables without their paths. I am trying to compare the string to the list in the array and if a match is found, remove it from the array. The entry get removed from the array successfully, and after checking its return result, uses it to update the ubound if it succeeded, but it doesn't want to update to the new value. Any ideas what I am doing wrong? It acts like it is read-only.
      #include <Array.au3> #include <File.au3> Local $sApp_Exe = "F:\App\Nextcloud\nextcloud.exe" Local $aWaitForEXEX = [3, "Nextcloud.exe", "nextcloudcmd.exe", "QtWebEngineProcess.exe"] For $h = 1 To $aWaitForEXEX[0] If StringInStr($sApp_Exe, $aWaitForEXEX[$h]) <> 0 Then $iRet = _ArrayDelete($aWaitForEXEX, $h) If $iRet <> -1 Then $aWaitForEXEX[0] = $iRet ;this line doesn't work. $aWaitForEXEX[0] doesn't update and shortly gives Error: Array variable has incorrect number of subscripts or subscript dimension range exceeded.: _ArrayDisplay($aWaitForEXEX) EndIf Next  
×
×
  • Create New...