Optimizing the code

[jerem488]

Hi all,

I have a function, it works fine but it takes many hours !! 

Can you tell me if the code can be changed? optimized?

expandcollapse popup

TournamentsClassement()
Func TournamentsClassement()
    ;This file have 25000 lines
    Local $s_FileClassement = @DesktopDir & "\Classement.txt"
    Local $h_FileOpenClassement = FileOpen($s_FileClassement)

    ;This file have 3000 lines
    Local $s_FileTournaments = @DesktopDir & "\Tournaments.txt"
    Local $h_FileOpenTournaments = FileOpen($s_FileTournaments)
    Local $i_LignesClassement = _FileCountLines($h_FileOpenClassement)
    Local $i_LignesTournaments = _FileCountLines($h_FileOpenTournaments)

    For $i_LignesTournament = 1 To $i_LignesTournaments
        $s_LigneTournament = FileReadLine($h_FileOpenTournaments, $i_LignesTournament)
        $a_DataTournament = StringSplit($s_LigneTournament, "|", 2)

        ConsoleWrite("Date match: " & $a_DataTournament[6] & @TAB & "Joueur: " & $a_DataTournament[9] & @TAB & "Adversaire: " & $a_DataTournament[10] & @LF)
        For $i_LigneClassement = 1 To $i_LignesClassement
            $s_LigneClassement = FileReadLine($h_FileOpenClassement, $i_LigneClassement)
            $s_LigneClassement = StringRegExpReplace($s_LigneClassement, "(\d{4})-(\d{2})-(\d{2})", "$1/$2/$3")
            ;ConsoleWrite("$s_LigneClassement: " & $s_LigneClassement & @LF)
            $a_DataClassement = StringSplit($s_LigneClassement, "|", 2)
            $i_DiffDate = _DateDiff("D", $a_DataTournament[6], $a_DataClassement[2])
            If $a_DataTournament[9] == $a_DataClassement[0] And $i_DiffDate < 0 Then
                _FileWriteToLine($h_FileOpenTournaments, $i_LignesTournament, $s_LigneTournament & "|" & $a_DataClassement[1])
                ConsoleWrite($s_LigneTournament & "|" & $a_DataClassement[1] & @LF)
                ExitLoop
            ;this part does not work properly.
            ;I must change the line "If $a_DataTournament[9] == $a_DataClassement[0] And $i_DiffDate < 0 Then" with If $a_DataTournament[10] == $a_DataClassement[0] And $i_DiffDate < 0 Then
            ;ElseIf $a_DataTournament[10] == $a_DataClassement[0] And $i_DiffDate < 0 Then
                ;_FileWriteToLine($h_FileOpenTournaments, $i_LignesTournament, $s_LigneTournament & "||" & $a_DataClassement[1])
                ;ConsoleWrite($s_LigneTournament & "||" & $a_DataClassement[1] & @LF)
                ;ExitLoop
            ; -------------------------------------------------------
            EndIf
        Next
    Next
EndFunc

Thanks

[FrancescoDiMuro]

@jerem488
Could you please post a sample text file and a desired result?

[dmob]

Depending on your data, you probably can read the files into arrays.... and marvel at the speed improvement

 

[Melba23]

jerem488,

This thread has been reported as possibly game-related. As far as I can see you are merely manipulating datasets, which happen to record the results of some form of competition. As such I am happy to leave the thread open.

M23

P.S. I completely agree with the "array" suggestion above.

[jchd]

I even suspect this could be best done using a database and then SQLite (included with AutoIt distribution) is a perfect candidate.

[jerem488]

13 minutes ago, jchd said:

I even suspect this could be best done using a database and then SQLite (included with AutoIt distribution) is a perfect candidate.

I think I will use this ! Arrays are too big for this...

[jchd]

Think twice  about the correct schema to create. If for only one sport or game (e.g. chess) and one level of competition (local, regional or national) then things are simple. If not it can always be done but will require more detailled thinking.

Without mode detail, I'd start with 3 tables constrained together by foreign keys:
  -) a players table
  -) a tournament table
  -) a matches table.

A very simple skeleton (omitting many things wich depend on the activity and rules) can then be:

CREATE TABLE "Players" (
  "PlayerID" INTEGER PRIMARY KEY, 
  "License" CHAR, 
  "LicenseYear" CHAR, 
  "Name" CHAR NOT NULL, 
  "Surname" CHAR, 
  "Rank" CHAR, 
  "Birth" CHAR, 
  "Phone" CHAR, 
  "Email" CHAR);
  
  CREATE TABLE "Tournaments" (
  "TournamentID" INTEGER PRIMARY KEY, 
  "Name" CHAR, 
  "Date" CHAR, 
  "Place" CHAR);

CREATE TABLE "Matches" (
  "MatchID" INTEGER PRIMARY KEY, 
  "TournamentID" INTEGER CONSTRAINT "fkMatchTournament" REFERENCES "Tournaments"("TournamentID") ON DELETE CASCADE ON UPDATE CASCADE DEFERRABLE INITIALLY DEFERRED, 
  "Datetime" CHAR, 
  "Player1" INTEGER CONSTRAINT "fkMatchPlayer1" REFERENCES "Players"("PlayerID") ON DELETE CASCADE ON UPDATE CASCADE DEFERRABLE INITIALLY DEFERRED, 
  "Player2" INTEGER CONSTRAINT "fkMatchPlayer2" REFERENCES "Players"("PlayerID") ON DELETE CASCADE ON UPDATE CASCADE DEFERRABLE INITIALLY DEFERRED, 
  "Score1" CHAR, 
  "Score2" CHAR, 
  "Comment" CHAR NOT NULL DEFAULT '');

This may need complete rewrite if, for instance, there are more than 2 players in a match, how the score is counted and detailed (e.g. tennis) and rank is computed. Yet this can be a basis for thinking about a schema.