Need Help Multible const in an "If Or" Statement - (Moved)

[BrAiNee]

Hello im Newbi in Programming with arrays or Multible if Or Statements. I have a Code that is secured by HWID, so i have Multible HWIDs and i will put them in one line maybe an array?

I don't whant to change my IF Statement every Time a New HWID is comming. How can i do this is in a nice way ? Here my code.

Local Const $hw1 = "42421425" ;mark
Local Const $hw2 = "85738578" ;monte
Local Const $hw3 = "84885282" ;heinz
Local Const $hw4 = "98573857" ;tobi

If _GetHWID() == $hw1 Or _GetHWID() == $hw2 Or _GetHWID() == $hw3 Or _GetHWID() == $hw4 Then
    $hwid_ok = True
Else
    Local $hwid_input = InputBox("HWID_ERROR", "Contact Support!", _GetHWID(), "", 270, 150)
    If @error Then
        Exit
    Else
        ClipPut(_GetHWID())
        Exit
    EndIf
EndIf

in this state i have to change my if statement and this can get very long. How to make it easy?

[Musashi]

4 hours ago, BrAiNee said:

How to make it easy?

There are several ways to do it. Here a solution via array :

#include <Array.au3>
#include <File.au3>

Global $aHWIDList, $sFilePath, $bHWIDFound, $sHWIDInput
$sFilePath  = @ScriptDir & "\HWIDList.txt"
$bHWIDFound = False
_FileReadToArray($sFilePath, $aHWIDList, $FRTA_NOCOUNT, ";")
_ArrayDisplay($aHWIDList) ; *** just for display during test

For $i = 0 To UBound($aHWIDList) - 1
    If _GetHWID() = $aHWIDList[$i][0] Then
        MsgBox(0, "HWID found", "HWID=" & $aHWIDList[$i][0] & "   Name=" & $aHWIDList[$i][1] & @CRLF)
        $bHWIDFound = True
        ExitLoop
    EndIf
Next

If Not $bHWIDFound Then
    $sHWIDInput = InputBox("HWID_ERROR", "Contact Support!", _GetHWID(), "", 270, 150)
    If @error Then
        Exit
    Else
        ClipPut(_GetHWID())
        Exit
    EndIf
EndIf

; naked function for testing :
Func _GetHWID()
    Local $sHWID = ""
    ; ... put the real GetHWID statements here
    $sHWID = "85738578" ; only for test
    Return $sHWID
EndFunc

 

HDWIList.txt (save it in your script folder) or use the attached file :

42421425;mark
85738578;monte
84885282;heinz
98573857;tobiData

HWIDList.txt

Edited January 26, 2021 by Musashi
typo

[Melba23]

Moved to the appropriate forum, as the Developer General Discussion forum very clearly states:

Quote

General development and scripting discussions.

---

Do not create AutoIt-related topics here, use the AutoIt General Help and Support or AutoIt Technical Discussion forums.

Moderation Team

[BrAiNee]

@Musashi that looks interesting can you show me how to make it in the code without the extra .txt file ?

please make it simple

regards BrAiNee

Edited January 26, 2021 by BrAiNee

[Musashi]

1 hour ago, BrAiNee said:

@Musashi that looks interesting can you show me how to make it in the code without the extra .txt file ?

The benefit of maintaining the data in an external file (here the .txt) is, that you can make additions without having to constantly change the script itself.

Here is an example which contains both variants (comment out the unwanted one) :

expandcollapse popup

#include <Array.au3>
#include <File.au3>

; ====> Comment out variant 1 or 2 depending on your needs

; ----> Variant 1 : Read data from a file : --------------
;~ Global $aHWIDList, $sFilePath, $bHWIDFound, $sHWIDInput
;~ $sFilePath  = @ScriptDir & "\HWIDList.txt"
;~ $bHWIDFound = False
;~ _FileReadToArray($sFilePath, $aHWIDList, $FRTA_NOCOUNT, ";")
; ----- End of Variant 1 ---------------------------------

; ----> Variant 2 : array within the script : ------------
Global $bHWIDFound, $sHWIDInput
Global $aHWIDList[4][2] = [["42421425", "mark"], _
                           ["85738578", "monte"], _
                           ["84885282", "heinz"], _
                           ["98573857", "tobiData"]]
$bHWIDFound = False
; ----- End of Variant 2 ---------------------------------

_ArrayDisplay($aHWIDList, "Test : Output") ; *** just for display during test

For $i = 0 To UBound($aHWIDList) - 1
    If _GetHWID() = $aHWIDList[$i][0] Then
        MsgBox(0, "HWID found", "HWID=" & $aHWIDList[$i][0] & "   Name=" & $aHWIDList[$i][1] & @CRLF)
        $bHWIDFound = True
        ExitLoop
    EndIf
Next

If Not $bHWIDFound Then
    $sHWIDInput = InputBox("HWID_ERROR", "Contact Support!", _GetHWID(), "", 270, 150)
    If @error Then
        Exit
    Else
        ClipPut(_GetHWID())
        Exit
    EndIf
EndIf

; naked function for testing :
Func _GetHWID()
    Local $sHWID = ""
    ; ... put the real GetHWID statements here
    $sHWID = "84885282" ; only for test
    Return $sHWID
EndFunc

 

[BrAiNee]

@Musashi thank you  that helps me allot.