ObjCreate error while performing on Excel Rows

[DigDeep]

Hi,

My code has been working with no issues since long years and I remember have not made any change to the below code but since past few months have started getting Object Create error always at line Local $iCountLines = $oWorkbook.ActiveSheet.UsedRange.Rows.Count.

Can someone help me with the cause and if anything is not correctly aligned here?

expandcollapse popup

Func XLSCalc()
    Local $ID = '/Check/Detail/UpdateData/@ID'
    Local $Inst = '/Check/Detail/UpdateData/@IsInstalled'
    Local $Down = '/Check/Detail/UpdateData/References/DownloadURL'
    Local $Title = '/Check/Detail/UpdateData/Title'
    Local $Restart = '/Check/Detail/UpdateData/@RestartRequired'
    Local $KBID = '/Check/Detail/UpdateData/@KBID'

    Local $C_DIR = "C:\Test"
    Local $Src_DIR = $C_DIR & "\Source"
    Local $Files_DIR = $Src_DIR & "\Files"
    Local $ScanResults_DIR = $Files_DIR & "\ScanResults"
    DirCreate($ScanResults_DIR)
    Local $xml_result = $ScanResults_DIR & "\Results.xml"

    Local $oExcel = _Excel_Open(False)
    If @error Then
        _Excel_Close($oExcel)
        MsgBox(48, "", "Patch Status: An Error occured while opening Excel during XLSCalc." & @CRLF & @CRLF & "Please contact the administrator.") ; Error occurred while launching report.
        Exit
    EndIf

    Local $xls_result = $ScanResults_DIR & "\Results.xls"
    Local $oWorkbook = _Excel_BookOpen($oExcel, $xls_result)
    If @error Then
        _Excel_Close($oExcel)
    EndIf

    Local $XMLOut = _Excel_RangeRead($oWorkbook, Default, "A1")
    Select
        Case $XMLOut = "/XMLOut"
            _Excel_RangeDelete($oWorkbook.ActiveSheet, '1:1', 1) ; Delete 1st line as /XMLOut
            If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber)

            _Excel_BookSave($oWorkbook)
            If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber)
    EndSelect

    Local $ColNum = $oWorkbook.ActiveSheet.UsedRange.Columns.Count ; Get last column Number
    Local $sTab7
    Local $ColName

    For $j = $ColNum To 1 Step -1
        Local $ScanResults_DIR = $Files_DIR & "\ScanResults"
        Local $FilePath = $ScanResults_DIR & "\Output.txt"
        Local $Output_FileOpen = FileOpen($FilePath, 2)
        Local $FileWrite = FileWrite($Output_FileOpen, $j)
        FileClose($Output_FileOpen)
        Local $TotalCol = FileRead($FilePath)
        Local $ColName = _Excel_ColumnToLetter($TotalCol) ; Get last column Header Name
        Local $sTab7 = _Excel_RangeRead($oWorkbook, Default, $ColName & '1')
        If $sTab7 = $ID Or $sTab7 = $Inst Or $sTab7 = $Down Or $sTab7 = $Title Or $sTab7 = $Restart Or $sTab7 = $KBID Then
            ; Do nothing...
        Else
            _Excel_RangeDelete($oWorkbook.ActiveSheet, $ColName & ':' & $ColName)
            If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber)

            _Excel_BookSave($oWorkbook)
            If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber)
        EndIf

        Local $sTab8 = _Excel_RangeRead($oWorkbook, Default, $ColName & '2')
        Local $sTab9 = _Excel_RangeRead($oWorkbook, Default, $ColName & '3')
        If $sTab8 = '' And $sTab9 <> '' Then
            _Excel_RangeDelete($oWorkbook.ActiveSheet, '2:2', 1) ; Delete 1st line if blank but not
            If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber)
            _Excel_BookSave($oWorkbook)
            If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber)
        EndIf

        If $sTab7 = $ID Or $sTab7 = $Inst Then
            Local $iCountLines = $oWorkbook.ActiveSheet.UsedRange.Rows.Count
        If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber)
        
            For $i = $iCountLines To 1 Step -1
                Local $sTab10 = _Excel_RangeRead($oWorkbook, Default, $ColName & $i)
                If $sTab10 = 'True' Then
                    _Excel_RangeDelete($oWorkbook.ActiveSheet, $i & ":" & $i, 1)
                    If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber)
                EndIf

                Local $sTab11 = _Excel_RangeRead($oWorkbook, Default, $ColName & $i)
                If $sTab11 = '123456' Then
                    _Excel_RangeDelete($oWorkbook.ActiveSheet, $i & ":" & $i, 1)
                    If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber)
                EndIf

                Local $v_Return = Column_GetValues($Files_DIR & "\Exclude.xls", "B", "A")
                Local $ExcludeFilePath = $ScanResults_DIR & "\FinalExclusion.txt"
                Local $FinalExclusion_FileOpen = FileOpen($ExcludeFilePath, 1)
                For $f = 1 To _FileCountLines($ExcludeFilePath)
                    $ExcludeFile = FileReadLine($ExcludeFilePath, $f)
                    If $sTab11 = $ExcludeFile Then
                        _Excel_RangeDelete($oWorkbook.ActiveSheet, $i & ":" & $i, 1)
                        If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber)
                    EndIf
                Next
                FileClose($FinalExclusion_FileOpen)
            Next
        EndIf
    Next
    _Excel_BookClose($oExcel)
    Sleep(500)
    _Excel_Close($oExcel)
EndFunc   ;==>XLSCalc

 

[water]

You should display an error message AND end the script when the workbook could not be opened.
Replace

Local $oWorkbook = _Excel_BookOpen($oExcel, $xls_result)
    If @error Then
        _Excel_Close($oExcel)
    EndIf

with

Local $oWorkbook = _Excel_BookOpen($oExcel, $xls_result)
    If @error Then
        MsgBox(0, "Error", "Can not open workbook. @error = " & @error & " and @extended = " & @extended & @CRLF & "Line: " & @ScriptLineNumber)
        _Excel_Close($oExcel)
        Exit
    EndIf

 

[mLipok]

Which AutoIt version you are using ?

I sugest to split this line:

Local $iCountLines = $oWorkbook.ActiveSheet.UsedRange.Rows.Count

to such piece of code:

Local $oSheet = $oWorkbook.ActiveSheet
Local $oUsedRange = $oSheet.UsedRange
Local $oRows = $oUsedRange.Rows
Local $iCount = $oRows.Count

[DigDeep]

@water My bad. I have that added already. Missed to provide that in the above code.

The error happens at the below line when the Rows count happens.

If $sTab7 = $ID Or $sTab7 = $Inst Then
            Local $iCountLines = $oWorkbook.ActiveSheet.UsedRange.Rows.Count

@mLipok I made the change and ran twice and now it is giving the attached error at the line:

Local $oSheet = $oWorkbook.ActiveSheet

 

I am wondering, there is no issue with 

Local $ColNum = $oWorkbook.ActiveSheet.UsedRange.Columns.Count ; Get last column Number

or any step prior it starts for Rows count.

[mLipok]

HINT:
Check

ConsoleWrite(IsObj($oWorkbook) & @CRLF) 
; and 
ConsoleWrite(ObjName($oWorkbook,1) & @CRLF) 
; before you use:
Local $oSheet = $oWorkbook.ActiveSheet

 

REMARK:
Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

SUMMARY:
Something goes wrong when you get reference to $oWorkbook object, and the problem is that you don't check it before you was trying to use it.

Edited April 21, 2021 by mLipok

[water]

We need more information:

• Which version of AutoIt do you run?
• Which version of Excel do you run?
• Can you post the workbook so we can play with it?

[DigDeep]

@water

AutoIT version: 3.3.14.5

Excel version: Excel 2016

Results.xls

[DigDeep]

@water, not to rush but just wanted to check if anything was found on the error.

Thanks again for checking.

[water]

„Unfortunately“ everything is working fine here. No errors. 
Will do some more tests. 

[water]

Sorry, I have been unable to reproduce your error.
Could you please add a COM error handler to your script so we get more detailed error information? Have a look at ObjEvent how to add such a handler.