Condition problem

[brdude]

I am creating a script to download specific files from the web. It knows wich file to download because it gets the link from a Exel spread sheet. Now the number of links is that has to download from always changes. And some times it dosent contain a link. Well here is the problem I tried to set it so that if the variable contains nothing it dosent even try to visit that site. I am a c++ coder so I tried these two codes.

If $link <> "" Then

and

If $link <> ''Then

but neither work. I have been searching the forum but no luck so far. I would apreciate it if any one wold help me with this.

Thanks

[Xenobiologist]

Hi,

doesn't look that wrong. Might show your script and / or the error?

So long,

Mega

[brdude]

There is no error but I have been checking of things and even where there is no link it still tries to visit that page.

But here is the code.

expandcollapse popup

#include <IE.au3>

Opt("WinWaitDelay",100)
Opt("WinTitleMatchMode",2)


$oIE = _IECreate ("www.specpage.com")
Sleep(5000)

WinActivate("Microsoft Excel")
WinWait("Microsoft Excel")


Send("{CTRLDOWN}c{CTRLUP}")
$name = ClipGet()
Sleep(500)


Send("{RIGHT}{CTRLDOWN}c{CTRLUP}")
$link = ClipGet()
Sleep(500)

_IENavigate ($oIE, $link)
    WinActivate("Windows Internet Explorer")
    WinWait("Windows Internet Explorer")
    Sleep(2000)
    
    MouseMove(30, 150)
    Sleep(5000)


While $name <> ""
    WinActivate("Microsoft Excel")
    WinWait("Microsoft Excel")


    if $link <>  Then
    Send("{LEFT}{DOWN}{CTRLDOWN}c{CTRLUP}")
    $name = ClipGet()
    Sleep(500)

    Send("{RIGHT}{CTRLDOWN}c{CTRLUP}")
    $link = ClipGet()
    Sleep(5000)
    
    _IENavigate ($oIE, $link)
    Sleep(5000)
    
    WinActivate("Windows Internet Explorer")
    WinWait("Windows Internet Explorer")
    Sleep(2000)
    
    MouseMove(30, 150)
    Sleep(5000)
    
    EndIf
    
    
    
WEnd

[PsaltyDS]

There is no error but I have been checking of things and even where there is no link it still tries to visit that page.

But here is the code.

CODE

#include <IE.au3>

Opt("WinWaitDelay",100)

Opt("WinTitleMatchMode",2)

$oIE = _IECreate ("www.specpage.com")

Sleep(5000)

WinActivate("Microsoft Excel")

WinWait("Microsoft Excel")

Send("{CTRLDOWN}c{CTRLUP}")

$name = ClipGet()

Sleep(500)

Send("{RIGHT}{CTRLDOWN}c{CTRLUP}")

$link = ClipGet()

Sleep(500)

_IENavigate ($oIE, $link)

WinActivate("Windows Internet Explorer")

WinWait("Windows Internet Explorer")

Sleep(2000)

MouseMove(30, 150)

Sleep(5000)

While $name <> ""

WinActivate("Microsoft Excel")

WinWait("Microsoft Excel")

if $link <> Then

Send("{LEFT}{DOWN}{CTRLDOWN}c{CTRLUP}")

$name = ClipGet()

Sleep(500)

Send("{RIGHT}{CTRLDOWN}c{CTRLUP}")

$link = ClipGet()

Sleep(5000)

_IENavigate ($oIE, $link)

Sleep(5000)

WinActivate("Windows Internet Explorer")

WinWait("Windows Internet Explorer")

Sleep(2000)

MouseMove(30, 150)

Sleep(5000)

EndIf

WEnd

This is wrong:

if $link <>  Then

Missing the second operator to compare with:

if $link <>  "" Then

That gets you "If $link is not equal to an empty string, then..." as you would expect.

Edited July 31, 2006 by PsaltyDS

[jefhal]

$link = ClipGet()
if $link <>  Then

Even if you put the "" back into the second line, are you sure that $link is really empty when you put a null clipget into it? Maybe clipget() puts some kind of character into $link even if the clip is "empty"...

Try throwing this line into your script just after you set $link to clipget():

MsgBox(0,"$link",$link)

Edited July 31, 2006 by jefhal

[/dev/null]

There is no error but I have been checking of things and even where there is no link it still tries to visit that page.

But here is the code.

#include <IE.au3>

$name = ClipGet()
Sleep(500)
Send("{RIGHT}{CTRLDOWN}c{CTRLUP}")
$link = ClipGet()
Sleep(500)

well, did you ever check what's in $name and $link after the call to ClipGet(). msgbox() is your friend.

Cheers

Kurt

[brdude]

well, did you ever check what's in $name and $link after the call to ClipGet(). msgbox() is your friend.

Cheers

Kurt

Sorry just got a chance to check it rigth now.

I added the code in and the message box comes out empty. I also checked the exel file to see if there was a space and it is empty. I also fixed the code I was messing with it and forgot to put it back sorry about that. For some reason the string comparation is not working. If it maters at all I am using the latest beta of autoit. Any thoughts on this guys?

[zfisherdrums]

Sorry just got a chance to check it rigth now.

I added the code in and the message box comes out empty. I also checked the exel file to see if there was a space and it is empty. I also fixed the code I was messing with it and forgot to put it back sorry about that. For some reason the string comparation is not working. If it maters at all I am using the latest beta of autoit. Any thoughts on this guys?

One thing I've done is to check the length of the returned string.

If the length > 0 then you have something to pass on.

If StringLen($Link) > 0 then ...

Does this help at all?

[zfisherdrums]

One last thing. I hope this isn't being presumptious,

but I've had a lot of fun (read ANGER) with using

sendkey operations between programs. They can be

finicky, you know?

I wanted to send you an example of using Excel's COM

object to make the process of retrieving the links

a little less susceptible to 'hiccups' like dialog forms,

interrupting windows, etc.

This is just an idea I had while perusing your code.