Using StringReplace

[James]

What is the proper way of using StringReplace?

Case $Replace
            $2Find =  InputBox("Replace", "What string/line would you like to replace?")
            $ReplaceWith = InputBox("Replace", "What would you like to replace " & $2Find & " with?")
            
            $text = StringReplace(GuiCtrlRead($DocEd1), $2Find, $ReplaceWith, 0, 0)
            $numreplacements = @extended
            MsgBox(0, "Replace", $numreplacements & " were made!")

It thinks it is making the replacements, and it knows its there. But it doesn't "update" $DocEd1

Secure

Edited December 29, 2006 by Secure_ICT

[Helge]

It did the replacements, but you made it so that the new text is stored in $text and not in $DocEd1.

Edited December 29, 2006 by Helge

[James]

Well I have:

Case $Replace
            $2Find =  InputBox("Replace", "What string/line would you like to replace?")
            $ReplaceWith = InputBox("Replace", "What would you like to replace " & $2Find & " with?")
            
            $DocEd1 = StringReplace(GuiCtrlRead($DocEd1), $2Find, $ReplaceWith, 0, 0)
            $numreplacements = @extended
            MsgBox(0, "Replace", $numreplacements & " were made!")

But that doesn't work either. It says it has replaced it, but nothing changes.

[GEOSoft]

What is the proper way of using StringReplace?

Case $Replace
            $2Find =  InputBox("Replace", "What string/line would you like to replace?")
            $ReplaceWith = InputBox("Replace", "What would you like to replace " & $2Find & " with?")
            
            $text = StringReplace(GuiCtrlRead($DocEd1), $2Find, $ReplaceWith, 0, 0)
            $numreplacements = @extended
            MsgBox(0, "Replace", $numreplacements & " were made!")

It thinks it is making the replacements, and it knows its there. But it doesn't "update" $DocEd1

Secure

GUICtrlSetData($DocEd1, $Text) ?

[James]

No, because that would replace the whole of $DocEd1.

[Jos]

No, because that would replace the whole of $DocEd1.

ahh you want magic ....

What else do you think you need to do ?

You read the whole text in which you replace a string with another string... logic says you need to store the whole text back into the Edit box ...

[James]

I don't get you.. What do you mean store?

[SmOke_N]

No, because that would replace the whole of $DocEd1.

Yes it would, and at the same time change the text you would want to change. You don't expect it to just change the text specific and nothing else do you? The thing I see most in your questions, and in rebuttals, is you seem to forget you are not just messing with "one" function. You have to make "everything" work.

Example:

$Main = GUICreate('Example', 250, 350)
$Edit = GUICtrlCreateEdit('This is the text I am going to change.', 10, 10, 230, 290)
$Button = GUICtrlCreateButton('Change', 100, 310, 50, 30)
GUISetState()
While 1
    Switch GUIGetMsg()
        Case -3
            Exit
        Case $Button
            $sReadEdit = GUICtrlRead($Edit)
            GUICtrlSetData($Edit, '')
            GUICtrlSetData($Edit, StringReplace($sReadEdit, 'am going to', 'did'))
    EndSwitch
WEnd

[Jos]

I don't get you.. What do you mean store?

lets return the question: How do you perceive this replace routine should work ?

Now think in a flowchart step by step process and chart that out for yourself...

Thats how you start a program ... not writing code and "see where the ship will land" ...

Edited December 29, 2006 by JdeB

[Helge]

$DocEd1 = StringReplace(GuiCtrlRead($DocEd1), $2Find, $ReplaceWith, 0, 0)

Now the new text is stored in $DocEd1, but now that you've replaced the control's ID with the text how are you

planning on working with the control again ?

No, because that would replace the whole of $DocEd1.

Well, how are you planning on using the new text then ? Use GUICtrlSetData to update the control with the updated

text, using the controlID you don't have anymore.

[James]

Thanks everyone!

I have done it.

Case $Replace
            $2Find =  InputBox("Replace", "What string/line would you like to replace?")
            $ReplaceWith = InputBox("Replace", "What would you like to replace " & $2Find & " with?")
            $sReadEdit = GUICtrlRead($DocEd1)
            GUICtrlSetData($DocEd1, '')
            $DocEd1 = GUICtrlSetData($DocEd1, StringReplace($sReadEdit, $2Find, $ReplaceWith))
            $numreplacements = @extended
            MsgBox(0, "Replace", $numreplacements & " were made!")

Thankyou SO much.

Edit: It works for the first edit. But then, when you try another edit, it doesn't work.

Edit: Well I don't know what I did, but it will replace more than one now. But it doesn't count the amount of replacments.

Edited December 29, 2006 by Secure_ICT

[Thatsgreat2345]

Why are you setting Guictrlsetdata to $DocEd1? goodness

[James]

Case $Replace
            $2Find =  InputBox("Replace", "What string/line would you like to replace?")
            $ReplaceWith = InputBox("Replace", "What would you like to replace " & $2Find & " with?")
            $sReadEdit = GUICtrlRead($DocEd1)
            
            GUICtrlSetData($DocEd1, '')
            GUICtrlSetData($DocEd1, StringReplace($sReadEdit, $2Find, $ReplaceWith))
            $numreplacements = @extended
            
            MsgBox(0, "Replace", $numreplacements & " were made!")

It replaces, but doesnt add the amount of replacments.

[Jos]

Edit: Well I don't know what I did, but it will replace more than one now. But it doesn't count the amount of replacments.

That is because @extended has the value of the last performed function which is GuiCtrlSetData()

$2Find =  InputBox("Replace", "What string/line would you like to replace?")
            $ReplaceWith = InputBox("Replace", "What would you like to replace " & $2Find & " with?")
            $sReadEdit = GUICtrlRead($DocEd1)
            $sReadEdit  = StringReplace($sReadEdit, $2Find, $ReplaceWith)
            $numreplacements = @extended
            GUICtrlSetData($DocEd1, $sReadEdit )

Edited December 29, 2006 by JdeB

[Jos]

Why are you setting Guictrlsetdata to $DocEd1? goodness

You want us to nickpick all your stuff this way ?

[Thatsgreat2345]

I really question what your trying to do because by the looks of it your making up some random string, replacing the string with a different string then setting it to a input box and seeing how many things were replaced. Well its only going to replace one every time if I'm not mistaken

[James]

Ahh right.. I didn't know that.

Thanks JdeB. And everyone.

Secure

[Thatsgreat2345]

You want us to nickpick all your stuff this way ?

Ummm no its just he's destroying his control ID when he's been told already that it would, sure if you want to nickpick my stuff since I hardly ever post questions feel free.

[James]

ThatsGreat: Its a replacement tool, for my BetaPad. Its all working now, so you don't need to worry.

Thanks once again for everyone who helped.

[Jos]

Ummm no its just he's destroying his control ID when he's been told already that it would, sure if you want to nickpick my stuff since I hardly ever post questions feel free.

sure ... and he will keep on making mistakes like this till he truly understands more about programming ...

Nothing wrong with that ... only Secure really needs to start think about the process more and stop posting every bump he hits.