FileReadLine woooos

[ScriptCrafter]

Is there a way to get FileReadLine to read the whole file line by line?

If FileReadLine ($FILE) = "[[" & $HSTS & "]]" Then

MsgBox (0, "HOST DUPLICATE ALERT", "You already are using this hostname", 1000)

This is only reading the first line of the file :-(

Any $HSTS that are further in the file are not identified as duplicate

-ScriptCrafter

[SmOke_N]

Is there a way to get FileReadLine to read the whole file line by line?

If FileReadLine ($FILE) = "[[" & $HSTS & "]]" Then

MsgBox (0, "HOST DUPLICATE ALERT", "You already are using this hostname", 1000)

This is only reading the first line of the file :-(

Any $HSTS that are further in the file are not identified as duplicate

-ScriptCrafter

Why not just use _FileReadToArray() each line will be an element in the array, and you can loop through each one and search for what you want. Edited March 15, 2007 by SmOke_N

[ScriptCrafter]

With out being so obvious about my lack of coding skills :-)

How would that look, I have a hard time with arrays.

Im sure if I get some pointers with this, I can go from there

-ScriptCrafter

[SmOke_N]

Look at the example of _FileReadToArray() in the help file, replace the MsgBox() in the For/Next loop with a conditional If/Then statement with StringInStr() then put whatever conditions in there you want to apply. Try something out, if it's failing... post your honest attempt... most of us can tell when you are really trying ... and are more than willing to give you hand from that point.

[james3mg]

Have you tried this type of script:

$FileToRead=FileOpen("foo.txt",0)
While 1
  $CurrentLine=FileReadLine($FileToRead)
  If @error Then ExitLoop
  If $CurrentLine = "[[" & $HSTS & "]]" Then
    MsgBox (0, "HOST DUPLICATE ALERT", "You already are using this hostname", 1000)
    ;exitloop here if you want to stop reading the file when it finds a duplicate hostname
  EndIf
WEnd
FileClose($FileToRead)
MsgBox(0,"Done","Done searching")

?

It looks like from the scrap you posted that this is what you're going for, but I can't tell if your $file variable holds a filename (which will cause it to only read the first line) or a file HANDLE created by a call to FileOpen().

SmOke's solution will probably be faster, but if this is your only problem, you can use your existing script by only adding a FileOpen() line.

Edit: Forgot to FileClose() in my snippet

Edited March 15, 2007 by james3mg

[ScriptCrafter]

DIM $LINES

$HSTS = GUICtrlRead ($HSTBOX)

$RAMS = GuiCtrlRead ($RAMBOX)

$IPCB = GUICtrlRead ($IPCBOX)

$IOSB = GUICtrlRead ($IOSBOX)

$WHOLEFILE = FileRead($FILE)

If $FILE = -1 Then

MsgBox(0, "Error", "Unable to open file.")

Exit

EndIf

_FileReadToArray ($FILE, $LINES)

For $i = 1 To $LINES[0]

If StringInStr ($LINES, "[[" & $HSTS & "]]") Then

MsgBox (0, "HOST DUPLICATE ALERT", "You already are using this hostname", 1000)

EndIF

Next

This doesnt seem to be working.

Also appears to be looping the file

[SmOke_N]

DIM $LINES

$HSTS = GUICtrlRead ($HSTBOX)

$RAMS = GuiCtrlRead ($RAMBOX)

$IPCB = GUICtrlRead ($IPCBOX)

$IOSB = GUICtrlRead ($IOSBOX)

$WHOLEFILE = FileRead($FILE)

If $FILE = -1 Then

MsgBox(0, "Error", "Unable to open file.")

Exit

EndIf

_FileReadToArray ($FILE, $LINES)

For $i = 1 To $LINES[0]

If StringInStr ($LINES, "[[" & $HSTS & "]]") Then

MsgBox (0, "HOST DUPLICATE ALERT", "You already are using this hostname", 1000)

EndIF

Next

This doesnt seem to be working.

Also appears to be looping the file

$File has to be the literal path... don't use FileOpen (remove that).

Edit:

Wait, that confused me

Can you upload a test text file?

Edited March 15, 2007 by SmOke_N

[SpookMeister]

DIM $LINES

$HSTS = GUICtrlRead ($HSTBOX)

$RAMS = GuiCtrlRead ($RAMBOX)

$IPCB = GUICtrlRead ($IPCBOX)

$IOSB = GUICtrlRead ($IOSBOX)

$WHOLEFILE = FileRead($FILE)

If $FILE = -1 Then

MsgBox(0, "Error", "Unable to open file.")

Exit

EndIf

_FileReadToArray ($FILE, $LINES)

For $i = 1 To $LINES[0]

If StringInStr ($LINES, "[[" & $HSTS & "]]") Then

MsgBox (0, "HOST DUPLICATE ALERT", "You already are using this hostname", 1000)

EndIF

Next

This doesnt seem to be working.

Also appears to be looping the file

Is this your whole script? Where are you telling it what $FILE is?

Posting snippets of much larger code wont get you good answers. I recommend either posting the whole script, or making a small example script showing your issue. The example for _FileReadToArray() in the help file should give you a good starting point.

[ScriptCrafter]

Func BUILD ()

DIM $LINES

If $FILE = -1 Then

MsgBox(0, "Error", "Unable to open file.")

Exit

EndIf

_FileReadToArray ($FILE, $LINES)

For $i = 1 To $LINES[0]

If StringInStr ($LINES, "[[" & $HSTS & "]]") Then

MsgBox (0, "HOST DUPLICATE ALERT", "You already are using this hostname", 1000)

Else

FileWriteLine ($FILE, "[[" & $HSTS & "]]")

EndIf

Next

EndFunc

This is the function

If the hostname exists in the file, dont allow for it to be written.

If the hostname doesnt exist in the file, then allow it to be written.

For those questioning $FILE

$FILE = C:/LOCATIONOFMYFILE

-ScriptCrafter

[SmOke_N]

Func BUILD ()

DIM $LINES

If $FILE = -1 Then

MsgBox(0, "Error", "Unable to open file.")

Exit

EndIf

_FileReadToArray ($FILE, $LINES)

For $i = 1 To $LINES[0]

If StringInStr ($LINES, "[[" & $HSTS & "]]") Then

MsgBox (0, "HOST DUPLICATE ALERT", "You already are using this hostname", 1000)

Else

FileWriteLine ($FILE, "[[" & $HSTS & "]]")

EndIf

Next

EndFunc

This is the function

If the hostname exists in the file, dont allow for it to be written.

If the hostname doesnt exist in the file, then allow it to be written.

For those questioning $FILE

$FILE = C:/LOCATIONOFMYFILE

-ScriptCrafter

And the file I requested?

[SadBunny]

Am I missing something here or isn't it obvious that the error is in:

If StringInStr ($LINES, "[[" & $HSTS & "]]") Then

You will need four extra characters in this line, which are: [$i] (not necessarily in that order ) and come right after $LINES ? Or am I spoiling a delicate psychological experiment?

[SmOke_N]

Am I missing something here or isn't it obvious that the error is in:

If StringInStr ($LINES, "[[" & $HSTS & "]]") Then

You will need four extra characters in this line, which are: [$i] (not necessarily in that order ) and come right after $LINES ? Or am I spoiling a delicate psychological experiment?

You're not missing it... I just wasn't going to answer unless more information was given... I find if someone provides all the information to help them they get up and running fully in a matter of moments rather than hours/days of the cloak and dagger approach... so I just sit back until they get fed up, or someone else chimes in and gives them all the answers with a lower expectation percentage of the information or work expected.

[ScriptCrafter]

I really thank you guys, especially you Smoke N for the help.

I gave just about all the information that was needed, other then the button that loads that function.

I was able to get through it with the _FileReadToArray Help file, and some of the pointers you gave. I can agree to the not just blindly handing out answers and pointing folks in the right direction approach.

Thanks Again!

-ScriptCrafter