Filecountlines gives negative number

[leuce]

G'day everyone

Here's my script:

#include <File.au3>
$wftm = FileOpenDialog ("Select file", "", "Files (*.txt)")
$wftmfile = FileOpen ($wftm, 0)
$wflines = _FileCountLines ($wftm)
MsgBox (0, "foo", $wflines)

The actual number of lines in the file is about 6000. AutoIt tells me the number is -1260943. If I resave the text file from a text editor and give it a different name, the number of lines reported by AutoIt also changes.

The file is a plain text file created in Windows. What can be wrong?

The script detects the number of lines of other files correctly.

Thanks

Samuel

[leuce]

G'day everyone

Okay, I licked it. The file I was trying to open, was in fact Unicode (little endian). Now... is it at all possible to make my script work on such a file?

Thanks

Samuel

[MrCreatoR]

Hi,

This is hard to say, If you can, upload the file that have this problem.

Or try this method to count lines (it's work for me every time):

$wftm = FileOpenDialog ("Select file", "", "Files (*.txt)")
$wftmfile = FileOpen ($wftm, 0)
$wflines = _CountLinsInFile($wftm)
MsgBox (0, "foo", $wflines)


Func _CountLinsInFile($File)
    If Not FileExists($File) Or StringInStr(FileGetAttrib($File), "D") Then Return SetError(1, 0, 0)
    StringReplace(FileRead($File), @LF, "")
    Return @extended+1
EndFunc

Edited March 31, 2007 by MsCreatoR

[JailDoctor]

Or try this method to count lines (it's work for me every time):

$wftm = FileOpenDialog ("Select file", "", "Files (*.txt)")
$wftmfile = FileOpen ($wftm, 0)
$wflines = _CountLinsInFile($wftm)
MsgBox (0, "foo", $wflines)


Func _CountLinsInFile($File)
    If Not FileExists($File) Or StringInStr(FileGetAttrib($File), "D") Then Return SetError(1, 0, 0)
    StringReplace(FileRead($File), @LF, "")
    Return @extended+1
EndFunc

I tried this to solve a similar problem with your code and it didn't help.

I create a txt file with an array from and excel sheet. They are sets of numbers, and usually are 2 to 200 or so. To be open to growth, I specify a top of 493 rows by the line: $XLArray = _ExcelReadArray($oExcel, 1, 1, 493, 1)

Only the occupied cells should be placed in the txt file by: _FileWriteFromArray($sFile, $XLArray, 0)

When I want to read the number of lines in the text file by $CountLines = _FileCountLines(@DesktopDir & "\My Test List.txt")

I get 493 instead of 10 or whatever number is in the file.

How can I solve this problem?

Here is my code:

CODE

include <file.au3>

#include <ExcelCOM_UDF.au3>

Global $XLFilePath = @DesktopDir & "\uh_patsumlc_MRNOnly.xls"

Global $oExcel, $XLArray

$oExcel = _ExcelBookOpen($XLFilePath, @SW_HIDE)

$XLArray = _ExcelReadArray($oExcel, 1, 1, 493, 1) ;here is where I determine how many rows to read Row 1, Column A, 493 rows, and direction down)

_ExcelBookClose($oExcel)

$sFile = @TempDir & "\My Test List.txt"

; Write first array to file by string file name

_FileWriteFromArray($sFile, $XLArray, 0)

$CountLines = _FileCountLines(@DesktopDir & "\My Test List.txt")

;your code:

$wftm = FileOpenDialog ("Select file", "", "Files (*.txt)")

$wftmfile = FileOpen ($wftm, 0)

$wflines = _CountLinsInFile($wftm)

MsgBox (0, "foo", $wflines)

Func _CountLinsInFile($File)

If Not FileExists($File) Or StringInStr(FileGetAttrib($File), "D") Then Return SetError(1, 0, 0)

StringReplace(FileRead($File), @LF, "")

Return @extended+1

EndFunc

Exit

[rolok]

It may also be a data issue.

I've attached a .csv file that has data in it that will cause the function to return a negative number.

If you view the file within a text editor like the wonderful ScitTe editor, you can easily see the offending data.

RowCountBreaker.txt

Edited June 3, 2008 by rolok

[Kerros]

@rolok

Just looking at the file, there are Null characters in there. Most languages are going to see a null and assume that it's the end of the line and/or file.

Using your file I get 1 line, but not a negative number using this code.

#include<file.au3>
$File1 = @ScriptDir&'\RowCountBreaker.txt'
$wftmfile = FileOpen ($File1, 0)
$wflines = _CountLinsInFile($File1)
MsgBox (0, "foo", $wflines)


Func _CountLinsInFile($File)
    If Not FileExists($File) Or StringInStr(FileGetAttrib($File), "D") Then Return SetError(1, 0, 0)
    StringReplace(FileRead($File), @LF, "")
    Return @extended+1
EndFunc

[ProgAndy]

It's Unicode, why this doesn't work:

; File.au3, Tylo <tylo at start dot no>
Func _FileCountLines($sFilePath)
    Local $N = FileGetSize($sFilePath) - 1
    If @error Or $N = -1 Then Return 0
    Return StringLen(StringAddCR(FileRead($sFilePath, $N))) - $N + 1
EndFunc ;==>_FileCountLines

The problem is, that one WChar has 2 bytes, not 1 as in ASCII, so You get the wrong count. (FileGetSize and StringLen don't return the same, then.)

MrCreatoR's method works with your RowCountBreaker.txt, too

Edited June 3, 2008 by ProgAndy