Won't delete files

[qazwsx]

Im going to use this script to clean up space on my comp.

$path = @ScriptDir
MsgBox (0, "", $path)
$search = FileFindFirstFile ("*.*")

While 1
$file = FileFindNextFile ($search)
If @error Then ExitLoop
MsgBox (0, "", $file)
$efile = StringTrimLeft ($file, StringInStr ($file, ".", 0, -1))
MsgBox (0, "", $efile)
MsgBox (0, "", $file)
If Not $efile = "mp3" Then
    FileDelete ($path & "\" & $file)
    MsgBox (0, "", "delete")
Endif
    

WEnd


FileClose ($search)

But the files never delete because it never goes to the if not.

[xcal]

Start with FileDelete('c:\actual\path\file.ext') and work backwards from there, adding in the If etc.

[cyanidemonkey]

It looks like you are deleting non mp3 files.

Have a look at this, it may help you out: http://www.autoitscript.com/forum/index.php?showtopic=49320

Mind you it will remove all non mp3 file, but you might be able to use a bit of the code to do what you require.

Try this for your delete bit of code:

If StringRight(StringLower($file), 4) <> ".mp3" Then
      FileDelete ($file)
EndIf

If you want to just move to recyce bin then use FileRecycle($file) instead of FileDelete ($file), that way you can check the recycle bin and restore the file if you wanna keep it.

Edited July 23, 2007 by cyanidemonkey

[MHz]

If you want to just move to recyce bin then use FileRecycle($file) instead of FileDelete ($file), that way you can check the recycle bin and restore the file if you wanna keep it.

FileRecycle() does not work on Volumes as they have no recycle bin. I would suggest a Edit control of files found to inspect before deletion but the Edit control has a amount of characters limitation so hopefully will not exceed the limitation.

[Confuzzled]

Why write code for something that can be accomplished by using common Windows procedures?

Search for "*.*" on the root directory of the volume you wish to clean up. Sort by file extension by clicking on the 'type' column. Click on the first non-MP3 file, hold down the shift key and go down to the last file that is not a MP3 file and click on that to select all files between. Press the delete key and OK - voila!

[cyanidemonkey]

Why write code for something that can be accomplished by using common Windows procedures?

Search for "*.*" on the root directory of the volume you wish to clean up. Sort by file extension by clicking on the 'type' column. Click on the first non-MP3 file, hold down the shift key and go down to the last file that is not a MP3 file and click on that to select all files between. Press the delete key and OK - voila!

Because sometimes your dealing with a shit load of files within a shit load of folders. I recently wrote a simluar script to sccrstvn93 to clean up 100gb+ of music files/folders. The method you suggest is of course the option to take if there is not alot of stuff to clean, but for large amounts of data why do it manually when you can write a script to do it for you?

[mikehunt114]

1 mb to be removed = 2 seconds to highlight and delete

100 gigs = 15 seconds (generous) to highlight/scroll down and delete

Nonetheless, I myself, enjoy automating tasks, even if it isn't really worth the effort