Loop trouble

[lgnihlman]

I have trouble getting my script right, the problem is that when $log is set to 1 the script writes to the logfile and does the shutdown (works OK)

but it will write to the logfile several times until the system has gone down.

I would need a way to make sure the logfile is written to only once before shutdown but I can't figure out how to do it.

Any help is appreciated, thanks

CODE

While 1

Sleep(1000)

$n = _GetLastInput()

If $n > $time Then

If $log=1 Then

;Write to logfile

$file = FileOpen(@ProgramFilesDir & "\Inact\inactlog.txt", 9)

FileWrite($file, @YEAR)

FileWrite($file, "-")

FileWrite($file, @MON)

FileWrite($file, "-")

FileWrite($file, @MDAY)

FileWrite($file, " ")

FileWrite($file, @HOUR)

FileWrite($file, ":")

FileWrite($file, @MIN)

FileWrite($file, "")

FileWrite($file, " action=")

FileWrite($file, $action)

FileWrite($file, @CRLF)

FileClose($file)

EndIf

Shutdown(5)

Else

EndIf

WEnd

[Jos]

What about just doing:

Shutdown(5)
        Exit

[PsaltyDS]

I have trouble getting my script right, the problem is that when $log is set to 1 the script writes to the logfile and does the shutdown (works OK)

but it will write to the logfile several times until the system has gone down.

I would need a way to make sure the logfile is written to only once before shutdown but I can't figure out how to do it.

Any help is appreciated, thanks

There is nothing in the Else portion of the IF statement, so I removed it, and _FileWriteLog() does everything for you, including the time stamp, so I substituted that in.

There should be no way for the shutdown not to happen after writing to the log unless you don't have permission in Windows to shut the machine down, so I put in an error check on the Shutdown:

#include <file.au3>

While 1
    Sleep(1000)
    $n = _GetLastInput ()
    If $n > $time Then
        If $log = 1 Then
            ;Write to logfile
            _FileWriteLog(@ProgramFilesDir & "\Inact\inactlog.txt", "Action=" & $action)
        EndIf
        
        If Not Shutdown(5) Then ; 5 = force shutdown
            MsgBox(16, "Error", "Failed to shutdown computer on command!")
        EndIf   
        Exit
    EndIf
WEnd

Edited October 17, 2007 by PsaltyDS

[lgnihlman]

Thanx for your suggestions !

I modified the code to use _FileWriteLog and removed the Else statemant but the result is the same, the logfile is written 28 times until the actual shutdown action is completed.

I run my compiled script as a service and the shutdown action can be either logoff or power off and because it runs as a service I think there will be

problems if I simply put an Exit command after the Shutdown command.

Could it be that I need to exit the While loop when $n > $time is true and then write the logfile an perform the shutdown action ?

If thats the way to do it how would I do that and how do I then get back to the loop again after writing log file and doing a logoff ?

[PsaltyDS]

Thanx for your suggestions !

I modified the code to use _FileWriteLog and removed the Else statemant but the result is the same, the logfile is written 28 times until the actual shutdown action is completed.

I run my compiled script as a service and the shutdown action can be either logoff or power off and because it runs as a service I think there will be

problems if I simply put an Exit command after the Shutdown command.

Could it be that I need to exit the While loop when $n > $time is true and then write the logfile an perform the shutdown action ?

If thats the way to do it how would I do that and how do I then get back to the loop again after writing log file and doing a logoff ?

Shutdown does not exit the script, so the loop keeps running until the process is closed (which may take a while). Did you notice the 'Exit' I put right after the Shutdown, and the MsgBox to indicate if you don't have permission to do that?