Can't Open File

[sness]

Hello everyone.

I keep getting the "Can't open file" message. Funny thing, the filemove operation right before it works fine. I thought the FileOpen command is supposed to create the file. Any ideas why I would be having this problem?? It's probably easy, but I can't seem to figure out why....

Thanks for any pointers you may have to offer this green horn.

Sue

CODE:

$Appfile = $App & ".txt"

If FileExists($Appfile) Then

If $RNorOW = "RN" Then

$details = FileGetTime($Appfile)

$newfilename = string($details[0]) & string($details[1]) & string($details[2]) & string($details[3]) & string($details[4]) & string($details[5])

$newfilename = $app & $newfilename & ".txt"

filemove($appfile, $newfilename,1)

Else

$newfilename = $app & "old.txt"

Filemove($appfile, $newfilename,1)

EndIf

EndIf

;====================================================================Here

$file = FileOpen($AppFile, 1)

; Check if file opened for reading OK =======================ERROR HERE ??

If $file = -1 Then

MsgBox(0, "Error", "Unable to open file. " & $appfile)

Exit

EndIf

END OF CODE

[weaponx]

Is it just me or does the logic not make sense?

You have:

$Appfile = $App & ".txt"

If FileExists($Appfile) Then

...

filemove($appfile, $newfilename,1)

Else

...

filemove($appfile, $newfilename,1)

EndIf

How can it move a file that doesn't exist?

[sness]

Is it just me or does the logic not make sense?

You have:

$Appfile = $App & ".txt"

If FileExists($Appfile) Then

...

filemove($appfile, $newfilename,1)

Else

...

filemove($appfile, $newfilename,1)

EndIf

How can it move a file that doesn't exist?

What is happening here is that IF the file $Appfile already exisits, it is either renamed with the date and time added to the name OR with the word old added to the name (depends on the value of the variable $RNorOW). If the file does NOT already exist, then none of the renaming part takes place. Either way, when it gets to the FileOpen command, the $Appfile would not exist (as it didn't already exist or was renamed). The rename part is working OK both ways.

Just for fun, I commented out the rename routine and changed the 1 to a 2 (for clear and re-write). Still can't open the file (??).

Thanks

Sue

Edited December 21, 2007 by sness

[SpookMeister]

Is it perhaps a case of attempting to open $appfile after it has just renamed it to $newfilename?

[sness]

Hmm I thought AutoIt would create a new file for me if there wasn't one already. I rebooted, thinking maybe the file is already open in the background and can't be open again. Everything worked until I added a GUI to collect some of the variables up front and that's when started getting this message. I will take it all home and review the variables and various "open" "close" etc. Thanks everybody for the suggestions - If I figure it out, will update this post with my findings.

[DW1]

FileOpen create a file? no

FileWrite create a file? yes

[weaponx]

FileOpen ( "filename", mode )

Remarks

A file can only be in either read or write mode; it cannot be in both.

When opening a file in write mode, the file will be created if it does not exist.

BTW - I still stand by my previous post. You are trying to move a file that doesn't exist.

[DW1]

@WeaponX, yes, I stand by that post as well.... there is no logic in trying to move a file that you have just proven does not exist.

@sness, what are you trying to accomplish there?

[The Kandie Man]

You said you wanted to open the file for reading? You were opening the file for writing. You were also opening the old filename, not the new one. The following opens the file in its new location for reading:

$Appfile = $App & ".txt"
If FileExists($Appfile) Then
    If $RNorOW = "RN" Then
        $details = FileGetTime($Appfile)
        $newfilename = String($details[0]) & String($details[1]) & String($details[2]) & String($details[3]) & String($details[4]) & String($details[5])
        $newfilename = $App & $newfilename & ".txt"
        FileMove($Appfile, $newfilename, 1)
    Else
        $newfilename = $App & "old.txt"
        FileMove($Appfile, $newfilename, 1)
    EndIf
EndIf
;~ ;====================================================================Here
$file = FileOpen($newfilename, 0);Use parameter 0 for reading.  1 appends to already existing file and 2 erases existing one and opens it for writing.
; Check if file opened for reading OK =======================ERROR HERE ??
If $file = -1 Then
    MsgBox(0, "Error", "Unable to open file. " & $newfilename)
    Exit
EndIf

I hope that is what you were looking for.

- The Kandie Man ;-)

EDIT: Fixed msgbox file name

Edited December 22, 2007 by The Kandie Man

[sness]

Thank you everyone for your help on this. This one was tricky. The reason the file could not be opened is that it was already opened. The script worked great until I added a GUI to the top of it. When I did this, I wanted the contents of the file to show in an edit box and since that is within a loop, then it was perpetually open. I had to create a secondary GUI to show the content of the file so I could first write to it. Thanks again for all of your help.

[weaponx]

Just make sure you put FileClose($filename) at the end of your script...