Two values comparison

[546f6d6173]

Hi all.

I heave question.

Why do not working this comparison of two values ?

It compare correct only first two position of numbers.

Try to write for example 100 and 50.

Where is the problem??

Sorry for my english.

Many thanks.

CODE

#include <GUIConstants.au3>

GuiCreate("Compare two values", 280, 200, 200, 200)

$val1 = GUICtrlCreateInput ( "", 20, 110, 50, 20)

$name1 = GUICtrlCreateLabel("First value", 75, 115, 60, 20)

$val2 = GUICtrlCreateInput ( "", 20, 130, 50, 20 )

$name2 = GUICtrlCreateLabel("second value", 75, 135, 80, 20)

$okbt = GUICtrlCreateButton("OK", 170, 130, 60, 20)

GUISetState()

Do

$msg = GUIGetMsg()

if $msg = $okbt Then

$v1 = GUICtrlRead($val1)

$v2 = GUICtrlRead($val2)

MsgBox(0,"Info","First value is: " & $v1)

MsgBox(0,"Info","Second value is: " & $v2)

;----------------------

if $val1 > $val2 Then

MsgBox(0,"Info","First value is GREATER than second")

ExitLoop

Else

MsgBox(0,"info","First value is SMALLER than second")

EndIf

;---------------------

ExitLoop

EndIf

Until $msg = $GUI_EVENT_CLOSE

[GEOSoft]

Hi all.

I heave question.

Why do not working this comparison of two values ?

It compare correct only first two position of numbers.

Try to write for example 100 and 50.

Where is the problem??

Sorry for my english.

Many thanks.

CODE

#include <GUIConstants.au3>

GuiCreate("Compare two values", 280, 200, 200, 200)

$val1 = GUICtrlCreateInput ( "", 20, 110, 50, 20)

$name1 = GUICtrlCreateLabel("First value", 75, 115, 60, 20)

$val2 = GUICtrlCreateInput ( "", 20, 130, 50, 20 )

$name2 = GUICtrlCreateLabel("second value", 75, 135, 80, 20)

$okbt = GUICtrlCreateButton("OK", 170, 130, 60, 20)

GUISetState()

Do

$msg = GUIGetMsg()

if $msg = $okbt Then

$v1 = GUICtrlRead($val1)

$v2 = GUICtrlRead($val2)

MsgBox(0,"Info","First value is: " & $v1)

MsgBox(0,"Info","Second value is: " & $v2)

;----------------------

if $val1 > $val2 Then

MsgBox(0,"Info","First value is GREATER than second")

ExitLoop

Else

MsgBox(0,"info","First value is SMALLER than second")

EndIf

;---------------------

ExitLoop

EndIf

Until $msg = $GUI_EVENT_CLOSE

if $v1 > $v2 Then
MsgBox(0,"Info","First value is GREATER than second")
ExitLoop
Else
MsgBox(0,"info","First value is SMALLER than second") 
EndIf 
;---------------------
ExitLoop
EndIf

[martin]

Hi all.

I heave question.

Why do not working this comparison of two values ?

It compare correct only first two position of numbers.

Try to write for example 100 and 50.

Where is the problem??

Sorry for my english.

Many thanks.

CODE

#include <GUIConstants.au3>

GuiCreate("Compare two values", 280, 200, 200, 200)

$val1 = GUICtrlCreateInput ( "", 20, 110, 50, 20)

$name1 = GUICtrlCreateLabel("First value", 75, 115, 60, 20)

$val2 = GUICtrlCreateInput ( "", 20, 130, 50, 20 )

$name2 = GUICtrlCreateLabel("second value", 75, 135, 80, 20)

$okbt = GUICtrlCreateButton("OK", 170, 130, 60, 20)

GUISetState()

Do

$msg = GUIGetMsg()

if $msg = $okbt Then

$v1 = GUICtrlRead($val1)

$v2 = GUICtrlRead($val2)

MsgBox(0,"Info","First value is: " & $v1)

MsgBox(0,"Info","Second value is: " & $v2)

;----------------------

if $val1 > $val2 Then

MsgBox(0,"Info","First value is GREATER than second")

ExitLoop

Else

MsgBox(0,"info","First value is SMALLER than second")

EndIf

;---------------------

ExitLoop

EndIf

Until $msg = $GUI_EVENT_CLOSE

GuiCtrlRead returns a string, so you need a number so use

$val = Number(GuiCtrlRead(...))

Also, a small error in your logic, the values could be equal so

Else
                        MsgBox(0,"info","First value is NOT LARGER than second")

[FreeRider]

Hello

If you want to compare values... be sure to compare numbers... and compare the values but not the controls (you use $val1 and $val2 instead of $v1 and $v2)

With your script modified (see below) it works :

#include <GUIConstants.au3>

GuiCreate("Compare two values", 280, 200, 200, 200)

$val1 = GUICtrlCreateInput ( "", 20, 110, 50, 20)

$name1 = GUICtrlCreateLabel("First value", 75, 115, 60, 20)

$val2 = GUICtrlCreateInput ( "", 20, 130, 50, 20 )

$name2 = GUICtrlCreateLabel("second value", 75, 135, 80, 20)

$okbt = GUICtrlCreateButton("OK", 170, 130, 60, 20)

GUISetState()

Do

$msg = GUIGetMsg()

if $msg = $okbt Then

$v1 = Number(GUICtrlRead($val1))

$v2 = Number(GUICtrlRead($val2))

MsgBox(0,"Info","First value is: " & $v1)

MsgBox(0,"Info","Second value is: " & $v2)

;----------------------

if $v1 > $v2 Then

MsgBox(0,"Info","First value is GREATER than second")

ExitLoop

ElseIf $v1 < $v2 Then

MsgBox(0,"info","First value is SMALLER than second")

ElseIf $v1 = $v2 Then

MsgBox(0,"info","First value is EQUAL to second")

EndIf

;---------------------

ExitLoop

EndIf

Until $msg = $GUI_EVENT_CLOSE

Bye...

[546f6d6173]

Oh my.. I was really used $val1 and $val2 instead of $v1 and $v2. Of course...

But the main problem was here: Number(GUICtrlRead($val1)).

Now it's working fine!

Many thanks for all !

Bye.

[GEOSoft]

Oh my.. I was really used $val1 and $val2 instead of $v1 and $v2. Of course...

But the main problem was here: Number(GUICtrlRead($val1)).

Now it's working fine!

Many thanks for all !

Bye.

That of course was the best solution. You could however also use

If Number($v1) > Number($v2) Then

Edit: If the inputs should only except numbers then use $ES_NUMBER (0x2000) in the style. or at least do a check with

If IsNumber()

Edited March 2, 2008 by GEOSoft

[FreeRider]

No problem my friend... I had exactly the same problem in the past and it took me time to realize that I was using text instead of numbers...

And regarding the wrong variable usage.... don't worry I continue to sometime make errors due to this.

[JWille]

I am having a similar problem but I am wanting to read the text from the control.

The text I am wanting to read is formatted like so: "10/10". I keep getting "1" as the return value when I want the actual text "10/10"

Any help much appreciated!

Never mind.

Figured out my typo...

One of those days!!

Edited March 4, 2008 by JWille