Breaking a loop correctly

[AIS]

What would be the best way to break out of a loop? I currently have a Do Until. While that works, I know in the future it will hang because a description has changed so it will run forever. Can I put a time limit on it? I've tried a While and using For..Next. Problem here is, I use an If Winexists then and do my next processing. When it returns, it continues with the send until it reached the max which causes issues. Here is a portion of the script. Thanks for any advice you may give.

; This script will read the account number from a file

; and assign the collector code via the Collection Utility MPF Mass Perm Assign/Unassign .

;

;

; ===================================================================================================

$INFILE=fileopen("c:\temp\Collector.txt",0)

initialsetup ( )

getvariables ( )

processfile ( )

endprocess ( )

Func initialsetup ( )

$readcounter = 1

readinputfile ( )

getvariables ( )

$GUI = 'C:\Program Files\Quadramed\Affinity\G_M5\AffinityGUI.exe /inifile=c:\program files\QuadraMed\Affinity\G_M5\AISParm.ini'

Run ( $GUI )

WinActivate ( 'Destination' )

WinWaitActive ( 'Destination' )

Func processfile ( )

WinActivate ( 'Affinity [dcopy]' )

WinWaitActive ( 'Affinity [dcopy]' )

; for $__n1_ = 0 to 0 step 0

Send ( '{ENTER}' )

Sleep ( 400 )

coll1 ( )

coll2 ( )

coll3 ( )

coll4 ( )

coll5 ( )

coll6 ( )

coll7 ( )

coll8 ( )

coll9 ( )

coll10 ( )

coll11 ( )

coll12 ( )

coll13 ( )

coll14 ( )

coll15 ( )

; coll16 ( )

EndFunc ; processfile ( )

Func coll1 ( )

;ORI

WinActivate ( 'MPF Mass Perm' )

WinWaitActive ( 'MPF Mass Perm' )

Sleep ( 500 )

$INLINE=FILEREADLINE($INFILE,1)

$FILE=STRINGLEFT($INLINE,31)

Sleep ( 500 )

Send ( $FILE & @YEAR & @MON & @MDAY, 1 )

Sleep ( 300 )

Send ( '{ENTER}' )

WinWaitActive ( 'Collector /' )

Do

Send ( 'O' )

Until WinExists ("Collector / Perm Flag ", "OUTSOURCE RCS INS")

Sleep ( 400 )

Send ( '{TAB}' )

Sleep ( 200 )

Send ( '{Space}' )

Sleep ( 200 )

Send ( '{TAB}' )

Sleep ( 200 )

Send ( '{Enter}' )

Sleep ( 500 )

WinWaitActive ( 'Affinity' )

WinActivate ( 'CollectorUtilDone' )

WinWaitActive ( 'CollectorUtilDone' )

$INLINE=FILEREADLINE($INFILE,1)

$FILE=STRINGLEFT($INLINE,31)

Send ( $FILE & @YEAR & @MON & @MDAY, 1 )

Send ( '{ENTER}' )

Return

EndFunc ; coll1

Each coll function does the same basic sends.

Func errorwindow ( )

$__msgbox = MsgBox ( 0, 'AutoIt', 'Expected Window not there!' )

Exit

EndFunc ; errorwindow

Return

Func readinputfile ( )

$INLINE=FILEREADLINE($INFILE)

$FILE=STRINGLEFT($INLINE,31)

; if $eofindicator = EOF then

; endprocess ( )

; endif

Return

EndFunc ; readinputfile

Func getvariables ( )

$INLINE=FILEREADLINE($INFILE)

$FILE=STRINGLEFT($INLINE,31)

; $readcounter = $readcounter + 1

Return

EndFunc ; getvariables

Func endprocess ( )

WinActivate ( 'CollectorUtilDone' )

WinWaitActive ( 'CollectorUtilDone' )

Send ( '^s' )

Sleep ( 500 )

WinClose ( 'CollectorUtilDone' )

WinWaitClose ( 'CollectorUtilDone' )

FileCopy ( 'c:\temp\CollectorUtilDone.txt', 'c:\temp\CollectorUtilDone.' & @YEAR & @MON & @MDAY & '.txt', 1 )

WinActivate ( 'Affinity' )

WinWaitActive ( 'Affinity' )

Send ( '{ALT}F' )

Sleep ( 500 )

Send ( 'x' )

Sleep ( 300 )

Send ( '{ENTER}' )

Exit

EndFunc ; endprocess

fileclose($INFILE)

Return

[Community On Patrol]

Hi AIS,

1st Welcome to the AutoIt Forums!

Some of the following tips may not apply to you, but it may make your life a bit easier here on the forum in the future.

CODE

• Did you know that we have an awesome search feature?

  You can find many answers to your current questions, just by typing in the right search patterns.

• A suggestion is to use the Advanced Search mode:

• Type your specific search term in quotes.
• Click the forum you want to search in (the one most likely to have your information would generally be the Example Script forum and or the General Help and Support Forum).
• Click on "Search titles only" radio button.
• Click perform search.

The above will help you narrow down your searches and prevent you from unneccesarily posting a new thread.

[*]Also, you should try to read the Sticky posts that are at the top of each of the AutoIt Forums you enter such as:

• FAQs (Frequently Asked Questions)

• Are my AutoIt EXEs really infected? (About false positives and what to do if you may encounter one)

[*]Keep in mind, the help file will be your best friend, however you may find some of the tutorials written by some of our elite forum members helpful.

• Valuaters Interactive AutoIt 1-2-3 tutorial

• LxPs Learning to script with AutoIt3

[*]Forum Etiquette:

• Making a new thread:
  • Use the Search feature first to see if your question has already been answered.
  • Look in the help file as well before even thinking of posting (When what you want could be obtained by simply reading the help file, you don't generally get a good response from your AutoIt community).
  • Titles are very important here. 1 word titles or titles like "help me", "write something for me", "I'm a noob" etc... aren't tolerated.
  • Make sure you are posting in the correct forum:
    • General Help and Support:
      • This forum is for AutoIt related support questions only. If you have a question related to another language, or nothing at all to do with AutoIt then you need to post in the chat forum, or in that languages perspective forum.
    • Example Script:
      • This forum is for AutoIt scripts/executables only.
      • Source code is preferred but not necessary, you do have the right to just post the binary of your project if you wish.
      • Please don't post questions in this forum unless it's directly related to a thread already existing.
  • Use common sense when creating a new thread.

    Ask yourself if the title is descriptive enough to even interest someone (preferably those that know what they are talking about) to even look at your thread, let alone reply in it.

  • Think about how it would show in the search feature if someone were to look for something just like you are looking for (think of the keywords you used yourself and obviously didn't find anything (because we know you used the search feature ) and use those types of keywords in your title as well).
• Thread content:
  • Be descriptive with your query. (Make sure we actually know what you want to do).
  • Show you've made an effort in coding what you want (provide the reproducer code (generally no more than 50 lines as people lose interest in debugging someones script for free)).
  • Don't talk in ebonics. A lot of the forum members are adults, and a lot of them know how to help you, but talk like a child, you'll be treated as such.
  • Don't ask for help making keyloggers, spam (even if it's to do as a prank), or anything that can be thought of as malicious. You'll more than likely have the thread locked by a moderator, and take a bashing from your fellow AutoIt community.
  • When posting code, use code boxes. This can be accomplished by using [code ]<content here>[/code ] (No spaces between the brackets []).

    Using code boxes will keep the indentation and make it easier to read for others to help you.

• Bumping your threads:
  • Use common courtesy here.

    Keep in mind every time you bump your thread to the top of the forum, you knock the other threads down a notch.

    Everyone posting for help has just as much right for their threads to get read as you do.

    Because of that, do not bump your post more than once in a 24 hour period.

    A Bump is simply posting in your thread with nothing that pertains to your query with the sole purpose of moving it up.

    Deleting previous bumps, and posting new ones is not tolerated, and the moderators can find those deletions, so do yourself a favor and don't cross that line >_< .

• Rude or obnoxious content:

  This falls pretty much under the common sense thing. If you use it (common sense) before posting, you won't have issues.

  • Don't use foul language, remember, a lot of the community is at work when they read these threads.
  • Don't provoke or instigate an argument with someone.
• Double Posting:
  • It's understood that sometimes there's a lag in the system, and sometimes people don't see their post go up right aways so they post again.

    If this happens to you, simply notify a moderator with the report feature in the post, and politely ask them to delete it.

  • If you're just creating another topic because your original topic is not being answered the way you want or at all, this is not tolerated. You could lose your posting privileges all together over it.
• Non-English languages
  • If English is not your primary language, please make an attempt to interpret (yourself or online) and post that interpretation.

    We have wonderful users from around the world, so after you've done your post in English, back it up with your question also in your native tongue (You may find your answer much quicker using both).

That's it for now, I hope you have a wonderful learning experience, and hope to see you contribute to the community as your knowledge grows.

[martin]

What would be the best way to break out of a loop? I currently have a Do Until. While that works, I know in the future it will hang because a description has changed so it will run forever. Can I put a time limit on it?

You can check some condition inside the loop which could be a time period or anything else. You can also add more conditions after the Until. Then if the condition exists that means you want to get out of the loop use ExitLoop.

Eg

$tin = TimerInit()
do
  sleep(100)
  if WinExists("Black Hole") then ExitLoop

  If TimerDiff($tin) > 100000 then ExitLoop
until $stopdition Or $numbox > 5

BTW, it's easier to read your posted script if you tidy it in SciTE, assuming you use SciTE, and enclose it in code tags. Like this

(except that I've added spaces between every character so that you can see what I'm writing.)

[ c o d e ]

;script

[ / c o d e ]