Disapearing control!

robinsiebler · November 4, 2008

I took an existing, functioning app and I added 1 more radio button to it. The new radio button functioned similarly to a new radio button, so I copied the existing, working code. But somehow, when I run the app, the old code works as expected and the new code does not.

If I select the 2nd radio button, and click 'Browse', I get a file dialog. After I select a file and click 'Open' the UI now has an input box visible. However, if I select the 6th radio button, after I close the file dialog, I briefly see an input box appear and then disappear.

#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <StaticConstants.au3>
#include <WindowsConstants.au3>

;~ This is just a simple GUI frontend for my command line tools
;~ __author__ = 'Robin Siebler'
;~ __date__ = '6/20/08'
;~ __version__ = '0.3'

#Region ### START Koda GUI section ### Form=C:\scripts\autoit3\ToolsGUI\ToolsGUI.kxf
$frmTool = GUICreate("Tools GUI", 633, 449, 194, 126)
$grpTools = GUICtrlCreateGroup("Tools", 24, 32, 225, 161)
$radio_1 = GUICtrlCreateRadio("Create ImageList (Picture Viewer)", 40, 48, 185, 17)
$radio_2 = GUICtrlCreateRadio("Get IPs", 40, 69, 89, 17)
$radio_3 = GUICtrlCreateRadio("Route Print", 40, 93, 89, 17)
$radio_4 = GUICtrlCreateRadio("Reboot Servers", 40, 117, 105, 17)
$radio_5 = GUICtrlCreateRadio("SQL Query", 40, 139, 89, 17)
$radio_6 = GUICtrlCreateRadio("Create URL SQL script ", 40, 160, 153, 17)
GUICtrlCreateGroup("", -99, -99, 1, 1)
$lblTools = GUICtrlCreateLabel("Select the tool you wish to use", 24, 8, 148, 17)
$txtInstructions = GUICtrlCreateEdit("", 256, 8, 369, 185, BitOR($ES_AUTOVSCROLL,$ES_AUTOHSCROLL,$ES_WANTRETURN))
GUICtrlSetData(-1, "")
GUICtrlSetState(-1, $GUI_DISABLE)
$lblCmdText = GUICtrlCreateLabel("Command to be used:", 24, 344, 126, 17)
GUICtrlSetFont(-1, 8, 800, 0, "MS Sans Serif")
GUICtrlSetColor(-1, 0xA9D4FF)
$lblCmd = GUICtrlCreateLabel("", 24, 368, 400, 40)
$btnBrowse = GUICtrlCreateButton("Browse", 24, 252, 49, 25)
$lblBrowse = GUICtrlCreateLabel("", 80, 256, 201, 17)
$btnExecute = GUICtrlCreateButton("Execute", 304, 252, 65, 25)
GUICtrlSetState(-1, $GUI_DISABLE)
$inpFile = GUICtrlCreateInput("", 24, 312, 169, 21)
GUICtrlSetState(-1, $GUI_HIDE)
$lblInput = GUICtrlCreateLabel("", 208, 320, 4, 4)
GUICtrlSetState(-1, $GUI_HIDE)
$chkAppend = GUICtrlCreateCheckbox("Append to exising file", 24, 224, 145, 17)
GUICtrlSetState(-1, $GUI_HIDE)
GUISetState(@SW_SHOW)
#EndRegion ### END Koda GUI section ###

;~ VARIABLES 
;~ -----------------------------
;~ variables for radio buttons
$radioval1 = 0   ; We will assume 0 = first radio button selected, 2 = last button
$radioval2 = 4
$current_radio = -1

;~ help messages
$msg_imagelist = "This script will create a list of all of the JPG files in a given dir and then\r\ncreate an AVS file containing an array using those file names.\r\n\r\nUsage:\r\n\r\n    create_imageList [path]\r\n\r\n path = directory containing the project\r\n        (images are expected to be in /images)\r\n\r\nExample:\r\n\r\n   create_imageList c:\\AVE\\Sample_Project"
$msg_ips = "This script will get all of the IPs for the machines listed in the serverlist,\r\nsave the IPs in outputfile and open outputfile in notepad.\r\n\r\nUsage:\r\n\r\n  get_all_ips [serverlist] [outputfile]\r\n\r\n   serverlist  = text file containing server name/IP, 1 per line\r\n   outputfile  = text file in which to write the IPs\r\n\r\nExample:\r\n\r\n   get_all_ips d:\\temp\\serverlist.txt d:\\temp\\ips.txt"
$msg_routeprint = "This script will run 'route print' for the machines listed in the serverlist.\r\n\r\nUsage:\r\n\r\n  route_print [serverlist]\r\n\r\n    serverlist = text file containing server name/IP, 1 per line\r\n\r\nExample:\r\n\r\n    route_print d:\\temp\\serverlist.txt"
$msg_reboot = "This script will reboot all of the machines listed in the serverlist.\r\n\r\nUsage:\r\n\r\n  reboot_servers [serverlist]\r\n\r\n serverlist  = text file containing server name/IP, 1 per line\r\n\r\nExample:\r\n\r\n   reboot_servers d:\\temp\\serverlist.txt"
$msg_sql = "This script will run an SQL query (using the input file), clean up the\r\noutput, and print it to the screen.\r\n\r\nUsage:\r\n\r\n sql_query.exe [inputfile]\r\n\r\n   inputfile = text file containing the SQL query\r\n  Note:  Example queries can be found in \r\n             ftp://10.200.100.19/Robin/test_tools/SQL_queries"

;~ tool command
$msg_cmd_imagelist = "create_imageList.exe "
$msg_cmd_ips = "get_all_ips.exe "
$msg_cmd_routeprint = "get_route_print.exe "
$msg_cmd_reboot = "reboot_servers.exe "
$msg_cmd_sql = "sql_query.exe "
$msg_filedlg_1 = "Browse for server list"
$msg_filedlg_2 = "d:\"
$msg_filedlg_3 = "All (*.*)|Text files (*.txt)"

;~ misc controls
$msg_lblbrowse = "Click to browse for "

ControlClick($frmTool, "", $radio_1)

While 1
    $nMsg = GUIGetMsg()
    If $radioval1 <> 0 Then
        GUICtrlSetState($chkAppend, $GUI_HIDE)
    EndIf
    If $radioval1 <> 1 Then
        GUICtrlSetState($lblInput, $GUI_HIDE)
        GUICtrlSetState($inpFile, $GUI_HIDE)
        GUICtrlSetData($inpFile, "")
        
    EndIf
    Select
        Case $nMsg = $GUI_EVENT_CLOSE
            Exit
        Case $nMsg >= $radio_1 And $nMsg <= $radio_6
            $radioval1 = $nMsg - $radio_1
            Select
                Case $radioval1 = 0
                    disableExecute()
                    $cmd = $msg_cmd_imagelist
                    $args = "[path]"
                    GUICtrlSetData($txtInstructions, StringFormat($msg_imagelist))
                    GUICtrlSetState($chkAppend, $GUI_SHOW)
                    GUICtrlSetData($lblCmd,  $cmd & $args)
                    GUICtrlSetData($lblBrowse, $msg_lblbrowse & "project path")
                Case $radioval1 = 1
                    disableExecute()
                    $cmd = $msg_cmd_ips
                    $args = "[serverlist] [outputfile]"
                    GUICtrlSetData($txtInstructions, StringFormat($msg_ips))
                    GUICtrlSetData($lblCmd, $cmd & $args)
                    GUICtrlSetData($lblBrowse, $msg_lblbrowse & "server list")
                Case $radioval1 = 2
                    disableExecute()
                    $cmd = $msg_cmd_routeprint
                    $args = "[serverlist]"
                    GUICtrlSetData($txtInstructions, StringFormat($msg_routeprint))
                    GUICtrlSetData($lblCmd, $cmd & $args)
                    GUICtrlSetData($lblBrowse, $msg_lblbrowse & "server list")
                Case $radioval1 = 3
                    disableExecute()
                    $cmd = $msg_cmd_reboot
                    $args = "[serverlist]"
                    GUICtrlSetData($txtInstructions, StringFormat($msg_reboot))
                    GUICtrlSetData($lblCmd, $cmd & $args)
                    GUICtrlSetData($lblBrowse, $msg_lblbrowse & "server list")
                Case $radioval1 = 4
                    disableExecute()
                    $cmd = $msg_cmd_sql
                    $args = "[input file]"
                    GUICtrlSetData($txtInstructions, StringFormat($msg_sql))
                    GUICtrlSetData($lblCmd, $msg_cmd_sql & $args)
                    GUICtrlSetData($lblBrowse, $msg_lblbrowse & "input file")
                Case $radioval1 = 5
                    disableExecute()
                    $cmd = $msg_cmd_ips
                    $args = "[serverlist] [outputfile]"
                    GUICtrlSetData($txtInstructions, StringFormat($msg_ips))
                    GUICtrlSetData($lblCmd, $cmd & $args)
                    GUICtrlSetData($lblBrowse, $msg_lblbrowse & "server list")
            EndSelect
        Case $nMsg = $btnBrowse
            Select
                Case $radioval1 = 0
                    $folder = FileSelectFolder("Browse for project path", "d:\", "2")
                    If StringInStr($folder, " ") Then $folder = '"' & $folder & '"'
                    $args = $folder
                    GUICtrlSetData($lblCmd, $cmd & $args)
                    GUICtrlSetState($btnExecute, $GUI_ENABLE)
                Case $radioval1 = 1
                    $file = FileOpenDialog($msg_filedlg_1, $msg_filedlg_2, $msg_filedlg_3)
                    If StringInStr($file, " ") Then $file = '"' & $file & '"'
                    $args = $file & " [outputfile]"
                    GUICtrlSetData($lblCmd, $cmd & $args)
                    GUICtrlSetState($lblInput, $GUI_SHOW)
                    GUICtrlSetState($inpFile, $GUI_SHOW)
                    ControlFocus($frmTool, "", $inpFile)
                Case $radioval1 = 2
                    $file = FileOpenDialog($msg_filedlg_1, $msg_filedlg_2, $msg_filedlg_3)
                    If StringInStr($file, " ") Then $file = '"' & $file & '"'
                    $args = $file
                    GUICtrlSetData($lblCmd, $cmd & $args)
                    GUICtrlSetState($btnExecute, $GUI_ENABLE)
                Case $radioval1 = 3
                    $file = FileOpenDialog($msg_filedlg_1, $msg_filedlg_2, $msg_filedlg_3)
                    If StringInStr($file, " ") Then $file = '"' & $file & '"'
                    $args = $file
                    GUICtrlSetData($lblCmd, $cmd & $args)
                    GUICtrlSetState($btnExecute, $GUI_ENABLE)
                Case $radioval1 = 4
                    $file = FileOpenDialog("Browse for input file (SQL query)", @ScriptDir, "SQL Query (*.sql)")
                    If StringInStr($file, " ") Then $file = '"' & $file & '"'
                    $args = $file
                    GUICtrlSetData($lblCmd, $cmd & $args)
                    GUICtrlSetState($btnExecute, $GUI_ENABLE)
                Case $radioval1 = 5
                    $file = FileOpenDialog($msg_filedlg_1, $msg_filedlg_2, $msg_filedlg_3)
                    If StringInStr($file, " ") Then $file = '"' & $file & '"'
                    $args = $file & " [outputfile]"
                    GUICtrlSetData($lblCmd, $cmd & $args)
                    GUICtrlSetState($lblInput, $GUI_SHOW)
                    GUICtrlSetState($inpFile, $GUI_SHOW)
                    ControlFocus($frmTool, "", $inpFile)
            EndSelect
        Case $nMsg = $btnExecute
            Run(@ComSpec & " /k echo " & $cmd & $args & Chr(38) & $cmd & $args, @ScriptDir)
            GUICtrlSetState($btnExecute, $GUI_DISABLE)
        Case $nMsg = $inpFile
            Select
                Case $radioval1 = 1
                    $out_file =  GUICtrlRead($inpFile)
                    If StringInStr($out_file, " ") Then $out_file = '"' & $out_file & '"'
                    $args = $file & " " & $out_file
                    GUICtrlSetData($lblCmd, $msg_cmd_ips & $args)
                    GUICtrlSetState($btnExecute, $GUI_ENABLE)
                Case $radioval1 = 5
                    $out_file =  GUICtrlRead($inpFile)
                    If StringInStr($out_file, " ") Then $out_file = '"' & $out_file & '"'
                    $args = $file & " " & $out_file
                    GUICtrlSetData($lblCmd, $msg_cmd_ips & $args)
                    GUICtrlSetState($btnExecute, $GUI_ENABLE)
            EndSelect
            Case $nMsg = $chkAppend
                If _IsChecked($chkAppend) Then
                    GUICtrlSetData($lblCmd, $msg_cmd_imagelist & "-a " & $args)
                Else
                    GUICtrlSetData($lblCmd, $msg_cmd_imagelist & $args)
                EndIf
    EndSelect
WEnd

Func disableExecute()
    if $current_radio <> $radioval1 Then
        GUICtrlSetState($btnExecute, $GUI_DISABLE)
        $current_radio = $radioval1
    EndIf
EndFunc

Func _IsChecked($control)
    Return BitAnd(GUICtrlRead($control),$GUI_CHECKED) = $GUI_CHECKED
EndFunc

ToolsGUI_original.au3

robinsiebler · November 4, 2008

The problem lies in the below code, but nothing I have tried has worked.

While 1
    $nMsg = GUIGetMsg()
    If $radioval1 <> 0 Then
        GUICtrlSetState($chkAppend, $GUI_HIDE)
    EndIf
    If $radioval1 <> 1 Then
        GUICtrlSetState($lblInput, $GUI_HIDE)
        GUICtrlSetState($inpFile, $GUI_HIDE)
        GUICtrlSetData($inpFile, "")
        
    EndIf

I tried using

If $radioval1 <> 1 Then or $radioval1 <> 5 Then

but that didn't work. I had to list each value separately. Edited November 4, 2008 by robinsiebler

rasim · November 5, 2008

I tried using
If $radioval1 <> 1 Then or $radioval1 <> 5 Then
but that didn't work. I had to list each value separately.

Wrong syntax, try this:

If ($radioval1 <> 1) Or ($radioval1 <> 5) Then...

robinsiebler · November 5, 2008

That still doesn't work for me. :mellow:

If ($radioval1 <> 1) Or ($radioval1 <> 5) Then
        EzSkinCtrlSetData($inpFile, "")
        disableInput()
    EndIf

This still gives me the same disappearing control when the last radio button is selected.

ajag · November 5, 2008

How I understand you want the InputBox stay visible when selecting the RadioButton 1 or 5, right?

Then the code has to be like

If ($radioval1 <> 1) and ($radioval1 <> 5)Then
        GUICtrlSetState($lblInput, $GUI_HIDE)
        GUICtrlSetState($inpFile, $GUI_HIDE)
        GUICtrlSetData($inpFile, "")
        
    EndIf

A-Jay

Edited November 5, 2008 by ajag

robinsiebler · November 5, 2008

That worked! Why is it And instead of Or

Edited November 5, 2008 by robinsiebler

enaiman · November 5, 2008

It is because of "OR" behaviour.

True OR True = True

True OR False = True

False OR True = True

False OR False = False

You can see that ($radioval1 <> 1) Or ($radioval1 <> 5) it will return always True because at any time at least one condition will be true.

e.g. if $radioval =1 then ($radioval1 <> 1) = False and ($radioval1 <> 5) = True so the result of Or will be also True.

Just be a little careful in the future and you can avoid this happening again.

Edited November 5, 2008 by enaiman

Sign In

Disapearing control!

Recommended Posts

robinsiebler

Link to comment

Share on other sites

robinsiebler

Link to comment

Share on other sites

rasim

Link to comment

Share on other sites

robinsiebler

Link to comment

Share on other sites

ajag

Link to comment

Share on other sites

robinsiebler

Link to comment

Share on other sites

enaiman

Link to comment

Share on other sites

Create an account or sign in to comment

Create an account

Sign in

Recently Browsing 0 members

Browse

AutoIt Resources

Release

Beta