RegRead-RegWrıte Bıg Problem

[FATIHTALI]

Hello I used THIS code for add a value ın environment of PATH.

When I run my program everything look like normal. I am seeIng new values In Environment tab. But my path broken completely. Now All path env. doesn't work.

In command prompt I trying to run IPCONFIG. IT Is sayıng Path not found.

maybe It Is a bug maybe wrong code.

when I delete "PATH" so add again problem resolving.

Can anyone help me.

CODE

$path = RegRead("HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment","PATH")

$path2 = ";c:\Program Files\Microsoft Office\OFFICE11"

$path3 = ";c:\Program Files\Microsoft Office\OFFICE12"

$path4 = $path & $path2 & $path3

RegWrite("HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment","PATH","REG_SZ", $path4)

[GEOSoft]

Hello I used THIS code for add a value ın environment of PATH.

When I run my program everything look like normal. I am seeIng new values In Environment tab. But my path broken completely. Now All path env. doesn't work.

In command prompt I trying to run IPCONFIG. IT Is sayıng Path not found.

maybe It Is a bug maybe wrong code.

when I delete "PATH" so add again problem resolving.

Can anyone help me.

CODE

$path = RegRead("HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment","PATH")

$path2 = ";c:\Program Files\Microsoft Office\OFFICE11"

$path3 = ";c:\Program Files\Microsoft Office\OFFICE12"

$path4 = $path & $path2 & $path3

RegWrite("HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment","PATH","REG_SZ", $path4)

That's right, it won't be found. First thing is Restore your system to before you tried to change the registry and then come back for instructions.

[Danny35d]

The only wrong thing I can see in your code is the registry type. I'm using windows XP Sp3 and when I look at the registry key that you are trying to update the type is REG_EXPAND_SZ not REG_SZ.

[FATIHTALI]

The only wrong thing I can see in your code is the registry type. I'm using windows XP Sp3 and when I look at the registry key that you are trying to update the type is REG_EXPAND_SZ not REG_SZ.

I have found same reason. I think problem is this.

I dont know how can I resolve problem in 1500 computer.

[GEOSoft]

Read the help file for RegRead()

When reading a REG_MULTI_SZ key the multiple entries are separated by @LF - use with StringSplit(..., @LF) to get each entry.

@EXTENDED is set to the type of the value $REG_... .

So Run this and read the results.

$path = RegRead("HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment","PATH")
msgBox(0, "Results","Key Type = " & @Extended & @CRLF & @CRLF & $Path)

If Key Type = 7 Then you have to use StringSplit($Path, @LF)

Then You go and read the same precautions in the help page for RegWrite()

EDIT:

I should have mentioned that on my XP system that key is REG_SZ (type 1) while on Win 7 (and presumably Vista) it is REG_MULTI_SZ (type 7)

That means that to do both types of systems You will have to conditionally create the values to write based on @Extended.

Edited April 6, 2009 by GEOSoft

[GEOSoft]

$sSep = ";"
$sType = "REG_SZ"
$path = RegRead("HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment","PATH")
If @Extended = 7 Then
    $sSep = @LF
    $sType = "REG_MULTI_SZ"
EndIf
$path2 = $sSep & "c:\Program Files\Microsoft Office\OFFICE11"
$path3 = $sSep & "c:\Program Files\Microsoft Office\OFFICE12"
$path4 = $path & $path2 & $path3
RegWrite("HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment","PATH",$sType, $path4)

Edit for syntax error

EDIT 2: BTW, I wouldn't hard code the Office paths in there. Get them from the registry as well. They could be different on different systems. If You are going to hard code them then use the @ProgramFilesDir Macro instead of c:\Program Files because that is even variable by locale.

Edited April 6, 2009 by GEOSoft

[FATIHTALI]

$sSep = ";"
$sType = "REG_SZ"
$path = RegRead("HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment","PATH")
If @Extended = 7 Then
    $sSep = @LF
    $sType = "REG_MULTI_SZ"
EndIf
$path2 = $sSep & "c:\Program Files\Microsoft Office\OFFICE11"
$path3 = $sSep & "c:\Program Files\Microsoft Office\OFFICE12"
$path4 = $path & $path2 & $path3
RegWrite("HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment","PATH",$sType, $path4)

Edit for syntax error

EDIT 2: BTW, I wouldn't hard code the Office paths in there. Get them from the registry as well. They could be different on different systems. If You are going to hard code them then use the @ProgramFilesDir Macro instead of c:\Program Files because that is even variable by locale.

I going to resolve my problem like that. I select easy method. I will use your example in next programs.

Thanks everybody.

$path = RegRead("HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment","PATH")

RegWrite("HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment","PATH","REG_EXPAND_SZ", $path)