Running "takeown.exe"

[llewxam]

Hi folks. What I'm trying to do it script "takeown.exe" for use in a data backup app I am throwing together for work. Takeown /r should work recursively but for some reason won't, but when I run it (manually from a DOS box) without the /r it works fine. So I got ahold of a script to do the file/folder recursion for me, but now I can't get takeown to execute properly.

I have tried runwait, shellexecutewait, and _rundos (and included #include process.au3 for the _rundos), and have tried including quotes in all the ways I know how to ensure that I wasn't having a path error. Here is a snippet of what I have currently, which looks like it should work, though it is incomplete in a few ways, still the takeown part looks good.

expandcollapse popup

$thisclean=0

if FileExists($sourcedrive&"documents and settings\"&$user&"\my documents")=0 then $thisclean=1
if $thisclean=0 then GUICtrlSetData($foundinfo, "The "&$user&" account is ready")
if $thisclean=1 then $clean=1
if $clean=1 then
        
     $yesorno=msgBox(4,"Private folders found","The "&$user&" account was found to have private folders, would you like to take ownership of the profile?")
     if $yesorno=6 then 
                    
          $fa_dir=$sourcedrive&"documents and settings\"&$user
          shellexecuteWait(""""&@tempdir&"\takeown.exe""",$fa_dir)
         ;$thecommand=@tempdir&"\takeown.exe "&""""&$fa_dir&""""              (previous idea)
          call ("findall", $fa_dir)





func findall($fa_dir)

    $f_search = fileFindFirstFile($fa_dir & "\*.*")
    if $f_search==-1 then return 0; specified folder is empty!
    while @error<>1
        $f_file = fileFindNextFile($f_search)
    ; skip these
        if $f_file=="." or $f_file==".." or $f_file=="" then
            continueLoop
        endIf
    ; if it's a dir then call this function again (nesting the function is clever;)
        if stringInStr(fileGetAttrib($fa_dir & "\" & $f_file), "D") > 0 then
            shellexecuteWait(""""&@tempdir&"\takeown.exe""",$fa_dir)
            findall($fa_dir & "\" & $f_file)
    else
        ; File we need to dealwith
    
                shellexecutewait(@tempdir&"\takeown.exe "&""""&$fa_dir&"\"&$f_file&"""")
        endIf
    wEnd
    fileClose($f_search)
    return 1

endFunc

Any help would be much appreciated. This is being run on XP using the takeown.exe available as part of the Win2k Resource Kit, if you need it for testing it can be downloaded here

Ian

[Authenticity]

You can add a few ConsoleWrite or MsgBox calls in the code to see how the path looks like. Maybe it's something like C:Document and Settings\blah...

[llewxam]

You can add a few ConsoleWrite or MsgBox calls in the code to see how the path looks like. Maybe it's something like C:Document and Settings\blah...

hehe, already did with msgbox, all looked fine.

For what it's worth, I forgot to mention that I use

FileInstall("takeown.exe",@TempDir&"\takeown.exe",1)

but have run items from @tempdir before with no problems......

Thanks

Ian

[Authenticity]

What about:

Run(@tempdir & '\takeown.exe "' & $fa_dir & '"')

[TurionAltec]

This:

call ("findall", $fa_dir)

can just be:

findall($fa_dir)

to more easily escape double quotes(") you can surround them with single quotes.

Also it looks like you're trying to format your commands differently for each instances of takeown. We should see if we can get one working, and then move on.

With Shellexecute the first parameter is the file name, and program parameters are supposed to be in the second parameter, so:

shellexecutewait(@tempdir&"\takeown.exe "&""""&$fa_dir&"\"&$f_file&"""")

becomes

shellexecutewait(@tempdir&"\takeown.exe", '"'&$fa_dir&"\"&$f_file&'"')

Edited May 20, 2009 by TurionAltec

[llewxam]

This:

call ("findall", $fa_dir)

can just be:

findall($fa_dir)

to more easily escape double quotes(") you can surround them with single quotes.

Also it looks like you're trying to format your commands differently for each instances of takeown. We should see if we can get one working, and then move on.

With Shellexecute the first parameter is the file name, and program parameters are supposed to be in the second parameter, so:

shellexecutewait(@tempdir&"\takeown.exe "&""""&$fa_dir&"\"&$f_file&"""")

becomes

shellexecutewait(@tempdir&"\takeown.exe", '"'&$fa_dir&"\"&$f_file&'"')

Thanks so much everyone for the help, especially the bit about single quotes surrounding double quotes, I've been curious about single quotes but haven't bothered looking for info on them. But, I did find a fix, what I have now (working) for the function is:

func findall($fa_dir)
            $formattedfadir=""""&$fa_dir&""""
            RunWait(@tempdir&"\takeown.exe "&$formattedfadir)

    $f_search = fileFindFirstFile($fa_dir & "\*.*")
    if $f_search==-1 then return 0; specified folder is empty!
    while @error<>1
        $f_file = fileFindNextFile($f_search)
    ; skip these
        if $f_file=="." or $f_file==".." or $f_file=="" then
            continueLoop
        endIf
    ; if it's a dir then call this function again (nesting the function is clever;)
        if stringInStr(fileGetAttrib($fa_dir & "\" & $f_file), "D") > 0 then
            RunWait(@tempdir&"\takeown.exe "&$formattedfadir)
            findall($fa_dir & "\" & $f_file)
        else
        ; File we need to dealwith
                
                $formattedffile=""""&$fa_dir&"\"&$f_file&""""
                runwait(@tempdir&"\takeown.exe "&$formattedffile)

        endIf
    wEnd
    fileClose($f_search)
    return 1

endFunc

I may look in to the other options suggested here for experimentation's sake, but for now I'm gonna call it a win and move on

When the project is completed, maybe I'll post it here for general suggestions/improvements/giggles at my noobishness

Thanks again!

Ian