How do I break this loop?

[NickBtheITguy]

I have a script that goes through and basically selects every entry on the screen so they can be deleted. They are in list format and I pass a Down and a Space key press. This works. But what I am running into is that I am not able to break the loop when I reach the end of the list. I have posted a screenshot of the bottom of the application and the code I have so far on the script. It gets to that last entry and then just continues to select and deselect the last entry. The control ID is 7009 in the code.

; This is the loop that goes through and selects all of the entries.
If Not ControlFocus("Engagement Plus", "", 7009) Then
    
    ExitLoop
    
    Else
    
    while ControlFocus("Engagement Plus", "", 7009)
        Send("{SPACE}")
        Send("{DOWN}")
    wend
Endif
    
    
 
Send("{ALT}F")
Send("D")
 
WinWaitActive("Delete Confirmation")
Send("{Enter}")

Edited July 8, 2009 by NickBtheITguy

[llewxam]

I have a script that goes through and basically selects every entry on the screen so they can be deleted. They are in list format and I pass a Down and a Space key press. This works. But what I am running into is that I am not able to break the loop when I reach the end of the list. I have posted a screenshot of the bottom of the application and the code I have so far on the script. It gets to that last entry and then just continues to select and deselect the last entry. The control ID is 7009 in the code.

; This is the loop that goes through and selects all of the entries.
If Not ControlFocus("Engagement Plus", "", 7009) Then
    
    ExitLoop
    
    Else
    
    while ControlFocus("Engagement Plus", "", 7009)
        Send("{SPACE}")
        Send("{DOWN}")
    wend
Endif
    
    
 
Send("{ALT}F")
Send("D")
 
WinWaitActive("Delete Confirmation")
Send("{Enter}")

The ExitLoop has to be within a "Do...Until", an "If...EndIf" isn't valid. I made a very slight change:

Do
    If Not ControlFocus("Engagement Plus", "", 7009) Then
        
        ExitLoop
        
        Else
        
        while ControlFocus("Engagement Plus", "", 7009)
            Send("{SPACE}")
            Send("{DOWN}")
        wend
    Endif
Until 1=2
   
 
Send("{ALT}F")
Send("D")
 
WinWaitActive("Delete Confirmation")
Send("{Enter}")

That no longer fails with a CTRL-F5 (syntax check). Not sure if that will fix everything, but check it out.

Ian

[eignxing]

Something like this? example with notepad:

sleep(2000)

If ControlFocus("Untitled - Notepad", "", 15) = 1 Then
    Do
        Send("{SPACE}")
            Send("{DOWN}")
    Until ControlFocus("Untitled - Notepad", "", 15) <> 1
EndIf

[NickBtheITguy]

The ExitLoop has to be within a "Do...Until", an "If...EndIf" isn't valid. I made a very slight change:

Do
    If Not ControlFocus("Engagement Plus", "", 7009) Then
        
        ExitLoop
        
        Else
        
        while ControlFocus("Engagement Plus", "", 7009)
            Send("{SPACE}")
            Send("{DOWN}")
        wend
    Endif
Until 1=2
   
 
Send("{ALT}F")
Send("D")
 
WinWaitActive("Delete Confirmation")
Send("{Enter}")

That no longer fails with a CTRL-F5 (syntax check). Not sure if that will fix everything, but check it out.

Ian

I'm not having a problem with the loop running or syntax check popping anything up. The problem is that the last entry will always have focus so the script just continues to run at the end selecting and deselecting the last entry.

[NickBtheITguy]

Something like this? example with notepad:

sleep(2000)

If ControlFocus("Untitled - Notepad", "", 15) = 1 Then
    Do
        Send("{SPACE}")
            Send("{DOWN}")
    Until ControlFocus("Untitled - Notepad", "", 15) <> 1
EndIf

The problem that I am running into though is that last entry always has focus. So by saying lets loop until it doesn't, I never get to the point where it doesn't have focus.

[bo8ster]

Its less about how to break the loop, more that the loop will never break because it never knows to. It is always going to have focus even when it gets to the end and since it does not know when it gets to the end, it is never going to stop. The problem is more the control condition you chose then anything else.

You need to know when you are at the bottom, I suggest you get a handle to the listview or whatever it is then get the count. From there you will know how many times to loop.

Also I would guess the ControlID is for the control, not the one row in the control.

Edited July 9, 2009 by bo8ster

[NickBtheITguy]

Its less about how to break the loop, more that the loop will never break because it never knows to. It is always going to have focus even when it gets to the end and since it does not know when it gets to the end, it is never going to stop. The problem is more the control condition you chose then anything else.

You need to know when you are at the bottom, I suggest you get a handle to the listview or whatever it is then get the count. From there you will know how many times to loop.

Also I would guess the ControlID is for the control, not the one row in the control.

Wouldn't I run into the same problem trying to get the count of the listview?

[PsaltyDS]

Wouldn't I run into the same problem trying to get the count of the listview?

Spend some time in the help file with the example scripts there. Try out ControlListView(), and if you feel bold, try out the _GuiCtrlListView_* functions.

Get the ID or handle to the ListView, get the item count, then loop only enough times to cover that count.

[NickBtheITguy]

Spend some time in the help file with the example scripts there. Try out ControlListView(), and if you feel bold, try out the _GuiCtrlListView_* functions.

Get the ID or handle to the ListView, get the item count, then loop only enough times to cover that count.

Thanks for your help guys. I think I misunderstood earlier about the ControlListView(). That was exactly what I was looking for.