Is this a bug? (Listview)

[Rawox]

Hey people!

I just changes 1 ; and a part of script didn't worked anymore.

Original:

Case $GetF
        $Files = FileOpenDialog ( $Title & " - Select files.", $DefaultDir, "All (*.*)", 4 )
        _GUICtrlListView_DeleteAllItems ( GUICtrlGetHandle ( $List ) )
        $Split = StringSplit ( $Files, "|" )
        _ArrayDisplay ( $Split )
        If @error = 1 Then
            Sleep ( 10 )
        ElseIf $Split[0] = 1 Then
            Dim $szDrive, $szDir, $szFName, $szExt
            $Item = _PathSplit ( $Split[1], $szDrive, $szDir, $szFName, $szExt )
            _GUICtrlListView_AddItem ( $List, $szFName & $szExt )
            _GUICtrlListView_AddSubItem ( $List, 0, $szDrive & $szDir, 1 )
        Else
            $j = 1
            $x = 0
            Do
                $j += 1
                _GUICtrlListView_AddItem ( $List, $Split[$j] )
                _GUICtrlListView_AddSubItem ( $List, $x, $Split[1] & "\", 1 )
                $x += 1
            Until $j = $Split[0]
        EndIf

New:

Case $GetF
        $Files = FileOpenDialog ( $Title & " - Select files.", $DefaultDir, "All (*.*)", 4 )
        _GUICtrlListView_DeleteAllItems ( GUICtrlGetHandle ( $List ) )
        $Split = StringSplit ( $Files, "|" )
        ;_ArrayDisplay ( $Split )
        If @error = 1 Then
            Sleep ( 10 )
        ElseIf $Split[0] = 1 Then
            Dim $szDrive, $szDir, $szFName, $szExt
            $Item = _PathSplit ( $Split[1], $szDrive, $szDir, $szFName, $szExt )
            _GUICtrlListView_AddItem ( $List, $szFName & $szExt )
            _GUICtrlListView_AddSubItem ( $List, 0, $szDrive & $szDir, 1 )
        Else
            $j = 1
            $x = 0
            Do
                $j += 1
                _GUICtrlListView_AddItem ( $List, $Split[$j] )
                _GUICtrlListView_AddSubItem ( $List, $x, $Split[1] & "\", 1 )
                $x += 1
            Until $j = $Split[0]
        EndIf

All I did is commented the ArrayDisplay. And if you now select one file from the FileOpenDialog nothing is displayed in the listview. Altough if I uncomment the ArrayDisplay it does work with just one file :S

Is it a bug or what?

Rawox.

[Melba23]

Rawox,

It looks to me as if you have a logic error about which @error you are testing. In the first case, you are testing the @error from the active _ArrayDisplay command; in the second case you are testing the @error directly from the StringSplit as the _ArrayDisplay is commented out..

In the second case, if you select only one file, StringSplit will set the @error because no delimiters were found - from the Help file: "If no delimiters were found @error is set to 1, the count is 1 ($array[0]) and the full string is returned ($array[1])".

I would suggest that you change the code logic to check for the "No files" case immediately after the FileOpenDialog - which will set @error if no files are selected.

M23

[Yashied]

;_ArrayDisplay ( $Split )

If @error = 1 Then <= ???

EDIT:

I was late.

Edited July 17, 2009 by Yashied