Modify ↓

Opened on Jul 2, 2021 at 1:50:01 PM

Closed on Jul 11, 2021 at 11:14:14 AM

Last modified on Mar 30, 2022 at 10:08:36 AM

#3835 closed Bug (Fixed)

Replace constants with magic numbers

Reported by: anonymous Owned by: J-Paul Mesnage
Milestone: 3.3.15.5 Component: Documentation
Version: 3.3.14.5 Severity: None
Keywords: Cc:

Description

Constants are already declared, but not used in the documentation.

​TraySetClick

$TRAY_CLICK_SHOW
$TRAY_CLICK_PRIMARYDOWN
$TRAY_CLICK_PRIMARYUP
$TRAY_DBLCLICK_PRIMARY
$TRAY_CLICK_SECONDARYDOWN
$TRAY_CLICK_SECONDARYUP
$TRAY_DBLCLICK_SECONDARY
$TRAY_CLICK_HOVERING

​_GDIPlus_GraphicsSetCompositingMode

$GDIP_COMPOSITINGMODESOURCEOVER
$GDIP_COMPOSITINGMODESOURCECOPY

​_GDIPlus_GraphicsSetCompositingQuality

$GDIP_COMPOSITINGQUALITYDEFAULT
$GDIP_COMPOSITINGQUALITYHIGHSPEED
$GDIP_COMPOSITINGQUALITYHIGHQUALITY
$GDIP_COMPOSITINGQUALITYGAMMACORRECTED
$GDIP_COMPOSITINGQUALITYASSUMELINEAR

​_GDIPlus_GraphicsSetInterpolationMode

$GDIP_INTERPOLATIONMODE_DEFAULT
$GDIP_INTERPOLATIONMODE_LOWQUALITY
$GDIP_INTERPOLATIONMODE_HIGHQUALITY
$GDIP_INTERPOLATIONMODE_BILINEAR
$GDIP_INTERPOLATIONMODE_BICUBIC
$GDIP_INTERPOLATIONMODE_NEARESTNEIGHBOR
$GDIP_INTERPOLATIONMODE_HIGHQUALITYBILINEAR
$GDIP_INTERPOLATIONMODE_HIGHQUALITYBICUBIC

​_GDIPlus_GraphicsSetPixelOffsetMode

$GDIP_PIXELOFFSETMODE_DEFAULT
$GDIP_PIXELOFFSETMODE_HIGHSPEED
$GDIP_PIXELOFFSETMODE_HIGHQUALITY
$GDIP_PIXELOFFSETMODE_NONE
$GDIP_PIXELOFFSETMODE_HALF

​_GDIPlus_GraphicsSetSmoothingMode

$GDIP_SMOOTHINGMODE_DEFAULT
$GDIP_SMOOTHINGMODE_HIGHSPEED
$GDIP_SMOOTHINGMODE_HIGHQUALITY 
$GDIP_SMOOTHINGMODE_NONE
$GDIP_SMOOTHINGMODE_ANTIALIAS8X4
$GDIP_SMOOTHINGMODE_ANTIALIAS
$GDIP_SMOOTHINGMODE_ANTIALIAS8X8

​_GDIPlus_GraphicsSetTextRenderingHint

$GDIP_TEXTRENDERINGHINT_SYSTEMDEFAULT
$GDIP_TEXTRENDERINGHINT_SINGLEBITPERPIXELGRIDFIT
$GDIP_TEXTRENDERINGHINT_SINGLEBITPERPIXEL
$GDIP_TEXTRENDERINGHINT_ANTIALIASGRIDFIT
$GDIP_TEXTRENDERINGHINT_ANTIALIAS
$GDIP_TEXTRENDERINGHINT_CLEARTYPEGRIDFIT

+ Remove duplicates

$GDIP_TextRenderingHintSystemDefault
$GDIP_TextRenderingHintSingleBitPerPixelGridFit
$GDIP_TextRenderingHintSingleBitPerPixel
$GDIP_TextRenderingHintAntialiasGridFit
$GDIP_TextRenderingHintAntialias
$GDIP_TextRenderingHintClearTypeGridFit

AutoIt Version: 3.3.14.5 / 3.3.15.4

Attachments (0)

Change History (5)

comment:1 by anonymous, on Jul 2, 2021 at 1:57:08 PM

Lead to a uniform style

$GDIP_COMPOSITINGMODE_SOURCEOVER
$GDIP_COMPOSITINGMODE_SOURCECOPY

$GDIP_COMPOSITINGQUALITY_DEFAULT
$GDIP_COMPOSITINGQUALITY_HIGHSPEED
$GDIP_COMPOSITINGQUALITY_HIGHQUALITY
$GDIP_COMPOSITINGQUALITY_GAMMACORRECTED
$GDIP_COMPOSITINGQUALITY_ASSUMELINEAR

comment:2 by anonymous, on Jul 2, 2021 at 1:58:57 PM 

$TRAY_CLICK_SHOW
$TRAY_CLICK_PRIMARYDOWN
$TRAY_CLICK_PRIMARYUP
$TRAY_CLICK_PRIMARYDBL
$TRAY_CLICK_SECONDARYDOWN
$TRAY_CLICK_SECONDARYUP
$TRAY_CLICK_SECONDARYDBL
$TRAY_CLICK_HOVERING

comment:3 by J-Paul Mesnage, on Jul 11, 2021 at 10:02:58 AM

Summary: Replace magic numbers with constants → Replace constants with magic numbers

comment:4 by J-Paul Mesnage, on Jul 11, 2021 at 11:14:14 AM

Milestone: → 3.3.15.5
Owner: set to J-Paul Mesnage
Resolution: → Fixed
Status: new → closed

Fixed by revision [12580] in version: 3.3.15.5

comment:5 by J-Paul Mesnage, on Mar 30, 2022 at 10:08:36 AM

I revert the GDIPlus.au3 regression
Fix in 3.3.16.1
Sorry for the trouble

Modify Ticket

Action
as closed The owner will remain J-Paul Mesnage.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.