Modify

Opened 10 years ago

Closed 10 years ago

#1167 closed Bug (Fixed)

_FTP_ProgressDownload crashes

Reported by: ProgAndy Owned by: Jpm
Milestone: 3.3.1.4 Component: Standard UDFs
Version: 3.3.1.3 Severity: Blocking
Keywords: Cc:

Description

_FTP_ProgressDownload crashes with the message "error allocating memory". The reason for this is a wrong order of the params in the call for _WinAPI_MakeQWord.

$glen = _WinAPI_MakeQWord($ai_FTPGetFileSize[2], $ai_FTPGetFileSize[0])
It should be changed to this:
$glen = _WinAPI_MakeQWord($ai_FTPGetFileSize[0], $ai_FTPGetFileSize[2])

Attachments (0)

Change History (6)

comment:1 Changed 10 years ago by ProgAndy

This bug also occurs in:
_FTP_FileGetSize (line 461)
FTP_ListToArray (line 1184, 1205)

I think this bug has been created when inverting the params of _WinAPI_MakeQWord
( ;_FTPFileTimeLoHi ; --> _WinAPI_MakeQWord ; parameter inversion )

comment:2 Changed 10 years ago by Jpm

  • Milestone set to 3.3.1.2
  • Resolution set to Fixed
  • Status changed from new to closed

already fix in next beta 3.3.1.2

comment:3 Changed 10 years ago by partypooper@…

This bug has reappeared in 3.3.1.3. Line 975 of FTPEx.au3 has:

$glen = _WinAPI_MakeQWord($ai_FTPGetFileSize[2], $ai_FTPGetFileSize[0]) ;FileGetSize($s_RemoteFile)

It should be:

$glen = _WinAPI_MakeQWord($ai_FTPGetFileSize[0], $ai_FTPGetFileSize[2]) ;FileGetSize($s_RemoteFile)

comment:4 Changed 10 years ago by Valik

  • Milestone 3.3.1.2 deleted
  • Resolution Fixed deleted
  • Severity changed from None to Blocking
  • Status changed from closed to reopened
  • Version changed from 3.3.1.1 to 3.3.1.3

comment:5 Changed 10 years ago by Jpm

can somebody put a working example of _FTP_ProgressDownload()?
Thanks

comment:6 Changed 10 years ago by Jpm

  • Milestone set to 3.3.1.4
  • Owner changed from Gary to Jpm
  • Resolution set to Fixed
  • Status changed from reopened to closed

Fixed in version: 3.3.1.4

Guidelines for posting comments:

  • You cannot re-open a ticket but you may still leave a comment if you have additional information to add.
  • In-depth discussions should take place on the forum.

For more information see the full version of the ticket guidelines here.

Add Comment

Modify Ticket

Action
as closed The owner will remain Jpm.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.