Modify

Opened 10 years ago

Closed 10 years ago

#1406 closed Feature Request (Rejected)

Proposed Change to _WinAPI_HiWord()

Reported by: wraithdu Owned by: Gary
Milestone: Component: Standard UDFs
Version: Severity: None
Keywords: Cc:

Description

Considering the discussion a few weeks ago about BitShift being a *signed* shift in AutoIt, shouldn't the _WinAPI_HiWord function, and indeed all UDF functions where a DWORD needs to be split into hi and lo words by any means (the _WinAPI_HiWord function or manually via BitShift), be changed accordingly:

Func _WinAPI_HiWord($iLong)
    Return BitAND(BitShift($iLong, 16), 0xFFFF)
EndFunc   ;==>_WinAPI_HiWord

While an error likely won't occur very often, this is the only way to assure we are getting the correct hi word result, unless AutoIt changes the way it does BitShift to be unsigned.

I understand if you want to forgo this change in favor of waiting until AutoIt's internal number handling is revamped, but it is a viable patch in the meantime.

Attachments (0)

Change History (2)

comment:1 Changed 10 years ago by TicketCleanup

  • Version 3.3.3.3 deleted

Automatic ticket cleanup.

comment:2 Changed 10 years ago by Valik

  • Resolution set to Rejected
  • Status changed from new to closed

As mentioned on the forum, temporary fixes are not something I'm fond of making.

Guidelines for posting comments:

  • You cannot re-open a ticket but you may still leave a comment if you have additional information to add.
  • In-depth discussions should take place on the forum.

For more information see the full version of the ticket guidelines here.

Add Comment

Modify Ticket

Action
as closed The owner will remain Gary.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.