Modify

Opened 9 years ago

Closed 9 years ago

#1933 closed Bug (Fixed)

_GetIP is outdated and could possibly fail.

Reported by: guinness Owned by: Valik
Milestone: 3.3.7.18 Component: Standard UDFs
Version: 3.3.7.9 Severity: None
Keywords: Cc:

Description

_GetIP() in Inet.au3 UDF is outdated, due to Source Code changes with WhatIsMyIP. The www.whatismyip.com site has been updated since _GetIP() was first introduced, therefore if www.checkip.dyndns.org was to fail (downtime) so would www.whatismyip.com. I have updated the Function which now doesn't write to a temporary file & uses the www.whatismyip.com's automation page, plus it uses less lines of code!

Link: http://www.autoitscript.com/forum/topic/123641-getip-getipex/page__view__findpost__p__858868

Attachments (0)

Change History (7)

comment:1 Changed 9 years ago by Jon

  • Milestone set to 3.3.7.3
  • Owner changed from Gary to Jon
  • Resolution set to Fixed
  • Status changed from new to closed

Fixed by revision [6013] in version: 3.3.7.3

comment:2 Changed 9 years ago by Jpm

  • Resolution Fixed deleted
  • Status changed from closed to reopened
  • Version changed from 3.3.6.1 to 3.3.7.9

THe second part of the fix does not reference a valid link according to the comment it should be
http://automation.whatismyip.com/n09230945.asp

comment:3 Changed 9 years ago by TicketCleanup

  • Milestone 3.3.7.3 deleted

Automatic ticket cleanup.

comment:4 Changed 9 years ago by guinness

This is because they changed the link at the end of May 2011, if you look at the Forum message (http://forum.whatismyip.com/f14/our-automation-rules-t241/) it was last updated on the 25th May 2011. So at the time of posting the updated code the link was valid. Thanks Jpm for noticing this subtle update by WhatIsMyIP.

comment:5 Changed 9 years ago by Jpm

I hope it will be more stable now

comment:6 Changed 9 years ago by anonymous

I updated my Example and I've had no problems so far with testing. Hopefull they don't change it again! I know my Version is simple and anyone can do it, but I'm so ecstatic that my Function has been included in Inet.au3.

comment:7 Changed 9 years ago by Valik

  • Milestone set to 3.3.7.18
  • Owner changed from Jon to Valik
  • Resolution set to Fixed
  • Status changed from reopened to closed

Fixed by revision [6238] in version: 3.3.7.18

Guidelines for posting comments:

  • You cannot re-open a ticket but you may still leave a comment if you have additional information to add.
  • In-depth discussions should take place on the forum.

For more information see the full version of the ticket guidelines here.

Add Comment

Modify Ticket

Action
as closed The owner will remain Valik.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.